Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-01-01 05:06:53 +08:00
Code Issues Projects Releases Packages Wiki Activity

Removed invalid Action.notificationDismissed firing

Browse source 
Summary:
If a notification is dismissed manually, the setInterval dismissal is still fired.
         This patch adds a check and removes the notification dismissal action from firing

Test Plan: none

Reviewers: ktalwar, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D1218
This commit is contained in:
Evan Morikawa 2015-05-27 12:31:07 -04:00
parent af357ef005
commit ac1ad67123
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
internal_packages/notifications/lib/notifications-store.coffee
View file

@ -74,7 +74,8 @@ NotificationStore = Reflux.createStore
@_notifications[notification.tag] = notification @_notifications[notification.tag] = notification
if notification.expiry? if notification.expiry?
timeoutVal = Math.max(0, notification.expiry - Date.now()) timeoutVal = Math.max(0, notification.expiry - Date.now())
setTimeout(@_removeNotification(notification), timeoutVal) timeoutId = setTimeout(@_removeNotification(notification), timeoutVal)
notification.timeoutId = timeoutId
@trigger() @trigger()
@ -82,6 +83,9 @@ NotificationStore = Reflux.createStore
# above in setTimeout() # above in setTimeout()
_removeNotification: (notification) -> => _removeNotification: (notification) -> =>
console.log "Removed #{notification}" if VERBOSE console.log "Removed #{notification}" if VERBOSE
clearTimeout(notification.timeoutId) if notification.timeoutId
delete @_notifications[notification.tag] delete @_notifications[notification.tag]
@trigger() @trigger()