Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-22 23:23:54 +08:00
Code Issues Projects Releases Packages Wiki Activity

Sentry fix: race condition can cause finalize to be called after captureWindow destroyed

Browse source
This commit is contained in:
Ben Gotow 2019-06-16 13:34:54 -05:00
parent 3994c6e67f
commit acfe38e485
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/quickpreview/index.ts
View file

@ -323,7 +323,9 @@ function _generateNextCrossplatformPreview() {
onFinalize = success => { onFinalize = success => {
clearTimeout(timer); clearTimeout(timer);
captureWindow.removeListener('page-title-updated', onRendererSuccess); if (captureWindow) {
captureWindow.removeListener('page-title-updated', onRendererSuccess);
}
process.nextTick(_generateNextCrossplatformPreview); process.nextTick(_generateNextCrossplatformPreview);
resolve(success); resolve(success);
}; };
@ -336,9 +338,7 @@ async function _generateQuicklookPreview({ filePath }: { filePath: string }) {
const pathQuoted = `"${filePath.replace(/"/g, '\\"')}"`; const pathQuoted = `"${filePath.replace(/"/g, '\\"')}"`;
return new Promise(resolve => { return new Promise(resolve => {
const cmd = `qlmanage -t -f ${ const cmd = `qlmanage -t -f ${window.devicePixelRatio} -s ${ThumbnailWidth} -o ${dirQuoted} ${pathQuoted}`;
window.devicePixelRatio
} -s ${ThumbnailWidth} -o ${dirQuoted} ${pathQuoted}`;
exec(cmd, (error, stdout, stderr) => { exec(cmd, (error, stdout, stderr) => {
// Note: sometimes qlmanage outputs to stderr but still successfully // Note: sometimes qlmanage outputs to stderr but still successfully