From af7d8c98c6c00e6fde8a357f188ce0b74290ca60 Mon Sep 17 00:00:00 2001 From: Evan Morikawa Date: Tue, 14 Mar 2017 10:37:24 -0700 Subject: [PATCH] [client-app] only upload 7 characters of the commit hash Summary: On windows running `git rev-parse --short HEAD` does in fact now give you 9 characters instead of 7 like it does on Mac. This will ensure that builds get uploaded to the same folder and help ensure we don't post a version that doesn't exist on the release page. Test Plan: Manual Reviewers: juan, halla, spang Reviewed By: spang Differential Revision: https://phab.nylas.com/D4217 --- packages/client-app/build/tasks/upload-task.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/client-app/build/tasks/upload-task.js b/packages/client-app/build/tasks/upload-task.js index 1d7ef2261..f04f775c2 100644 --- a/packages/client-app/build/tasks/upload-task.js +++ b/packages/client-app/build/tasks/upload-task.js @@ -23,7 +23,7 @@ module.exports = (grunt) => { if (error) { return reject(); } - const commitHash = stdout ? stdout.trim() : null; + const commitHash = (stdout ? stdout.trim() : "").slice(0, 7); packageVersion = json.version; if (packageVersion.indexOf('-') > 0) { fullVersion = packageVersion;