From b05ea801b0570eef801169600aa483ab5446ffd7 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Thu, 24 Mar 2016 17:18:24 -0700 Subject: [PATCH] fix(popover): Add isMounted check, Sentry 20951 --- src/components/fixed-popover.jsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/components/fixed-popover.jsx b/src/components/fixed-popover.jsx index 48adc48d5..7f1aa2e0d 100644 --- a/src/components/fixed-popover.jsx +++ b/src/components/fixed-popover.jsx @@ -45,6 +45,7 @@ class FixedPopover extends Component { constructor(props) { super(props); + this.mounted = false; this.updateCount = 0 this.fallback = this.props.fallbackDirection; this.state = { @@ -55,6 +56,7 @@ class FixedPopover extends Component { } componentDidMount() { + this.mounted = true; window.addEventListener('resize', this.onWindowResize) this.focusElementWithTabIndex(); _.defer(this.onPopoverRendered) @@ -78,6 +80,7 @@ class FixedPopover extends Component { } componentWillUnmount() { + this.mounted = false; window.removeEventListener('resize', this.onWindowResize) } @@ -86,6 +89,10 @@ class FixedPopover extends Component { } onPopoverRendered = ()=> { + if (!this.mounted) { + return; + } + const {direction} = this.state const currentRect = this.getCurrentRect() const windowDimensions = this.getWindowDimensions()