Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-23 15:46:28 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(change-mail): Fix performRemote never resolving if no threads or messages to process

Browse source
This commit is contained in:
Ben Gotow 2015-09-30 14:09:06 -07:00
parent 029270bcae
commit b7d829bfa1
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
spec-nylas/tasks/change-mail-task-spec.coffee
View file

@ -198,6 +198,15 @@ describe "ChangeMailTask", ->
expect(@task.performRequests).toHaveBeenCalledWith(Message, @task.messages) expect(@task.performRequests).toHaveBeenCalledWith(Message, @task.messages)
expect(@task.performRequests.callCount).toBe(1) expect(@task.performRequests.callCount).toBe(1)
describe "if somehow there are no threads or messages", ->
it "should resolve", ->
@task = new ChangeMailTask()
@task.threads = []
@task.messages = []
waitsForPromise =>
@task.performRemote().then (code) =>
expect(code).toEqual(Task.Status.Finished)
describe "if performRequests resolves", -> describe "if performRequests resolves", ->
it "should resolve with Task.Status.Finished", -> it "should resolve with Task.Status.Finished", ->
@task = new ChangeMailTask() @task = new ChangeMailTask()

7
src/flux/tasks/change-mail-task.coffee
View file

@ -38,8 +38,11 @@ mapLimit = (input, numberInParallel, fn) ->
outputError = err outputError = err
reject(outputError) reject(outputError)
numberInParallel = Math.min(numberInParallel, input.length) if input.length > 0
startNext() for n in [0...numberInParallel] numberInParallel = Math.min(numberInParallel, input.length)
startNext() for n in [0...numberInParallel]
else
resolve([])
# The ChangeMailTask is a base class for all tasks that modify sets of threads or # The ChangeMailTask is a base class for all tasks that modify sets of threads or
# messages. Subclasses implement `_changesToModel` and `_requestBodyForModel` to # messages. Subclasses implement `_changesToModel` and `_requestBodyForModel` to