From bb18f98b83d47546746d2ddf9a2bf4eea6712318 Mon Sep 17 00:00:00 2001 From: Christine Spang Date: Tue, 7 Mar 2017 18:03:26 -0800 Subject: [PATCH] [client-app] Don't report incorrect username or password to Sentry Summary: This is not a bug. Maaaybe we want to report this to MixPanel for individual user debugging (how do we do that?), but it doesn't make sense to report this error to Sentry. Example: https://sentry.io/nylas/nylas-mail/issues/230530818/ Test Plan: yolo Reviewers: mark, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D4130 --- packages/client-app/src/flux/nylas-api-request.es6 | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/client-app/src/flux/nylas-api-request.es6 b/packages/client-app/src/flux/nylas-api-request.es6 index 1ac41275c..48984d23e 100644 --- a/packages/client-app/src/flux/nylas-api-request.es6 +++ b/packages/client-app/src/flux/nylas-api-request.es6 @@ -118,6 +118,7 @@ export default class NylasAPIRequest { async _notifyOfAPIError(apiError) { const ignorableStatusCodes = [ 0, // When errors like ETIMEDOUT, ECONNABORTED or ESOCKETTIMEDOUT occur from the client + 401, // Don't report `Incorrect username or password` 404, // Don't report not-founds 408, // Timeout error code 429, // Too many requests