From c088e86110a469019967c9314067774b220749c3 Mon Sep 17 00:00:00 2001 From: Juan Tejada Date: Wed, 1 Mar 2017 14:38:51 -0800 Subject: [PATCH] [client-app] Include node-mac-notifier in build Summary: Given that `lerna bootstrap` does not install optional dependencies, we need to manually run `npm install` inside `client-app` so `node-mac-notifier` get's correctly installed and included in the build See https://github.com/lerna/lerna/issues/121 Fixes T7887 Test Plan: manual Reviewers: halla, evan Reviewed By: evan Maniphest Tasks: T7887 Differential Revision: https://phab.nylas.com/D4076 --- scripts/postinstall.es6 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/postinstall.es6 b/scripts/postinstall.es6 index 489f024ae..d41b5c2f1 100644 --- a/scripts/postinstall.es6 +++ b/scripts/postinstall.es6 @@ -131,7 +131,16 @@ async function main() { try { await installPrivateResources() await lernaBootstrap(); + + // Given that `lerna bootstrap` does not install optional dependencies, we + // need to manually run `npm install` inside `client-app` so + // `node-mac-notifier` get's correctly installed and included in the build + // See https://github.com/lerna/lerna/issues/121 + console.log("\n---> Reinstalling client-app dependencies to include optional dependencies"); + await npm('install', {cwd: 'packages/client-app'}) + await electronRebuild(); + linkJasmineConfigs(); linkIsomorphicCoreSpecs(); } catch (err) {