Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-09-26 22:47:50 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix HTML conversion of pasted CRLF delimited plain text (on Windows) #1756

Browse source
This commit is contained in:
Ben Gotow 2020-04-22 19:13:39 -05:00
parent e94bb7598a
commit c394dc808f
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/src/components/composer-editor/conversion.tsx
View file

@ -187,7 +187,7 @@ const TEXT_RULE_IMPROVED: Rule = {
if (obj.object === 'string') {
return children.split('\n').reduce((array, text, i) => {
if (i !== 0) array.push(<br />);
// BEGIN CHANGE
// BEGIN CHANGES
// Replace "a b c" with "a&nbsp;&nbsp; b c" (to match Gmail's behavior exactly.)
// In a long run of spaces, all but the last space are converted to &nbsp;.
@ -200,7 +200,20 @@ const TEXT_RULE_IMPROVED: Rule = {
// considered HTML whitespace.
text = text.replace(/^ /, '\u00A0');
// END CHANGE
// \r handling: CRLF delimited text pasted into the editor (on Windows) is not processed
// properly by Slate. It splits on \n leaving the preceding \r lying around. When the
// serializer encounters text nodes containing just a `\r`, it doesn't flip them to
// <br/> tags because they're not empty, but the character is HTML whitespace and
// renders with zero height causing blank newlines to disappear.
// If the only character is a \r, replace it with an nbsp.
if (text === '\r') text = '\u00A0';
// If the text contains a trailing \r, remove it. This stray char shouldn't matter but
// also shouldn't be in the HTML string.
text = text.replace(/\r$/, '');
// END CHANGES
array.push(text);
return array;
}, []);