From c5a77fa8541c87e09e4876bde11152935d087248 Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Tue, 26 Apr 2016 17:01:15 -0700 Subject: [PATCH] fix(autolinker): Use `getAttribute('href')` because `href` is magic --- internal_packages/message-list/lib/autolinker.es6 | 2 +- .../message-list/spec/autolinker-fixtures/linkedin-out.html | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal_packages/message-list/lib/autolinker.es6 b/internal_packages/message-list/lib/autolinker.es6 index d327823a9..0c1284927 100644 --- a/internal_packages/message-list/lib/autolinker.es6 +++ b/internal_packages/message-list/lib/autolinker.es6 @@ -62,6 +62,6 @@ export function autolink(doc, {async} = {}) { , }); while (aTagWalker.nextNode()) { - aTagWalker.currentNode.title = aTagWalker.currentNode.href; + aTagWalker.currentNode.title = aTagWalker.currentNode.getAttribute('href'); } } diff --git a/internal_packages/message-list/spec/autolinker-fixtures/linkedin-out.html b/internal_packages/message-list/spec/autolinker-fixtures/linkedin-out.html index 12c8c47f0..6befa37d9 100644 --- a/internal_packages/message-list/spec/autolinker-fixtures/linkedin-out.html +++ b/internal_packages/message-list/spec/autolinker-fixtures/linkedin-out.html @@ -177,7 +177,7 @@ with Larry Wilmore" - + Why I Haven’t Worked in 30 Years @@ -224,7 +224,7 @@ Why I Haven’t Worked in 30 Years - +
Highlight of the dayHighlight of the day