Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-02-25 08:35:16 +08:00
Code Issues Projects Releases Packages Wiki Activity

Fix issue with MessageBodyProcessor removing but not reprocessing

Browse source
This commit is contained in:
Ben Gotow 2017-09-25 12:20:52 -07:00
parent 9347ef25f7
commit c9da0cd76f
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
app/src/flux/stores/message-body-processor.es6
View file

@ -38,20 +38,10 @@ class MessageBodyProcessor {
} }
updateCacheForMessage = async (changedMessage) => { updateCacheForMessage = async (changedMessage) => {
const changedKey = this._key(changedMessage);
// grab the old cached value if there is one
const oldCacheRecord = this._recentlyProcessedD[changedKey];
// remove the message from the cache so retrieve() will reprocess
delete this._recentlyProcessedD[changedKey];
this._recentlyProcessedA = this._recentlyProcessedA.filter(({key}) =>
key !== changedKey
);
// reprocess any subscription using the new message data. Note that // reprocess any subscription using the new message data. Note that
// changedMessage may not have a loaded body if it wasn't changed. In // changedMessage may not have a loaded body if it wasn't changed. In
// that case, we use the previous body. // that case, we use the previous body. Note: metadata changes, etc.
// can cause the body to change, even if the HTML is identical!
const subscriptions = this._subscriptions.filter(({message}) => const subscriptions = this._subscriptions.filter(({message}) =>
message.id === changedMessage.id message.id === changedMessage.id
); );
@ -62,6 +52,19 @@ class MessageBodyProcessor {
return; return;
} }
const changedKey = this._key(changedMessage);
// grab the old cached value if there is one
const oldCacheRecord = this._recentlyProcessedD[changedKey];
// remove the message from the cache so retrieve() will reprocess
// and insert it into the cache again
delete this._recentlyProcessedD[changedKey];
this._recentlyProcessedA = this._recentlyProcessedA.filter(({key}) =>
key !== changedKey
);
// run the processor
const output = await this.retrieve(updatedMessage); const output = await this.retrieve(updatedMessage);
// only trigger if the body has really changed // only trigger if the body has really changed