Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-01-06 08:08:10 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(emoji): Improve variable names / diff feedback

Browse source
This commit is contained in:
Ben Gotow 2016-04-12 14:46:03 -07:00
parent 21a6aff99d
commit d159e1037d
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
internal_packages/composer-emoji/lib/emoji-button-popover.jsx
View file

@ -261,10 +261,10 @@ class EmojiButtonPopover extends React.Component {
position.x = 18; position.x = 18;
position.y += 48; position.y += 48;
const emoji = this.state.categorizedEmoji[category]; const emojiNames = this.state.categorizedEmoji[category];
if (!emoji || emoji.length === 0) return; if (!emojiNames || emojiNames.length === 0) return;
const remaining = emoji.map((emojiName, j) => { const emojiToDraw = emojiNames.map((emojiName, j) => {
const x = position.x; const x = position.x;
const y = position.y; const y = position.y;
const src = EmojiStore.getImagePath(emojiName); const src = EmojiStore.getImagePath(emojiName);
@ -286,16 +286,16 @@ class EmojiButtonPopover extends React.Component {
this._emojiPreloadImage.onload = () => { this._emojiPreloadImage.onload = () => {
this._emojiPreloadImage.onload = null; this._emojiPreloadImage.onload = null;
ctx.drawImage(this._emojiPreloadImage, x, y - 30, 32, 32); ctx.drawImage(this._emojiPreloadImage, x, y - 30, 32, 32);
if (remaining.length === 0) { if (emojiToDraw.length === 0) {
callback(); callback();
} else { } else {
drawEmojiAt(remaining.shift()); drawEmojiAt(emojiToDraw.shift());
} }
} }
this._emojiPreloadImage.src = src; this._emojiPreloadImage.src = src;
} }
drawEmojiAt(remaining.shift()); drawEmojiAt(emojiToDraw.shift());
} }
render() { render() {