Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-01-13 11:38:31 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(prefs): Only scroll to top when switching tabs

Browse source
This commit is contained in:
Ben Gotow 2016-11-04 11:26:29 -07:00
parent 596777a427
commit d214a52192
2 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal_packages/preferences/lib/preferences-root.jsx
View file

@ -28,10 +28,12 @@ class PreferencesRoot extends React.Component {
this._focusContent(); this._focusContent();
} }
componentDidUpdate() { componentDidUpdate(oldProps) {
const scrollRegion = document.querySelector(".preferences-content .scroll-region-content"); if (oldProps.tab !== this.props.tab) {
scrollRegion.scrollTop = 0; const scrollRegion = document.querySelector(".preferences-content .scroll-region-content");
this._focusContent(); scrollRegion.scrollTop = 0;
this._focusContent();
}
} }
_localHandlers() { _localHandlers() {

4
internal_packages/preferences/lib/tabs/preferences-accounts.jsx
View file

@ -19,7 +19,9 @@ class PreferencesAccounts extends React.Component {
} }
componentWillUnmount() { componentWillUnmount() {
this.unsubscribe(); if (this.unsubscribe) {
this.unsubscribe();
}
} }
getStateFromStores({selected} = {}) { getStateFromStores({selected} = {}) {