Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-21 07:46:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Completely remove sanitized tags with non-text contents

Browse source
This commit is contained in:
Ben Gotow 2017-11-28 09:23:57 +00:00
parent 3c336c9f88
commit d2fc8172af
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/src/services/sanitize-transformer.es6
View file

@ -42,6 +42,8 @@ const AttributesContainingLinks = [
'classid',
];
const NodesWithNonTextContent = asMap(['script', 'style', 'iframe', 'object', 'meta']);
const Preset = {
PasteFragment: {
fragment: true,
@ -443,7 +445,14 @@ class SanitizeTransformer {
}
if (!settings.allowedTags.hasOwnProperty(nodeName)) {
// this node isn't allowed, replace it with a `span` with the same children.
// this node isn't allowed - what should we do with it?
// Nodes with non-text contents: completely remove them
if (NodesWithNonTextContent.hasOwnProperty(nodeName)) {
return false;
}
// Nodes with text contents / no contents: replace with a `span` with the same children.
// This allows us to ignore things like tables / table cells and still get their contents.
let replacementNode = document.createElement('span');
for (const child of Array.from(node.childNodes)) {