From d8beb4a0cf2ca21687c7aa164de79fc162fad85d Mon Sep 17 00:00:00 2001 From: Ben Gotow Date: Wed, 11 Nov 2015 10:20:48 -0800 Subject: [PATCH] undo(prefs): `atom.keymaps` does not implement unsubscribe --- .../preferences/lib/tabs/preferences-keymaps.cjsx | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx b/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx index c6258fb01..b94d98c31 100644 --- a/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx +++ b/internal_packages/preferences/lib/tabs/preferences-keymaps.cjsx @@ -25,14 +25,11 @@ class PreferencesKeymaps extends React.Component @_loadTemplates() componentDidMount: => - @_mounted = true - atom.keymaps.onDidReloadKeymap => - # Temporary fix for https://github.com/atom/atom-keymap/issues/101 - return unless @_mounted + @_disposable = atom.keymaps.onDidReloadKeymap => @setState(bindings: @_getStateFromKeymaps()) componentWillUnmount: => - @_mounted = false + @_disposable.dispose() _loadTemplates: => templatesDir = path.join(atom.getLoadSettings().resourcePath, 'keymaps', 'templates')