Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-11-11 10:12:00 +08:00
Code Issues Projects Releases Packages Wiki Activity

fix(auth) Dont allow invalid form submission with Enter key

Browse source
This commit is contained in:
Juan Tejada 2017-01-24 17:43:10 -08:00
parent d3a0d60f0d
commit d8c8dd809c
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal_packages/onboarding/lib/decorators/create-page-for-form.jsx
View file

@ -55,6 +55,11 @@ const CreatePageForForm = (FormComponent) => {
inputs[0].focus();
}
_isValid() {
const {populated, errorFieldNames} = this.state
return errorFieldNames.length === 0 && populated
}
onFieldChange = (event) => {
const changes = {};
if (event.target.type === 'checkbox') {
@ -75,6 +80,7 @@ const CreatePageForForm = (FormComponent) => {
}
onFieldKeyPress = (event) => {
if (!this._isValid()) { return }
if (['Enter', 'Return'].includes(event.key)) {
this.onSubmit();
}
@ -130,7 +136,7 @@ const CreatePageForForm = (FormComponent) => {
}
_renderButton() {
const {accountInfo, submitting, errorFieldNames, populated} = this.state;
const {accountInfo, submitting} = this.state;
const buttonLabel = FormComponent.submitLabel(accountInfo);
// We're not on the last page.
@ -143,7 +149,7 @@ const CreatePageForForm = (FormComponent) => {
);
}
if (errorFieldNames.length || !populated) {
if (!this._isValid()) {
return (
<button className="btn btn-large btn-gradient btn-disabled btn-add-account">{buttonLabel}</button>
);