From dffb87bd4af7ed9ae02a58c4c6dd94e096ae8534 Mon Sep 17 00:00:00 2001 From: Evan Morikawa Date: Fri, 15 Jul 2016 13:15:26 -0700 Subject: [PATCH] Report errors earlier --- packages/nylas-sync/sync-worker.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/nylas-sync/sync-worker.js b/packages/nylas-sync/sync-worker.js index 35d71597c..e5fbdc0ff 100644 --- a/packages/nylas-sync/sync-worker.js +++ b/packages/nylas-sync/sync-worker.js @@ -202,10 +202,6 @@ class SyncWorker { onSyncError(error) { this.closeConnection() - // Continue to retry if it was a network error - if (error instanceof Errors.RetryableError) { - return Promise.resolve() - } this._logger.error(error, `SyncWorker: Error while syncing account`) global.Metrics.reportMetric({ @@ -213,6 +209,12 @@ class SyncWorker { value: 1, type: global.Metrics.Counter, }) + + // Continue to retry if it was a network error + if (error instanceof Errors.RetryableError) { + return Promise.resolve() + } + this._account.syncError = jsonError(error) return this._account.save() }