fix(important): Fix bugs in "important" label categorization

internal_packages/thread-list/lib/thread-list-columns.cjsx

@@ -65,10 +65,9 @@ c3 = new ListTabular.Column
       attachment = <div className="thread-icon thread-icon-attachment"></div>
 
     currentCategories = FocusedPerspectiveStore.current().categories() ? []
-    account = FocusedPerspectiveStore.current().account
 
-    ignoredIds = _.pluck(currentCategories, 'id')
-    ignoredIds.push(cat.id) for cat in CategoryStore.hiddenCategories(account)
+    ignored = [].concat(currentCategories, CategoryStore.hiddenCategories(thread.accountId))
+    ignoredIds = _.pluck(ignored, 'id')
 
     for label in (thread.sortedCategories())
       continue if label.id in ignoredIds

src/flux/stores/category-store.coffee

@@ -6,8 +6,13 @@ Account = require '../models/account'
 {Categories} = require 'nylas-observables'
 Rx = require 'rx-lite'
 
-asAccount = (a) -> if a instanceof Account then a else AccountStore.accountForId(a)
-asAccountId = (a) -> if a instanceof Account then a.id else a
+asAccount = (a) ->
+  throw new Error("You must pass an Account or Account Id") unless a
+  if a instanceof Account then a else AccountStore.accountForId(a)
+
+asAccountId = (a) ->
+  throw new Error("You must pass an Account or Account Id") unless a
+  if a instanceof Account then a.id else a
 
 class CategoryStore extends NylasStore
 
@@ -17,7 +22,11 @@ class CategoryStore extends NylasStore
     @_userCategories = {}
     @_hiddenCategories = {}
 
-    @_disposable = Categories
+    NylasEnv.config.observe 'core.workspace.showImportant', =>
+      return unless @_categoryResult
+      @_onCategoriesChanged(@_categoryResult)
+
+    Categories
       .forAllAccounts()
       .sort()
       .subscribe(@_onCategoriesChanged)
@@ -95,6 +104,7 @@ class CategoryStore extends NylasStore
     @getStandardCategory(accountOrId, "trash")
 
   _onCategoriesChanged: (categories) =>
+    @_categoryResult = categories
     @_categoryCache = {}
     for cat in categories
       @_categoryCache[cat.accountId] ?= {}

src/flux/stores/workspace-store.coffee

@@ -55,11 +55,12 @@ class WorkspaceStore extends NylasStore
     'navigation:go-to-label'   : => ## TODO
 
   _setMailViewByName: (categoryName) ->
-    account = FocusedPerspectiveStore.current().account
-    category = CategoryStore.getStandardCategory(account, categoryName)
-    return unless category
-    view = MailboxPerspective.forCategory(category)
-    return unless view
+    accountIds = FocusedPerspectiveStore.current().accountIds
+    categories = accountIds.map (aid) -> CategoryStore.getStandardCategory(aid, categoryName)
+    categories = _.compact(categories)
+
+    if categories.length > 0
+      view = MailboxPerspective.forCategories(categories)
       Actions.focusMailboxPerspective(view)
 
   _selectDraftsSheet: ->