From e6afea45a0d9f5131d2009837049aca222bd06f6 Mon Sep 17 00:00:00 2001 From: Juan Tejada Date: Thu, 9 Feb 2017 01:34:58 -0800 Subject: [PATCH] [local-sync] Prefer promises over `success` option for api requests Summary: Companion D3869 Test Plan: manual Reviewers: halla, spang, evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D3868 --- .../src/local-sync-worker/sync-metrics-reporter.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/local-sync/src/local-sync-worker/sync-metrics-reporter.js b/packages/local-sync/src/local-sync-worker/sync-metrics-reporter.js index dfd3ed813..7de192350 100644 --- a/packages/local-sync/src/local-sync-worker/sync-metrics-reporter.js +++ b/packages/local-sync/src/local-sync-worker/sync-metrics-reporter.js @@ -38,16 +38,16 @@ class SyncMetricsReporter { path: `/ingest-metrics`, method: 'POST', body: info, - error: () => { - logger.warn("Metrics Collector: Submission Failed.", info); - }, accountId: AccountStore.accountForEmail(info.emailAddress).id, - success: () => { - logger.log(info, "Metrics Collector: Submitted.", info); - }, }, }); - req.run(); + req.run() + .then(() => { + logger.log(info, "Metrics Collector: Submitted.", info); + }) + .catch(() => { + logger.warn("Metrics Collector: Submission Failed.", info); + }) } }