From e798e50d1aa649652ac88f045393936ae68698c3 Mon Sep 17 00:00:00 2001 From: Christine Spang Date: Sat, 11 Mar 2017 13:44:13 -0800 Subject: [PATCH] [iso-core] Upgrade nodemailer Summary: We were using a version that was ~9 months old and a lot of development has happened since. v3 is not compatible w/v2, but it looks like we aren't using any of the features that had breaking changes: http://nodemailer.com/about/migrate/ I chose not to switch to the new built-in OAuth2 token refresh support because we already have a mechanism for refreshing oauth tokens and adding a different implementation specifically for SMTP would introduce more opportunities for bugs. Since mailcomposer is no longer a dependency of nodemailer, I added this dependency as well. Test Plan: manual - sent a message, sent a message w/an attachment Reviewers: evan, khamidou, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D4201 --- packages/isomorphic-core/package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/isomorphic-core/package.json b/packages/isomorphic-core/package.json index e6eb773dc..e82ad0192 100644 --- a/packages/isomorphic-core/package.json +++ b/packages/isomorphic-core/package.json @@ -14,7 +14,8 @@ "jasmine": "2.x.x", "joi": "8.4.2", "libhoney": "1.0.0-beta.2", - "nodemailer": "2.5.0", + "nodemailer": "3.1.5", + "mailcomposer": "4.0.1", "promise-props": "1.0.0", "promise.prototype.finally": "1.0.1", "rx-lite": "4.0.8",