Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-22 08:16:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

[client-app] Handle errors when opening imap box correctly

Browse source 
Summary:
If an error is thrown while opening an imap box, we need to make sure to
set the `_isOpening` back to false

Test Plan: manual

Reviewers: mark

Reviewed By: mark

Differential Revision: https://phab.nylas.com/D4134
This commit is contained in:
Juan Tejada 2017-03-08 09:48:04 -08:00
parent bec943e1e3
commit ef4778d12a
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
packages/isomorphic-core/src/imap-connection.es6
View file

@ -289,13 +289,17 @@ class IMAPConnection extends EventEmitter {
return Promise.resolve(new IMAPBox(this, this._imap._box));
}
return this._withPreparedConnection(async (imap) => {
this._isOpeningBox = true
this._lastOpenDuration = null;
const before = Date.now();
const box = await imap.openBoxAsync(folderName, readOnly)
this._lastOpenDuration = Date.now() - before;
this._isOpeningBox = false
return new IMAPBox(this, box)
try {
this._isOpeningBox = true
this._lastOpenDuration = null;
const before = Date.now();
const box = await imap.openBoxAsync(folderName, readOnly)
this._lastOpenDuration = Date.now() - before;
this._isOpeningBox = false
return new IMAPBox(this, box)
} finally {
this._isOpeningBox = false
}
})
}