Linux returns ['asked', 'acidify', 'Assad'] for the string "asdfk"
which seems normal to me. Why do OS X and/or Windows return [] for
that string? That seems weird, so I just broke the spec to run different
specs on different platforms.
The "it provides options for misspelled words" still fails with
"asdfk" supposed to supply no corrections, which I find unlikely in
the real world, and Hunspell provides corrections.
The Linux component of Atom's spellchecker depends on Hunspell for
corrections. It requires a dictionary to be set, unlike Mac OS X
and Windows that have spellcheckers built in to the OS, and they
have the dictionaries built-in as well. This commit uses Atom's
spellchecker default dictionary method (which I wish was a public
API) to reset the dictionary to its default setting. It also ignores
the dictionaries available command for the Linux platform, which
seems to always return an empty Array.
type is composer
- AccountStore was listening to changes to account object (config file)
when it was a window different from the main window in order to update
the alias list on composer windows.
- This caused the onboarding window to also listen for changes and
caused it to incorrectly add an account twice
Summary:
Adds the new Account preferences page. This consists of two major React components,
PreferencesAccountList and PreferencesAccountDetails, both of which use EditableList.
I added a bunch of fixes and updated the API for EditableList, plus a bit of
refactoring for PreferencesAccount component, and a bunch of CSS so its a big diff.
The detailed changelog:
Updates to EditableList:
- Fix bug updating selection state when arrows pressed to move selection
- Add new props:
- allowEmptySelection to allow the list to have no selection
- createInputProps to pass aditional props to the createInput
- Add scroll region for list items
- Update styles and refactor render methods
Other Updates:
- Updates Account model to hold aliases and a label
- Adds getter for label to default to email
- Update accountswitcher to display label, update styles and spec
- Refactor PreferencesAccounts component:
- Splits it into smaller components,
- Removes unused code
- Splits preferences styelsheets into smaller separate stylesheet for
account page. Adds some updates and fixes (scroll-region padding)
- Update AccountStore to be able to perform updates on an account.
- Adds new Action to update account, and an action to remove account to
be consistent with Action usage
- Adds components for Account list and Aliases list using EditableList
Test Plan: - All specs pass, but need to write new tests!
Reviewers: bengotow, evan
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D2332
Travis provides a wonderful helper addon documented at
https://docs.travis-ci.com/user/ssh-known-hosts/.
The behavior changed moves the ssh-keyscan from the before_install
stage to the addons stage.
Found the order at https://docs.travis-ci.com/user/customizing-the-build/.
In nylas/N1@d95cb45147 the entire build script
was merged from Evan Morikawa, which reordered the whole Travis build script.
athis commit reorders the to have the Travis build environment config at the
beginning of the script and the build process at the end and the Travis
secure variables at the end of the script.
Summary:
- You can now pass `--config-dir-path=/some/custom/path` to `./N1.sh`
- `main.coffee` cleaned up a bit. A lot of unused params from legacy Atom
stuff were still being used
- Integration specs now set the config dir before booting.
- New spec to check for the autoupdater in the app and make sure it's
pointing at the right place.
Test Plan: script/grunt run-integration-tests
Reviewers: juan, bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D2331
Summary:
Fixes a number of smaller UI issues. Fixes T6173, T6207
Full list of changes:
- Ensure time slots / days display in order
- Allow time blocks of any size to be set on half hour intervals
- Don't reset calendar when changing event length
- Expand calendar on window resize
- Change window title from "Electron"
- Add delete button to cancel individual calendar events
- Move event details box to the left side
- Prevent addition of duplicate time slots
Test Plan: manual
Reviewers: bengotow
Reviewed By: bengotow
Maniphest Tasks: T6173, T6207
Differential Revision: https://phab.nylas.com/D2333
Clicking participant fields to type in them did not cause state.focusedField to change, because no onFocus events were bound to the ParticipantTextFields. Since setState was not called, the focus would appear to change but revert as soon as you touched state.
This diff also renames `onChangeEnabledFields` to `onAdjustEnabledFields` making it more clear that unlike the other handlers, it does not take a new value, it takes a set of changes. I also noticed that we /always/ focus fields when showing them, so I removed the separate focus param from it and made it adjust focus at the composer-view level only.
I also consolidated everywhere that touches `state.focusedField` so that we can keep the `_lastFocusedParticipantField` value in sync with it more easily.
The issue stems that Mac OS X uses a case-insensitive filesystem by
default, while most Linux filesystems are case-sensitive. The classNames
package will require successfully on Mac OS X during Travis tests, but
since the spec test suite isn't normally run under Linux this bug is
more unlikely to appear.
