Commit graph

173 commits

Author SHA1 Message Date
Evan Morikawa
0c2bcd3fba fix(toolbar): slash focuses search & hidden buttons don't act
Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1289
2015-03-12 21:47:01 -04:00
Ben Gotow
974f216dcf fix(default-client): Missing return statement 2015-03-12 18:23:37 -07:00
Ben Gotow
cb59a497d8 fix(react-warnings): Add keys, displayName to React components 2015-03-12 17:55:26 -07:00
Ben Gotow
4d6566327f fix(participants): Remove all sorts of broken cruft, remove "Me" 2015-03-12 17:36:27 -07:00
Evan Morikawa
453e449955 fix(tooltip): don't show tooltips for hidden items 2015-03-12 18:33:49 -04:00
Evan Morikawa
3dbbc6b474 fix(tooltip): hides tooltip if state change underneath you 2015-03-12 18:11:47 -04:00
Evan Morikawa
033008e036 feat(tooltip): add informational tooltip component
Summary: Add tooltip. To use just add a data-tooltip="plain string"

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1288
2015-03-12 18:09:10 -04:00
Ben Gotow
34facc920f fix(sheets): Move toolbar, re-introduce :Top region, refactor sheet layout
Summary:
Debounce Component Registry trigger to make app launch much more efficient

Allow arbitrary additional attributes to be set on flexbox, resizable-region

Updates to notification styling

Sheet store maintains an array of sheet types3 instead of sheet elements

Search bar and composer new should be globally visible

Toolbar is now in sheet container instead of individual sheet columns

The sheet container monitors sheet column width and manually positions toolbars

Test Plan: No new tests yet - will see if this design sticks first.

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1287
2015-03-12 15:07:38 -07:00
Evan Morikawa
6a03c6a034 feat(composer): blocks multiple sending & lots of tests
Summary: fix in composer sending

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1286
2015-03-12 17:48:56 -04:00
Ben Gotow
5e1b6caa9e fix(onboarding): Drag area was over (X) 2015-03-11 14:31:44 -07:00
Ben Gotow
9aeeb431cb fix(drafts): Don't display raw HTML tags in draft previews 2015-03-11 14:20:17 -07:00
Evan Morikawa
8b2797d3b0 feat(notifications): move to sidebar
Summary: feat(notifications): move to sidebar

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1282
2015-03-11 13:17:11 -07:00
Ben Gotow
3d52458e56 refactor(quoted-text): Give withoutQuotedText its own specs 2015-03-11 12:09:29 -07:00
Evan Morikawa
bd2cdd876b feat(composer): focus on to field for forwarded message 2015-03-10 18:44:33 -07:00
Evan Morikawa
984b8fb303 feat(composer): shows subject if forwarded message 2015-03-10 18:27:10 -07:00
Evan Morikawa
0fb7e2c101 feat(composer): add popout icon and header styles 2015-03-10 18:14:53 -07:00
Ben Gotow
0c97de1bff feat(onboarding): Make onboarding window taller, stopgap 2015-03-10 18:07:48 -07:00
Evan Morikawa
7d10a3a00d feat(menus): remove unused menu items 2015-03-10 17:52:30 -07:00
Evan Morikawa
72f1035324 fix(notifications): only show notification for new messages 2015-03-10 16:08:07 -07:00
Evan Morikawa
77d9526ecd fix(email): iframe bug and search refreshing if not committed 2015-03-10 15:40:46 -07:00
Evan Morikawa
501704359e fix(participants): bcc field displays properly
Can also select text by clicking on the participant
2015-03-10 15:12:13 -07:00
Evan Morikawa
961680ef34 feat(sending): close immediately and reopen if error
Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1276
2015-03-10 14:32:35 -07:00
Ben Gotow
6607e3abdc fix(quoted-text): Better handling for "Wildcard filters" email 2015-03-10 13:56:08 -07:00
Evan Morikawa
ae73880b2b feat(messages): add bcc label to message headers 2015-03-10 13:27:21 -07:00
Evan Morikawa
d5eb68ece1 fix(scrolling): scroll to end once. Fix draft deletion 2015-03-10 13:17:47 -07:00
Ben Gotow
6af864e3bd fix(*): remove unnecessary code from last commit 2015-03-10 12:11:55 -07:00
Ben Gotow
46a6e229eb fix(fields): paste multiple emails at a time, even with garbage 2015-03-10 12:06:52 -07:00
Evan Morikawa
697acd3f0b feat(color): fix color visisted state 2015-03-10 11:30:16 -07:00
Evan Morikawa
fd43c7002d feat(colors): new colors for selection states
Summary: adjust colors

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1273
2015-03-10 11:29:14 -07:00
Ben Gotow
c4c6f7c65a fix(dnd): You can now drag and drop attachments onto drafts 2015-03-10 11:23:31 -07:00
Ben Gotow
df2c64f4dd fix(specs): Thread needs to be defined for MessageItem 2015-03-10 11:05:30 -07:00
Ben Gotow
16cd75a933 feat(activity-bar): Hidden until you show developer tools 2015-03-10 10:36:50 -07:00
Evan Morikawa
9536feb339 fix(message): dont scroll down if only 1 item 2015-03-10 10:33:16 -07:00
Evan Morikawa
282cc40e9a feat(message): change long format timestamp
Summary: Minor UI fixes

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1271
2015-03-10 10:08:04 -07:00
Evan Morikawa
6ec84561c4 feat(composer): popout only closes when message sending succeeds
Summary:
This is a WIP to fix the blatant case of messages dissapearing when
there's an error. It's pending a better through through notification UI

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1270
2015-03-10 09:52:47 -07:00
Ben Gotow
ef7ff27c56 fix(unread): Don't show bogus numbers in thread list 2015-03-09 18:32:01 -07:00
Ben Gotow
343e592569 feat(draft-list) Refactor thread-list, create draft-list
Summary: Adds the draft list using a refactored list-tabular class. Also fixes several draft bugs that appeared after allowing editing.

Test Plan: Run tests (need to test new ListTabular component ASAP)

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1272
2015-03-09 18:25:53 -07:00
Evan Morikawa
b479e099c1 feat(messages): expandable message headers
Summary: feat(messages): expandable message headers

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1267
2015-03-09 11:17:22 -07:00
Ben Gotow
09dc8887b7 fix(logout): atom-workspace not focused breaking logout 2015-03-09 10:06:50 -07:00
Ben Gotow
27aa11aa60 fix(env): Always use staging for now 2015-03-06 16:55:34 -08:00
Ben Gotow
86c41ca272 fix(compose): Temporarily disable composer full height feature 2015-03-06 16:10:21 -08:00
Ben Gotow
82089f8dbe fix(less): Minor style changes 2015-03-06 16:08:34 -08:00
Ben Gotow
8788962809 fix(buttons): Fix toolbar button sizes to be consistent 2015-03-06 12:31:39 -08:00
Ben Gotow
54e651da0e fix(attachments): Don't show attachments with no name (that are alternative body formats) 2015-03-06 12:28:04 -08:00
Ben Gotow
0991cf693a fix(message-list): Clean up unused wrappers and styles 2015-03-06 12:12:01 -08:00
Ben Gotow
d55aad9ce9 refactor(toolbar): Toolbar items for messages are back! 2015-03-06 12:03:32 -08:00
Ben Gotow
9e447ad501 refactor(toolbar): Better base for building toolbars 2015-03-06 11:05:25 -08:00
Ben Gotow
35ac15da3a fix(activity-bar): Use more aggressive smoothing for courier 2015-03-05 21:16:10 -08:00
Evan Morikawa
7e7f8e5eda Merge branch 'feat-refactor-layout' of github.com:inboxapp/edgehill into feat-refactor-layout
Conflicts:
	src/flux/models/utils.coffee
2015-03-05 19:57:50 -08:00
Ben Gotow
3802e4899b fix(search-bar): A few minor tweaks to search 2015-03-05 19:22:58 -08:00
Ben Gotow
c21f992ed2 fix(activity-bar): Fix activity bar resizing 2015-03-05 19:22:43 -08:00
Ben Gotow
567acfb14b fix(*) minor patches and fixes for specs / ui 2015-03-05 19:09:42 -08:00
Ben Gotow
e5975b2acc fix(packages): Update other packages to new UI 2015-03-05 17:56:45 -08:00
Evan Morikawa
e49a5e0adc allow removal of cc and bcc fields 2015-03-05 16:38:28 -08:00
Ben Gotow
9e7a180f06 fix(app): Don't actually need application: handlers 2015-03-05 16:31:24 -08:00
Evan Morikawa
8823050eb4 more contenteditable component tests 2015-03-05 16:15:29 -08:00
Evan Morikawa
c443eb3331 remove fdescribe 2015-03-05 16:02:47 -08:00
Evan Morikawa
73f4c97910 tests for contenteditable component 2015-03-05 16:00:56 -08:00
Evan Morikawa
a0cbe8606a fix tests 2015-03-05 15:19:05 -08:00
Evan Morikawa
db4cc4ef08 adjust min width of account sidebar to prevent text overflow 2015-03-05 14:09:36 -08:00
Evan Morikawa
4635bf7d14 test fixes 2015-03-05 13:56:55 -08:00
Evan Morikawa
b3271432ef inline composer optimistic expansion 2015-03-05 13:53:18 -08:00
Evan Morikawa
d1b3b83e38 remove single space hack 2015-03-05 13:33:50 -08:00
Evan Morikawa
4af00cfaf4 more composer styles 2015-03-05 13:31:11 -08:00
Ben Gotow
d8dbe90c97 fix(windows): Windows build changes 2015-03-05 13:19:24 -08:00
Ben Gotow
6ca63fc01c Merge branch 'feat-refactor-layout' of github.com:inboxapp/edgehill into feat-refactor-layout
Conflicts:
	static/components/tokenizing-text-field.less
2015-03-05 10:59:00 -08:00
Ben Gotow
cce9eba509 Rename inbox.env to env, because it's not for inbox alone 2015-03-05 10:58:16 -08:00
Evan Morikawa
e7f3e77fde composer fixes 2015-03-04 19:06:39 -08:00
Evan Morikawa
05c6fc9ecf more composer styling 2015-03-04 18:47:48 -08:00
Ben Gotow
a5508e46bc New login flow with mobile user agent set 2015-03-04 18:12:50 -08:00
Evan Morikawa
ecccf72cd8 composer footer full-width 2015-03-04 15:52:40 -08:00
Ben Gotow
2c1975472b New onboarding 2015-03-04 15:19:51 -08:00
Evan Morikawa
689ca426de styling autocomplete 2015-03-04 14:26:53 -08:00
Evan Morikawa
14a6fa2ab1 participant chip improvements 2015-03-04 12:30:54 -08:00
Evan Morikawa
e1535e6a3d antialias text 2015-03-04 10:37:57 -08:00
Evan Morikawa
8f89954fd9 message list styling 2015-03-04 09:49:09 -08:00
Evan Morikawa
e7a1f22046 message list styles 2015-03-03 18:51:56 -08:00
Evan Morikawa
b61e62c6a3 button and less changes 2015-03-03 18:09:57 -08:00
Evan Morikawa
b63aad83f1 more UI variable improvements 2015-03-03 12:24:48 -08:00
Evan Morikawa
0f56d1fcab refactoring ui variables for colors 2015-03-03 12:00:04 -08:00
Ben Gotow
07efd7d432 LESS Tweaks 2015-03-03 09:49:15 -08:00
Ben Gotow
2b19544219 Restoring SearchBar, adding FontAwesome for icons not designed yet 2015-03-03 09:49:15 -08:00
Ben Gotow
cabae1db50 New RetinaImg component, images in sidebar 2015-03-03 09:49:15 -08:00
Ben Gotow
95b8b2df15 Fix for stray class= 2015-03-03 09:49:15 -08:00
Ben Gotow
985aaf285c Make ResizableRegion a core component, not registered with component registry 2015-03-03 09:49:15 -08:00
Ben Gotow
d6336dae08 Squashed commit of deeply broken branch
commit d1c455515e04424d429c87a07aff248a4a767f23
Merge: 72e5536 512f8db
Author: Ben Gotow <bengotow@gmail.com>
Date:   Thu Feb 19 18:42:29 2015 -0800

    Merge sheet and flexbox components, fonts, and more

    Conflicts:
    	static/workspace-view.less

commit 72e553652f5b26a96155c51e04db46baafb916be
Author: Ben Gotow <bengotow@gmail.com>
Date:   Wed Feb 18 12:33:08 2015 -0800

    Start transitioning to a better set of ui-variables (from bootstrap)

commit ed22fb7fe1c6544af44fae69b83e7e63965ddf4d
Author: Ben Gotow <bengotow@gmail.com>
Date:   Wed Feb 18 11:55:58 2015 -0800

    I hate CSS

commit 512f8db414ceef74712c9d63ba5a67b44cf778c4
Author: Ben Gotow <bengotow@gmail.com>
Date:   Mon Feb 16 10:10:44 2015 -0800

    Initial work on top toolbar

commit c2d7a0e0a2f6f6ebe254cca24ad0735336d57b70
Author: Ben Gotow <bengotow@gmail.com>
Date:   Thu Feb 12 18:47:26 2015 -0800

    New UI Prototype interaction / stores for sheets
2015-03-03 09:49:15 -08:00
Evan Morikawa
cf839fad9c fix(composer): normalize html before getting selection 2015-03-02 19:44:17 -08:00
Evan Morikawa
e7868df1ad feat(contenteditable): a React compatible contenteditable
Summary:
toolbar popup displays

restore caret protection on contenteditable

BAD - can't use cursor saving and restoring with react :(

_findNode works

saves and restores cursor state

contenteditable fixes to support cursor

comments on cursor

initial undo manager

extract undo manager and move up in stack

make undo manager a mixin

adding selection snapshots in composer

fixes in undo manager

selection saves selection states properly

move UndoManager and fix draft

selection state can now select backwards

selection works backwards and click not overridden

change bold class to allow for bolding and unbolding

styling of hover component

can set links in composer

bold and italic clicking works. text seleciton works

show link modal on hover

selection fixes

Test Plan: TODO

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1249
2015-03-02 15:33:58 -08:00
Ben Gotow
e1fc34a562 fix(drafts): Draft syncing completely disabled to reduce code complexity
Summary:
fix(streaming): Reconnect every 30 seconds, always

Never accept drafts via any API source

fix(attachments): Fix for changes to open API

Get rid of shouldAbort, just let tasks decide what to do in cleanup

Never let SaveDraftTask run while another SaveDraftTask for same draft is running

Never used IPC

Ignore destroy draft 404

Moving draft store proxy to draft store level

Only block on older saves

Replace SaveDraftTask with SyncbackDraftTask, do saving directly from proxy

Never sync back ;-)

Fix specs

Alter SendDraftTask so that it can send an unsaved draft

Test Plan: Run tests

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1245
2015-03-02 11:23:35 -08:00
Ben Gotow
71e216ddff fix(messages): Timestamp display issue after merge 2015-02-24 16:24:01 -08:00
Ben Gotow
2a93c70214 fix(quoted-text): Show quoted text for short forwarded msgs
Summary: tiny patch, but with lots of tests for message-item and factored out message-timestamp

Test Plan: Run brand new specs!

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1225
2015-02-24 16:20:57 -08:00
Ben Gotow
0468cb4b39 feat(drafts) Reply to draft and minor fixes
Summary:
Initial hooks for reply to message

Per-message actions and reply to message!

Always commit changes before openinig popout composer

Flip message display - newest at bottom like Gmail

WIP specs

New activity bar inspector for deltas

Don't allow long polling connection to restart after end() called

A bit of activity bar refactoring and filter options, clear

Include "On ... someone wrote" in replies / fw

Slightly more robust quoted text removal, detects "On..."

Abort request to really end it

Additional specs for draft store

Test Plan: Run 20 new tests!

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1230
2015-02-24 16:19:47 -08:00
Evan Morikawa
3b0fc853fb fix(composer): fix bug where message body says undefined 2015-02-23 09:34:27 -08:00
Evan Morikawa
132263c38c refactor(tasks): refactor task store
Summary:
task store fixes

more task store fixes

check for blocked tasks

retry tasks

add spec descriptions

more test stubs

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://review.inboxapp.com/D1209
2015-02-20 12:24:15 -08:00
Ben Gotow
c952ea3b12 feat(notifications): Initial pass at new mail notifications
Summary:
Eventually, notification stuff should be moved out of InboxAPI into a separate package, and we should have some documented way of watching for "new" things. (Right now it'd be a bit hard to do on the database store...)

Additional fixes:
- AddRemoveTagsTask now optimistically updates the version. Before it would get the new version from the API response. This was bad because it could still cause local changes to be overwritten if you were changing tags really fast.

- AddRemoveTagsTask now takes a threadId, not a thread for consistency with all the rest of our Tasks

Test Plan: Run tests

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1214
2015-02-20 12:19:34 -08:00
Ben Gotow
e8dff2005d fix(streaming): A few minor fixes for login/logout 2015-02-18 17:41:18 -08:00
Ben Gotow
a94f9ad2a8 fix(autoupdater): Restore auto update functionality, this time with tests
Summary:
fix(autoupdater): Fix bizarrely broken code in autoupdater

fix(urls): Use nilas.com instead of inboxapp

fix(show-main-window): Cmd-1 is the mac standard

fix(autoupdater): TESTS

Test Plan: Run tests

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1199
2015-02-18 14:24:34 -08:00
Ben Gotow
165f5045fb feat(quoted-text): Edit quoted text in replies
Summary:
Use blockquote, apply gmail's styling

Fix in popout composer so the ... button rests at the bottom

Test Plan: Need to figure out the best strategy for tests here - will write tomorrow

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1197
2015-02-18 14:24:16 -08:00
Ben Gotow
651f105740 fix(tests): Clean up after ReactTestUtils, wipe ComponentRegistry between specs
Summary:
Why does message-list have default participants? No other packages do

Component registry warns if mixin component name not found

Clear the component registry between tests and wipe React elements inserted into DOM

Everything should have a displayName, even you ComposerView

Stub all ComponentRegistry dependencies, always

Test Plan: Run all the tests at the same time

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1201
2015-02-18 14:09:46 -08:00
Ben Gotow
b97f607a6e fix(long-polling): Close streaming connections, wait for changes to stop
Summary: fix(*): Minor onboarding react issue

Test Plan: Run existing tests

Reviewers: evan

Reviewed By: evan

Differential Revision: https://review.inboxapp.com/D1208
2015-02-18 13:59:58 -08:00