Commit graph

2686 commits

Author SHA1 Message Date
Jackie Luo 55ed1e2f3c sp(composer-emoji): Correct emojis to emoji 2016-03-15 13:37:54 -07:00
Ben Gotow 1a50a535a9 fix(icon): update assets to fix #1747 2016-03-15 12:46:03 -07:00
Juan Tejada 592e861406 fix(focus): Show drafts in unfocused state when window is blurred
- See #1695
- Update key commands region to clear focus when window blurs
- Dispatch broswer-window-focus/blur as a window event into the renderer
  window
- Update tray icon to listen to window instead of ipc event
2016-03-15 12:12:30 -07:00
Juan Tejada 030b0b57b4 feat(view-mode): Add option in menu to select view mode
Summary:
Also add minor refactoring
#1710

Test Plan: Manual

Reviewers: bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2745
2016-03-15 11:20:55 -07:00
Jackie Luo 76d478b677 refactor(ui-variables): Clean UI variables for consistency/usage
Summary: Shortens and simplifies UI variables so that unused variables are no longer present.

Test Plan: Tested locally.

Reviewers: evan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2738
2016-03-15 11:18:50 -07:00
Jackie Luo 5c8b8c721f 🎨(plugins): Fixes switch alignment issue in #1743 2016-03-15 11:09:09 -07:00
Ben Gotow 84b9741fa6 fix(autolinker): Additional phone number parsing specs 2016-03-15 11:04:00 -07:00
Ben Gotow 92e8a2a7d4 fix(autolinker): Add more test cases, improv URL regex 2016-03-15 10:47:14 -07:00
Ben Gotow 7a7496b675 fix(uploads): Display icon regardless of ext capitalization
Note: In the future we really need to consolidate file-upload.cjsx and attachment-component.cjsx. #1700
2016-03-15 09:31:22 -07:00
Ben Gotow 2d8bb9d3f7 fix(next/prev): Move buttons to correct column #1721 2016-03-15 09:16:28 -07:00
Jackie Luo 492ae69abe Merge pull request #1731 from jamiewilson/darkside
(darkside) using new toolbar selectors, svgs, etc
2016-03-14 18:50:43 -07:00
Ben Gotow b75843bbc0 fix(unread): counts should exclude items outside all mail
#1726, #1718
2016-03-14 18:33:04 -07:00
Jackie Luo 1869709121 🎨(plugins): Add theme-specific icon in plugins tab 2016-03-14 17:55:25 -07:00
Juan Tejada ded7c20fba feat(tray): Update to new set of icons and behavior for tray (menubar)
Summary:
- See #1698

Add specs

Test Plan: - Unit tests

Reviewers: bengotow, evan, drew

Reviewed By: drew

Differential Revision: https://phab.nylas.com/D2734
2016-03-14 17:17:11 -07:00
Ben Gotow cff2f71d18 fix(signatures): Adds default signature, convert to ES6 2016-03-14 17:05:49 -07:00
Jamie Wilson 013898ed02 using new toolbar selectors, svgs, etc. 2016-03-14 19:02:00 -05:00
Juan Tejada 0b2d7043d7 fix(specs): Remove fdescribe 2016-03-14 15:39:42 -07:00
Juan Tejada cfbbcd23d3 fix(snooze): Correctly query and create snooze categories per account
Summary:
- Was not properly updating the references to snoozed categories when
  accounts were added or removed
- Update whenCategoriesReady to make sure we listen until category syncing has concluded (Move inside CategoryStore)
- #1676, #1658

Test Plan: - TODO

Reviewers: evan, drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2723
2016-03-14 15:36:39 -07:00
Ben Gotow 734a52aa6a fix(config): Move account tokens to system keychain
Summary:
This diff also adds an account version number to the config so that the AccountStore can tell whether it should reload accounts (depending on whether it was the instance making tthe changes.)

This diff also fixes a tiny issue where un-opened composers threw an exception if you changed accounts.

Test Plan: New tests

Reviewers: evan, drew, juan

Reviewed By: juan

Subscribers: juan

Differential Revision: https://phab.nylas.com/D2726
2016-03-14 15:14:08 -07:00
Ben Gotow dbf3610c88 hide(zoom): Remove UI for zoom, move to CONFIG.md 2016-03-14 13:13:32 -07:00
Ben Gotow 465831175a rm(autolinker): Use our own very simple autolinker
Summary:
Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540

This is super bad, and also super unnecessary. I think this should do the trick.

Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok?

Test Plan: Need to write some tests

Reviewers: evan, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2725
2016-03-14 12:30:54 -07:00
Juan Tejada 06d7c05aa8 fix(acct-menu): Add option to add account from context menu 2016-03-14 11:22:52 -07:00
Juan Tejada 346dd80a32 fix(specs) 2016-03-14 11:22:42 -07:00
Juan Tejada c185c0d0e4 fix(mail-labels): Don't display sent label
Reference #1671
2016-03-14 11:04:45 -07:00
Ben Gotow fc59d88337 fix(spellcheck): Enables spellcheck menu for basic inputs (#1600)
Summary: Just moves some code so we can easily attach spelling menus to the basic inputs.

Test Plan: Updated existing tests

Reviewers: juan, drew

Reviewed By: drew

Differential Revision: https://phab.nylas.com/D2721
2016-03-14 10:23:57 -07:00
Ben Gotow a3483c0a2b Merge pull request #1648 from Eldorado234/patch-2
Fixed text overflow in phishing detection indicator
2016-03-14 10:09:21 -07:00
Michael Grinich 1b4739335f use bullets instead of checkboxes 2016-03-13 18:03:36 -07:00
Michael Grinich fa7f0faa1b add hiring note 2016-03-13 17:03:33 -07:00
Jackie Luo 9cc235dbbb 🎨(themes): Fixes Windows button UI issues in #1649 2016-03-12 11:43:49 -08:00
Jackie Luo 85388c9cb5 Merge pull request #1632 from DavidChouinard/extraneous-scrollbar-fix
Fixes scrollbar display when content is not scrollable
2016-03-11 17:31:19 -08:00
Jackie Luo 270d1210b3 fix(themes): Add classes for toolbar elements 2016-03-11 16:55:28 -08:00
Evan Morikawa ae4ca59526 fix(sidebar): keep trying on 202s
Also fixed a bug where the email could come back with different
capitalization causing a cache miss
2016-03-11 16:27:04 -05:00
Evan Morikawa 2d8e65ead4 fix(sidebar): add info@ to blacklist 2016-03-11 16:01:29 -05:00
Jackie Luo eea5b7b531 update(readme): Streamline plugin lists 2016-03-11 11:43:52 -08:00
Ben Gotow a61d7b9b3b fix(message-extension): Exception in base class 2016-03-11 11:35:49 -08:00
Ben Gotow aaa5bd17b7 fix(menus): Nylas => Nylas N1 2016-03-11 11:35:49 -08:00
Simon Seyer 257f9a13d9 Fixed text overflow in phishing detection indicator 2016-03-11 20:33:06 +01:00
Jackie Luo 5dc07fb739 update(readme): Add bundled versus community packages 2016-03-11 11:26:49 -08:00
Jackie Luo 2c723725b6 fix(themes): Add quick fixes for Ubuntu 2016-03-11 11:02:02 -08:00
Jackie Luo 4bddd302e1 Merge pull request #1629 from ahmedlhanafy/master
Added Ubuntu theme to the internal packages
2016-03-11 10:59:30 -08:00
Ben Gotow 714b55b299 Merge pull request #1645 from Eldorado234/patch-1
(darkside) Fixed alignment of message headers
2016-03-11 10:24:26 -08:00
Simon Seyer 9cb8a24de8 Fixed alignment of message headers
like the phishing indicator.

Before this change: http://pasteboard.co/2bUg8PU9.png
After: http://pasteboard.co/2bUj2Bmz.png
2016-03-11 19:07:52 +01:00
Ben Gotow d57ef5a060 bump(version): 0.4.14 and changelog 2016-03-10 19:09:00 -08:00
Drew Regitsky fe11a425cd fix(templates): fix a null check bug in template contentedtable ext 2016-03-10 19:06:15 -08:00
Juan Tejada 50296ab2d6 fix(mail-rules): Prevent from adding locked categories 2016-03-10 19:01:34 -08:00
Drew Regitsky 9dc53ee1bd fix(regexp-utils): Also update the regex101 link with test cases 2016-03-10 18:43:02 -08:00
Drew Regitsky 3f017892e0 fix(regexp-utils): Fix urlLinkTagRegex bug
Regex was missing a `?`, so consumed all <a> tags on a single line. Fixed
to be non-greedy.
2016-03-10 18:41:01 -08:00
David Chouinard b20bd9631d Ensure scroll bar state is updated on content change 2016-03-10 18:37:45 -08:00
David Chouinard d23f8cfdac Don't show scrollbars if content is not scrollable 2016-03-10 17:59:06 -08:00
Ahmed Magdy 595bd70514 Added Ubuntu theme to the internal packages 2016-03-11 03:50:19 +02:00