Summary:
Rename ActivityBar => DeveloperBar
Expose sync workers and make them observable
New activity sidebar that replaces momentary notifications
Updated specs
Test Plan: Run new specs!
Reviewers: evan
Reviewed By: evan
Maniphest Tasks: T1131
Differential Revision: https://phab.nylas.com/D1521
Summary:
Resolves T1200 and probably others.
This diff moves all the window management / hot loading into a new class called the WindowManager
and also changes the way the app transitions between onboarding and main window. When you log out,
the main window clears config and clearing the config causes the window manager to close the main
window and open the login window. When it detects a token again, it opens the main window.
This means you can't:
- Open the main window from the login window
- Open mailto: links and accidentally see the main window or a composer, since the draft store isn't
running anywhere.
- Don't need to worry about properly resetting thigns when namespaces change, since the window
is now actually re-created from scratch with the new auth token.
Be a little more defensive about namespace checks in draft-store
Move window code to window-manager
Rename AtomApplication to just `Application`
Specs fix
Test Plan: Run tests, would be good to have more for this.
Reviewers: evan
Reviewed By: evan
Maniphest Tasks: T1200
Differential Revision: https://review.inboxapp.com/D1501
Summary:
Debounce changes out of the DatabaseStore to prevent lots of calls to persistModel from flooding the app
Tasks must always call super so they get IDs
The task queue shouldn't save every time it adds/removes a task - there could be hundreds
ActivityBar package is actually surprisingly slow, re-rendering needlessly
setState in MultiselectList sometimes renders immediately. Don't do this, because sometimes we're rendering twice back to back
Remove dead references
Never allow duplicate tags in the tags array
Don't archive threads that already have the archive tag (it doesn't do anything bad, but why bother creating tasks?)
Update DB specs
Test Plan: Run tests
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1506
Summary:
Load unread counts from database again, not tags
fix(multiselect-list): Clear selection on esc
fix(onboarding): Make target=_blank links work in onboarding pages
fix(workspace): Items in header and footer regions are in a single column
fix(layout): Critical issue for things not 100% height
fix(activity-bar): Show in dev mode so you know you're in dev mode
fix(quoted-text): Support for #divRplyFwdMsg quoted text marker
Test Plan: Run specs
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1484
Summary:
Initial hooks for reply to message
Per-message actions and reply to message!
Always commit changes before openinig popout composer
Flip message display - newest at bottom like Gmail
WIP specs
New activity bar inspector for deltas
Don't allow long polling connection to restart after end() called
A bit of activity bar refactoring and filter options, clear
Include "On ... someone wrote" in replies / fw
Slightly more robust quoted text removal, detects "On..."
Abort request to really end it
Additional specs for draft store
Test Plan: Run 20 new tests!
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1230
Summary:
task store fixes
more task store fixes
check for blocked tasks
retry tasks
add spec descriptions
more test stubs
Test Plan: edgehill --test
Reviewers: bengotow
Reviewed By: bengotow
Differential Revision: https://review.inboxapp.com/D1209
Summary:
fix(http): Support http for API in addition to https throughout
test(attributes): Additional testing for model attributes
fix(versioning): Use version numbers with drafts as well as threads
Test Plan: Run tests
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1194
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
