Mailspring

Foundry376/Mailspring

Fork 0

mirror of https://github.com/Foundry376/Mailspring.git synced 2024-09-23 00:36:50 +08:00

Commit graph

Author	SHA1	Message	Date
Ben Gotow	73afdbb482	fix(autolinker): Add more test cases, improv URL regex	2016-03-15 10:47:14 -07:00
Ben Gotow	c76582194a	rm(autolinker): Use our own very simple autolinker Summary: Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540 This is super bad, and also super unnecessary. I think this should do the trick. Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok? Test Plan: Need to write some tests Reviewers: evan, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D2725	2016-03-14 12:30:54 -07:00

Author

SHA1

Message

Date

Ben Gotow

73afdbb482

fix(autolinker): Add more test cases, improv URL regex

2016-03-15 10:47:14 -07:00

Ben Gotow

c76582194a

rm(autolinker): Use our own very simple autolinker

Summary:
Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540

This is super bad, and also super unnecessary. I think this should do the trick.

Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok?

Test Plan: Need to write some tests

Reviewers: evan, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2725

2016-03-14 12:30:54 -07:00

2 commits