Ben Gotow
8952e7d149
Merge pull request #443 from mbilker/fix-message-body-processor
...
Do not return when original body is null
2015-11-23 14:13:09 -08:00
Evan Morikawa
b9d6e89879
fix(spec): cleanup N1.sh and make specs fail with exit code 1
2015-11-23 16:00:55 -05:00
Ben Gotow
599d8f834f
fix(prefs): Move to a sheet rather than a window, use configSchema
...
Summary:
This diff moves the preferences interface to a sheet in the main window, with the following benefits:
- We can put any sort of React control in it (no ReactRemote)
- It's not strange for the interface to scroll
- Since it can scroll, it's safe to auto-generate preferences for plugins based on their package config schema.
The general tab is now mostly based on the config schema, with the exception of the "Workspace" and "Layout" bits.
The other tabs are still manual, and should be polished more.
Test Plan: No new tests
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D2278
2015-11-23 12:20:51 -08:00
Evan Morikawa
05b50fd7bf
fix(build): bail if script/bootstrap fails and enhance test output
...
Have the test output
2015-11-23 14:34:18 -05:00
mbilker
cc77da8b08
fix(store): return early if body is not a string
2015-11-23 14:22:53 -05:00
Juan Tejada
ea97d94226
fix(tray): Prevent duplicate trays on preference changes
2015-11-23 09:53:05 -08:00
Juan Tejada
b3a9f31051
fix(tray): Prevent system tray from being initialized more than once
...
- Makes sure the tray is deactivated before activating
2015-11-23 09:31:10 -08:00
Ben Gotow
3d76a944e2
Merge pull request #441 from mbilker/remove-vm-compatibility-layer
...
cleanup(build): Remove vm-compatibility-layer
2015-11-22 21:37:50 -08:00
mbilker
38d066e163
fix(store): do not return when original body is null
2015-11-21 22:08:40 -05:00
mbilker
5644f84e4a
fix(packages): remove vm-compatibility-layer
...
vm-compatibility-layer was designed to support obsolete APIs in node
v0.11.x of node v0.10.x. It is only used in the build Gruntfile and
nowhere else in the project.
2015-11-21 00:17:27 -05:00
Ben Gotow
a1b3ad8767
feat(dark-mode): Double invert filter for nice dark HTML bodies
2015-11-20 18:53:34 -08:00
Ben Gotow
39a142ddcb
fix(message-bodies): Ensure each message body is processed
...
Relevant for #436
2015-11-20 18:03:47 -08:00
Drew Regitsky
690dca50cb
fix(examples): Small fixes for Send Availability plugin
2015-11-20 15:21:58 -08:00
Drew Regitsky
abb6378bd5
fix(examples): revamp/fix Send-Availability, change URL to live Heroku link
...
Summary:
Several fixes and updates the the Send Availability example package. Switches from
using `electron-safe-ipc` to using `protocol.RegisterStringProtocol` to communicate
with the child window. Changes the URLs in the package from localhost to our live
demo backend.
Test Plan: manual
Reviewers: bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D2271
2015-11-19 18:16:38 -08:00
Ben Gotow
aaf6132134
fix(events): Avoid webkitMovement deprecations, fixes #428
2015-11-19 16:17:03 -08:00
Juan Tejada
39a52f4535
feat(sidebar): Add behavior to persist collapsed state of sidebar items
...
Summary: - Updates account sidebar to persist collapsed state to the the config
Test Plan: - manual
Reviewers: evan, bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D2276
2015-11-19 15:48:44 -08:00
Juan Tejada
32e77e3dec
fix(spectron): Update window count spec
2015-11-19 14:42:34 -08:00
Juan Tejada
84739b3acc
fix(spectron): Update spectron setup:
...
- Passes new arguments to spectron.Application
- Updates setup of test suite to wait for application to boot before
specs are run
2015-11-19 12:29:03 -08:00
Evan Morikawa
9ffd940d21
fix(contenteditable): allow valid null events to callbacks
2015-11-19 13:38:19 -05:00
Evan Morikawa
2699888e47
fix(main): globa.resourcePath now resourcePath
2015-11-18 17:41:00 -08:00
Juan Tejada
53bd5ab2d0
ci(spectron): Add support to execute spectron/chrome-driver tests
...
Summary:
- Sets up spectron test suite inside its own directory and with its own
dependencies (must run on a build of the app)
- Sets up dummy test
- Adds `run-spectron-specs` grunt task, and adds it to cibuild task
- Cleans up spec tasks code
Test Plan: - Run specs
Reviewers: evan, bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D2256
2015-11-18 16:36:58 -08:00
Juan Tejada
5be36f8572
fix(specs): Update composer-view-spec to use renamed functions
2015-11-18 15:51:48 -08:00
Juan Tejada
bbd2d67112
fix(contenteditable): Fix undefined callback on plugins
2015-11-18 15:29:42 -08:00
Juan Tejada
c2ce51ae0c
fix(composer): Fix several composer issues and refactor Contenteditable
...
Summary:
- Fixes T5819 issues
- Adds ContenteditbalePlugin mechanism to allow extension of Contenteditable
functionality, and completely removes lifecycleCallbacks from Contenteditable
- Refactors list functionality outside of Contenteditable and into a plugin
- Updates ComposerView to apply DraftStoreExtensions through a ContentEditablePlugin
- Moves spell checking logic outside of Contenteditable into the spellcheck package
Fixes T5824 (atom.assert)
Fixes T5951 (shift-tabbing) bullets
Test Plan: - Unit tests and manual
Reviewers: evan, bengotow
Reviewed By: bengotow
Maniphest Tasks: T5951, T5824, T5819
Differential Revision: https://phab.nylas.com/D2261
2015-11-18 15:22:31 -08:00
Juan Tejada
447dc7283e
fix(compile-cache): Add .jsx extension to babel compiler module
2015-11-18 13:22:50 -08:00
Juan Tejada
f0c435e2ab
fix(compile-cache): Add .jsx extension to be transbiled using babel
2015-11-18 12:35:37 -08:00
Ben Gotow
b3845e675e
fix(search): Execute search for subject, autoselect first item
...
Fixes T5899, but we may want to iterate on it more later.
2015-11-18 12:35:19 -08:00
Evan Morikawa
43c4859592
fix(draft): fix showing of incorrect body when pending send
...
Summary: Fixes T3712
Test Plan: new tests
Reviewers: juan, bengotow
Reviewed By: bengotow
Maniphest Tasks: T3712
Differential Revision: https://phab.nylas.com/D2273
2015-11-18 12:32:07 -08:00
Ben Gotow
a5256bd56a
🍒 (atom): Pull new, cleaner compile cache + index.js
2015-11-17 19:43:08 -08:00
Juan Tejada
52e2c1251e
refactor(script/docs): Add comments
2015-11-17 18:09:46 -08:00
Juan Tejada
35991c5786
Add docs script to automatically move output of grunt docs to gh-pages
2015-11-17 18:03:24 -08:00
Ben Gotow
285a60493e
fix(specs): Ternary operator in jasmine-helper was valid coffee...
2015-11-17 17:48:32 -08:00
Ben Gotow
a5013c0bbd
fix(specs): Update specs following 0.29.2 > 0.34.3 move
2015-11-17 17:40:06 -08:00
Evan Morikawa
51602f69a5
refactor(env): new NylasEnv global
...
Converted all references of global atom to NylasEnv
Temporary rename atom.io
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.io/temporaryAtomIoReplacement/g'
atom.config to NylasEnv.config
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.config/NylasEnv.config/g'
atom.packages -> NylasEnv.packages
atom.commands -> NylasEnv.commands atom.getLoadSettings
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.commands/NylasEnv.commands/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.getLoadSettings/NylasEnv.getLoadSettings/g'
More common atom methods
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.styles/NylasEnv.styles/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.emitError/NylasEnv.emitError/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.inSpecMode/NylasEnv.inSpecMode/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.inDevMode/NylasEnv.inDevMode/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.getWindowType/NylasEnv.getWindowType/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.displayWindow/NylasEnv.displayWindow/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.quit/NylasEnv.quit/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.close/NylasEnv.close/g'
More atom method changes
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.keymaps/NylasEnv.keymaps/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.hide/NylasEnv.hide/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.getCurrentWindow/NylasEnv.getCurrentWindow/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.menu/NylasEnv.menu/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.getConfigDirPath/NylasEnv.getConfigDirPath/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.isMainWindow/NylasEnv.isMainWindow/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.finishUnload/NylasEnv.finishUnload/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.isWorkWindow/NylasEnv.isWorkWindow/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.showSaveDialog/NylasEnv.showSaveDialog/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.append/NylasEnv.append/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.confirm/NylasEnv.confirm/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.clipboard/NylasEnv.clipboard/g'
find -E . -regex ".*\.(coffee|cjsx|js|md|cmd|es6)" -print0 | xargs -0 sed
-i "" 's/atom.getVersion/NylasEnv.getVersion/g'
More atom renaming
Rename atom methods
More atom methods
Fix grunt config variable
Change atom.cmd to N1.cmd
Rename atom.coffee and atom.js to nylas-env.coffee nylas-env.js
Fix atom global reference in specs manually
Fix atom requires
Change engine from atom to nylas
got rid of global/nylas-env
rename to nylas-win-bootup
Fix onWindowPropsChanged to onWindowPropsReceived
fix nylas-workspace
atom-text-editor to nylas-theme-wrap
atom-text-editor -> nylas-theme-wrap
Replacing atom keyword
AtomWindow -> NylasWindow
Replace Atom -> N1
Rename atom items
nylas.asar -> atom.asar
Remove more atom references
Remove 6to5 references
Remove license exception for atom
2015-11-17 16:41:20 -08:00
Evan Morikawa
5de64331b9
fix(package): revert to upgraded package.json
2015-11-17 16:25:58 -08:00
Evan Morikawa
46ee3d8cc8
fix(docs): fix docs so they compile properly.
2015-11-17 15:48:59 -08:00
Ben Gotow
3a16484d7d
fix(tray): Retina tray icon with template image for dark menu bar mode
2015-11-17 15:36:52 -08:00
Ben Gotow
74252d58d9
bump( ⚡ ️): Electron 0.29.2 > 0.34.3, Sqlite 3.0.11 > 3.1.1
2015-11-17 15:36:32 -08:00
Ben Gotow
72b8bc1853
changelog(0.3.23): Features, fixes in 0.3.23
2015-11-17 10:37:58 -08:00
Ben Gotow
94e0cb97d3
fix(bootstrap): Set apm environment vars to avoid Atom conflicts
2015-11-16 16:42:35 -08:00
Ben Gotow
95c7e763c0
fix(proxyquire): No longer need forked version
2015-11-16 15:43:47 -08:00
Ben Gotow
5e42f57514
fix(proxyquire): Reference http url instead of https
2015-11-16 15:22:27 -08:00
Ben Gotow
ad2d2973cb
cleanup(*): We do not support devDependencies as a concept
2015-11-16 11:46:36 -08:00
Ben Gotow
96762647a9
ASAR v0.8, because apparently 0.5 can skip files
2015-11-16 10:02:31 -08:00
Juan Tejada
647aed5f14
Convert Composer Template example to ES6
...
Summary:
- Include ES6 files in spec-suite
- Fix template store specs
- Refactors TemplateStore a little bit to adjust to specs
- Convert coffe .cjsx files to ES6 .jsx files
- Fix TemplateDraftStoreExtension functions
- Update ComposerTemplates example README
Test Plan: - Plugin unit tests
Reviewers: bengotow, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D2250
2015-11-14 22:12:06 -08:00
Ben Gotow
a67f93a014
bump(version): 0.3.23
2015-11-14 13:11:05 -08:00
Ben Gotow
c34747c03c
fix(tray): Slightly resize win/linux tray icons
2015-11-14 13:10:39 -08:00
Juan Tejada
6786e0ae04
fix(lint): Remove lint errors
2015-11-13 19:41:53 -08:00
Juan Tejada
f66c24918f
fix(tray): Set tray width based on actual unread count text width
2015-11-13 19:30:25 -08:00
Ben Gotow
27ae261d1b
fix(tray): "Open Inbox" if main window is minimized / hidden
2015-11-13 18:11:44 -08:00