Summary: Move all Intercom feedback code to a package. Change the appearance of the lower right question mark icon when a new intercom message is received (red, with repeating CSS bounce animation). New messages are detected by keeping the intercom window open (after the first time it's opened by the user), and listening for DOM mutations of particular classes.
Test Plan: manual
Reviewers: bengotow
Reviewed By: bengotow
Subscribers: evan
Differential Revision: https://phab.nylas.com/D2125
Summary: Fixes Sentry 3319 and 3303
Test Plan: Run three new tests
Reviewers: dillon, evan
Reviewed By: dillon, evan
Differential Revision: https://phab.nylas.com/D2118
Summary:
Change `addAccountFromJSON` in `AccountStore` to throw an exception when it encounters
invalid data, instead of calling `atom.emitError()`. Just calling `emitError` doesn't
throw an exception, so the code proceeds as if an account has been added. Instead, call
`emitError` from AccountSettingsPage, and display an error message to the user.
Test Plan: manual
Reviewers: bengotow
Reviewed By: bengotow
Subscribers: evan
Differential Revision: https://phab.nylas.com/D2116
Summary:
fixes T4080
set the maximum default viewport size to 1440x900, the screen resolution for a 15 inch macbook pro.
if the monitor is either wider or taller than the default, then cap the dimension and center it.
Test Plan: added tests
Reviewers: evan, bengotow
Reviewed By: evan, bengotow
Maniphest Tasks: T4080
Differential Revision: https://phab.nylas.com/D2115
Summary:
It wasn't selecting the account after you added it
Fixes T3569
Test Plan: new tests
Reviewers: dillon, bengotow
Reviewed By: bengotow
Maniphest Tasks: T3569
Differential Revision: https://phab.nylas.com/D2085
Summary:
Package names must match directory names
Not going to use new Swithc component, but might as well be part of component kit
Move APMWrapper into core so it can be used from anywhere
Move manual package install coe to package-manager
Gray out window titles when in the background
Do not allow multiple onboarding windows at the same time
Finalize styling f initial-prefs and initial-packages, make it work (only github package atm)
Other nits
Change the welcome copy:
- Call it easy to extend vs easy to use
- Remove the subtitle from the first screen which doesn't really fit
- Make the second page emphasize that its created /for/ developers and easy to extend with Javascript.
- Explain what the sync engine is rather than saying it's "faster and more extensible" (??)
Test Plan: Run tests
Reviewers: evan, dillon
Reviewed By: evan
Maniphest Tasks: T3346
Differential Revision: https://phab.nylas.com/D2079
Summary: Adds a prominent blue button to email us feedback
Test Plan: Run tests
Reviewers: dillon, evan
Reviewed By: dillon, evan
Differential Revision: https://phab.nylas.com/D2081
