Commit graph

2695 commits

Author SHA1 Message Date
Jackie Luo
f7f39e74ce fix(themes): Add quick fixes for Ubuntu 2016-03-11 11:02:02 -08:00
Jackie Luo
ea912f5690 Merge pull request #1629 from ahmedlhanafy/master
Added Ubuntu theme to the internal packages
2016-03-11 10:59:30 -08:00
Ben Gotow
5d539ce75b Merge pull request #1645 from Eldorado234/patch-1
(darkside) Fixed alignment of message headers
2016-03-11 10:24:26 -08:00
Simon Seyer
6d85e1785b Fixed alignment of message headers
like the phishing indicator.

Before this change: http://pasteboard.co/2bUg8PU9.png
After: http://pasteboard.co/2bUj2Bmz.png
2016-03-11 19:07:52 +01:00
Ben Gotow
34fd39962f bump(version): 0.4.14 and changelog 2016-03-10 19:09:00 -08:00
Drew Regitsky
6efaf6220a fix(templates): fix a null check bug in template contentedtable ext 2016-03-10 19:06:15 -08:00
Juan Tejada
70b425e5de fix(mail-rules): Prevent from adding locked categories 2016-03-10 19:01:34 -08:00
Drew Regitsky
071a58e355 fix(regexp-utils): Also update the regex101 link with test cases 2016-03-10 18:43:02 -08:00
Drew Regitsky
a41844c38d fix(regexp-utils): Fix urlLinkTagRegex bug
Regex was missing a `?`, so consumed all <a> tags on a single line. Fixed
to be non-greedy.
2016-03-10 18:41:01 -08:00
David Chouinard
d0baf878f5 Ensure scroll bar state is updated on content change 2016-03-10 18:37:45 -08:00
David Chouinard
3396f4a46e Don't show scrollbars if content is not scrollable 2016-03-10 17:59:06 -08:00
Ahmed Magdy
cad18a0d98 Added Ubuntu theme to the internal packages 2016-03-11 03:50:19 +02:00
Juan Tejada
533ffd683e fix(snooze): Fix getter for inbox category in when moving to snooze 2016-03-10 17:46:23 -08:00
Ben Gotow
b14a1a14e4 fix(plugin-auth): POST returns 200, no response body 2016-03-10 17:34:26 -08:00
Juan Tejada
f313cc40f6 fix(lint): Fix in MailLabelSet 2016-03-10 17:27:51 -08:00
Ben Gotow
7c2fd2a91b fix(labels): Do not re-use mail labels if they're removable 2016-03-10 17:08:42 -08:00
Jackie Luo
d28c79fc75 🎨(theme-picker): Order internal themes and update theme names 2016-03-10 16:37:06 -08:00
Juan Tejada
1218109282 fix(change-labels-task): Update label sets after modelifying 2016-03-10 16:26:25 -08:00
Ben Gotow
038032d68e fix(bodies): Message with empty string body showed loading forever 2016-03-10 16:13:17 -08:00
Ben Gotow
c296e2e1d4 fix(sync): Do not paginate /metadata unless pluginsSupported 2016-03-10 16:03:36 -08:00
Evan Morikawa
a69d918c0f fix(sidebar): return valid person to prevent cache miss 2016-03-10 18:49:00 -05:00
Juan Tejada
c118c99d73 fix(sent): Do not allow sent or drafts to be modified
- Specifically, when dragging from the sent perspective, we should not
  allow the sent label to be removed.
- If moved to trash or spam, `all mail` will be correctly removed from
  the thread, but it will keep sent label
- Show sent MailLabel on the threads
2016-03-10 15:44:53 -08:00
Evan Morikawa
ea98cb8388 fix(sidebar): change optional bit in package 2016-03-10 18:40:26 -05:00
Evan Morikawa
69d1b10508 fix(sidebar): don't show nulled profiles 2016-03-10 18:32:37 -05:00
Ben Gotow
04492c06c7 fix(messages): Replace calc with margin to make plugin styling easier 2016-03-10 15:31:05 -08:00
Ben Gotow
3888c0c510 fix(labels): Labels should not show "X" in wide mode 2016-03-10 15:31:05 -08:00
Jackie Luo
688582bf57 🎨(theme-picker): Adjust styles 2016-03-10 15:18:57 -08:00
Evan Morikawa
5dbef230a3 fix(sidebar): explicitly detect 202 and cache null people 2016-03-10 18:16:32 -05:00
Ben Gotow
e8e4761e45 fix(github): Correct minor issue during ES6 conversion 2016-03-10 14:31:50 -08:00
Ben Gotow
0fb6d4c401 fix(remove-from-view): Missing invocation for non-Gmail 2016-03-10 14:25:28 -08:00
Jackie Luo
4d7f515090 feat(plugins): Move uninstall from theme picker to plugins tab
Summary: Move uninstall functionality to the plugins tab in preferences.

Test Plan: Tested locally.

Reviewers: bengotow, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2716
2016-03-10 14:16:07 -08:00
Juan Tejada
f12896d54f fix(gmail-labels): Constraint so threads always belong to all,spam or trash
Summary:
- In Gmail all threads /must/ belong to either All Mail, Trash and Spam, and
  they are mutually exclusive, so we need to make sure that any add/remove
  label operation still guarantees that constraint
- Update ChangeLabelsTask to modify the set of labels to add and remove
  based on this rule
- Update tasksFor archiving, moving to trash and moving to spam so they
  don't affect any other labels in the thread, as gmail does.
- Removing from view /will/ remove any current labels, but will also
  move between all mail and trash as needed
- Remove Inbox, Trash and Spam from the CategoryPicker, as Gmail does

Test Plan: - Unit tests

Reviewers: drew, evan, bengotow

Reviewed By: drew, evan, bengotow

Differential Revision: https://phab.nylas.com/D2715
2016-03-10 14:13:31 -08:00
Ben Gotow
af9a858ba7 fix(trash/spam): Typo sent => spam 2016-03-10 13:27:11 -08:00
Ben Gotow
3076acd7af fix(trash/spam): New inAllMail filter applied to all mailbox views except trash and spam 2016-03-10 12:41:32 -08:00
Jackie Luo
ff49178f28 Revert "🎨(plugins): Change menus to consolidate plugin installation" 2016-03-10 12:26:57 -08:00
Ben Gotow
915afa8ba6 bump(version): 0.4.13 beta 2016-03-10 12:08:05 -08:00
Ben Gotow
b8485eaee5 fix(onboarding): We should accept IPs for servers during auth 2016-03-10 12:08:05 -08:00
Ben Gotow
1816d3bd73 fix(api): Don't display auth failure bar for req with no auth (onboarding) 2016-03-10 12:08:05 -08:00
Ben Gotow
a1a5aaddbb fix(onboarding): Make links in error messages clickable 2016-03-10 12:08:05 -08:00
Evan Morikawa
d9d9d1a474 fix(sidebar): design tweaks to sidebar 2016-03-10 15:06:59 -05:00
Evan Morikawa
dade20a148 fix(sidebar): minor sidebar style and padding tweaks 2016-03-10 15:06:59 -05:00
Jackie Luo
73e01dabb4 fix(themes): Fix linter issues and relink images 2016-03-10 11:54:05 -08:00
Ben Gotow
263c3a152e 💄(sidebar): Replace icon with person 2016-03-10 11:15:52 -08:00
Jackie Luo
7e7835095d 🎨(themes): Move notification heading below toolbar 2016-03-10 11:14:02 -08:00
Jackie Luo
07d0655c55 Merge pull request #1621 from jamiewilson/master
Adding ui-darkside to internal packages
2016-03-10 11:11:15 -08:00
Evan Morikawa
fe5b9c3258 fix(sidebar): use http basic auth to pass token 2016-03-10 14:06:48 -05:00
Ben Gotow
2bd03dc44f fix(sync): Pull down and associate metadata during initial sync
Summary:
Snooze should wait for categories on all accounts

Fix authPlugin to rembmer `plugin+accountId`, not pluginId, add specs

categories() returned [], categories(acctId) returned {}

dry up sync worker, fetch metadata before anything else

Test Plan: Run tests

Reviewers: drew, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2693
2016-03-10 11:06:06 -08:00
Ben Gotow
4fefec0b52 patch(save): Only save drafts when necessary, avoid sync-engine issues
Summary:
Previously, we have saved drafts back to the user's provider through the sync engine. There are a handful of very serious edge case issues we're working to solve that are creating a bad user experience. (#933, #1175, #1504, #1237)

For now, we're going to change the behavior of N1 to mitagate these issues.

- If you create a draft in N1, we will not sync it to other mail clients while you're working on it.
- If you enable send later, we'll start syncing the draft to the server as before.
- If you created the draft in another client, we'll sync the draft to the server as before.

Fix specs

Test Plan: Run specs

Reviewers: evan, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2706
2016-03-10 11:03:38 -08:00
Jamie Wilson
cf6fa6d93f adding ui-darkside to internal packages 2016-03-10 12:18:32 -06:00
Ben Gotow
6d7cfa50f2 fix(bodies): MBP should cache "" so that it updates when new body arrives 2016-03-09 19:14:54 -08:00