Commit graph

2578 commits

Author SHA1 Message Date
Jackie Luo f695c9c8a8 🎨(plugins): Fixes switch alignment issue in #1743 2016-03-15 11:09:09 -07:00
Ben Gotow da47fd4bdb fix(autolinker): Additional phone number parsing specs 2016-03-15 11:04:00 -07:00
Ben Gotow 73afdbb482 fix(autolinker): Add more test cases, improv URL regex 2016-03-15 10:47:14 -07:00
Ben Gotow 1ad2598a50 fix(uploads): Display icon regardless of ext capitalization
Note: In the future we really need to consolidate file-upload.cjsx and attachment-component.cjsx. #1700
2016-03-15 09:31:22 -07:00
Ben Gotow 310b8de2b0 fix(next/prev): Move buttons to correct column #1721 2016-03-15 09:16:28 -07:00
Jackie Luo c68834553d Merge pull request #1731 from jamiewilson/darkside
(darkside) using new toolbar selectors, svgs, etc
2016-03-14 18:50:43 -07:00
Ben Gotow 77b86dd087 fix(unread): counts should exclude items outside all mail
#1726, #1718
2016-03-14 18:33:04 -07:00
Jackie Luo e5c2075d26 🎨(plugins): Add theme-specific icon in plugins tab 2016-03-14 17:55:25 -07:00
Juan Tejada 32a47bcb7a feat(tray): Update to new set of icons and behavior for tray (menubar)
Summary:
- See #1698

Add specs

Test Plan: - Unit tests

Reviewers: bengotow, evan, drew

Reviewed By: drew

Differential Revision: https://phab.nylas.com/D2734
2016-03-14 17:17:11 -07:00
Ben Gotow 8e9d7ff73e fix(signatures): Adds default signature, convert to ES6 2016-03-14 17:05:49 -07:00
Jamie Wilson 913c9d633c using new toolbar selectors, svgs, etc. 2016-03-14 19:02:00 -05:00
Juan Tejada 4f1617550d fix(specs): Remove fdescribe 2016-03-14 15:39:42 -07:00
Juan Tejada 812b64edec fix(snooze): Correctly query and create snooze categories per account
Summary:
- Was not properly updating the references to snoozed categories when
  accounts were added or removed
- Update whenCategoriesReady to make sure we listen until category syncing has concluded (Move inside CategoryStore)
- #1676, #1658

Test Plan: - TODO

Reviewers: evan, drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2723
2016-03-14 15:36:39 -07:00
Ben Gotow 4593d0a9b1 fix(config): Move account tokens to system keychain
Summary:
This diff also adds an account version number to the config so that the AccountStore can tell whether it should reload accounts (depending on whether it was the instance making tthe changes.)

This diff also fixes a tiny issue where un-opened composers threw an exception if you changed accounts.

Test Plan: New tests

Reviewers: evan, drew, juan

Reviewed By: juan

Subscribers: juan

Differential Revision: https://phab.nylas.com/D2726
2016-03-14 15:14:08 -07:00
Ben Gotow a1691c10b2 hide(zoom): Remove UI for zoom, move to CONFIG.md 2016-03-14 13:13:32 -07:00
Ben Gotow c76582194a rm(autolinker): Use our own very simple autolinker
Summary:
Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540

This is super bad, and also super unnecessary. I think this should do the trick.

Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok?

Test Plan: Need to write some tests

Reviewers: evan, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2725
2016-03-14 12:30:54 -07:00
Juan Tejada 1e765a6b62 fix(acct-menu): Add option to add account from context menu 2016-03-14 11:22:52 -07:00
Juan Tejada 938933fc1e fix(specs) 2016-03-14 11:22:42 -07:00
Juan Tejada 1e567973c4 fix(mail-labels): Don't display sent label
Reference #1671
2016-03-14 11:04:45 -07:00
Ben Gotow 96c70368c4 fix(spellcheck): Enables spellcheck menu for basic inputs (#1600)
Summary: Just moves some code so we can easily attach spelling menus to the basic inputs.

Test Plan: Updated existing tests

Reviewers: juan, drew

Reviewed By: drew

Differential Revision: https://phab.nylas.com/D2721
2016-03-14 10:23:57 -07:00
Ben Gotow 53037b9918 Merge pull request #1648 from Eldorado234/patch-2
Fixed text overflow in phishing detection indicator
2016-03-14 10:09:21 -07:00
Michael Grinich a8fe79cdda use bullets instead of checkboxes 2016-03-13 18:03:36 -07:00
Michael Grinich 8e41a2b3f2 add hiring note 2016-03-13 17:03:33 -07:00
Jackie Luo 6e9384792a 🎨(themes): Fixes Windows button UI issues in #1649 2016-03-12 11:43:49 -08:00
Jackie Luo a91add4523 Merge pull request #1632 from DavidChouinard/extraneous-scrollbar-fix
Fixes scrollbar display when content is not scrollable
2016-03-11 17:31:19 -08:00
Jackie Luo 3068a08de5 fix(themes): Add classes for toolbar elements 2016-03-11 16:55:28 -08:00
Evan Morikawa 9cbe002a8b fix(sidebar): keep trying on 202s
Also fixed a bug where the email could come back with different
capitalization causing a cache miss
2016-03-11 16:27:04 -05:00
Evan Morikawa 5ecc67b42b fix(sidebar): add info@ to blacklist 2016-03-11 16:01:29 -05:00
Jackie Luo 4c3ceba901 update(readme): Streamline plugin lists 2016-03-11 11:43:52 -08:00
Ben Gotow 43a3646cd3 fix(message-extension): Exception in base class 2016-03-11 11:35:49 -08:00
Ben Gotow 797c043802 fix(menus): Nylas => Nylas N1 2016-03-11 11:35:49 -08:00
Simon Seyer 9b14c551e2 Fixed text overflow in phishing detection indicator 2016-03-11 20:33:06 +01:00
Jackie Luo 20b270edba update(readme): Add bundled versus community packages 2016-03-11 11:26:49 -08:00
Jackie Luo f7f39e74ce fix(themes): Add quick fixes for Ubuntu 2016-03-11 11:02:02 -08:00
Jackie Luo ea912f5690 Merge pull request #1629 from ahmedlhanafy/master
Added Ubuntu theme to the internal packages
2016-03-11 10:59:30 -08:00
Ben Gotow 5d539ce75b Merge pull request #1645 from Eldorado234/patch-1
(darkside) Fixed alignment of message headers
2016-03-11 10:24:26 -08:00
Simon Seyer 6d85e1785b Fixed alignment of message headers
like the phishing indicator.

Before this change: http://pasteboard.co/2bUg8PU9.png
After: http://pasteboard.co/2bUj2Bmz.png
2016-03-11 19:07:52 +01:00
Ben Gotow 34fd39962f bump(version): 0.4.14 and changelog 2016-03-10 19:09:00 -08:00
Drew Regitsky 6efaf6220a fix(templates): fix a null check bug in template contentedtable ext 2016-03-10 19:06:15 -08:00
Juan Tejada 70b425e5de fix(mail-rules): Prevent from adding locked categories 2016-03-10 19:01:34 -08:00
Drew Regitsky 071a58e355 fix(regexp-utils): Also update the regex101 link with test cases 2016-03-10 18:43:02 -08:00
Drew Regitsky a41844c38d fix(regexp-utils): Fix urlLinkTagRegex bug
Regex was missing a `?`, so consumed all <a> tags on a single line. Fixed
to be non-greedy.
2016-03-10 18:41:01 -08:00
David Chouinard d0baf878f5 Ensure scroll bar state is updated on content change 2016-03-10 18:37:45 -08:00
David Chouinard 3396f4a46e Don't show scrollbars if content is not scrollable 2016-03-10 17:59:06 -08:00
Ahmed Magdy cad18a0d98 Added Ubuntu theme to the internal packages 2016-03-11 03:50:19 +02:00
Juan Tejada 533ffd683e fix(snooze): Fix getter for inbox category in when moving to snooze 2016-03-10 17:46:23 -08:00
Ben Gotow b14a1a14e4 fix(plugin-auth): POST returns 200, no response body 2016-03-10 17:34:26 -08:00
Juan Tejada f313cc40f6 fix(lint): Fix in MailLabelSet 2016-03-10 17:27:51 -08:00
Ben Gotow 7c2fd2a91b fix(labels): Do not re-use mail labels if they're removable 2016-03-10 17:08:42 -08:00
Jackie Luo d28c79fc75 🎨(theme-picker): Order internal themes and update theme names 2016-03-10 16:37:06 -08:00