Commit graph

1889 commits

Author SHA1 Message Date
Drew Regitsky f679f7c214 fix(templates): fix several bugs in templates plugin
Fixes behavior when there are no template files, prevents renaming/creating
with an empty name, fixes yet another way to accidentally make yellow text,
misc small style fixes
2016-01-12 12:44:38 -08:00
Juan Tejada 1c12fe3d6a fix(composer): Fix focus behavior when signature present and when
clicking outside:

- When focusing the composer via click inside the contenteditable region or via
tabbing, last text node before the signature (or blockquotes) will be focused.
- When focusing composer by clicking outside contenteditable region, it
  will default to default contenteditable focus behavior via new method:
  `nativeFocus`
2016-01-12 12:36:19 -08:00
Ben Gotow b14b7086ab fix(indicators): Remove duplicate description key 2016-01-12 10:28:34 -08:00
Ben Gotow c1f98f2fb3 fix(readme): Remove link to plugins repo 2016-01-12 10:18:41 -08:00
Juan Tejada fe625d8f6d Update names to use perspective instead of view 2016-01-12 09:49:56 -08:00
Ben Gotow 90fedbf131 Perf: Category
Rather than computing the types ahead of time when the object is created and generating methods, keep a few standard methods around and change the hardcoded names to maps so the lookup is O[1]
2016-01-12 09:32:34 -08:00
Ben Gotow d424192161 Perf for thread list. See description
- ComponentRegistry: findComponentsMatching often returns zero results but makes a lot of transient data structures. Add a cache to make it O[1]

- Contact isMe is called a zillion times to compute thread participant display. Checking the AccountStore had been required was slow.

- getStandardCategory is also called a ton. Rather than create a filtered array and then searching that, just search the existing array.
2016-01-12 09:10:52 -08:00
Ben Gotow 4b11b0586d fix Item id / clientId issue breaking thread list 2016-01-12 08:45:05 -08:00
Ben Gotow 5c491d16af Merge branch 'master' into unified-inbox
# Conflicts:
#	internal_packages/events/lib/event-header.cjsx
#	spec/stores/file-download-store-spec.coffee
#	spec/tasks/event-rsvp-spec.coffee
#	src/flux/tasks/event-rsvp.coffee
2016-01-12 08:20:55 -08:00
Ben Gotow 3b3d6a0a3b bump(version): 0.3.40 2016-01-12 08:13:43 -08:00
Ben Gotow 0360c59460 fix(composer): Fix tabbing from body to subject 2016-01-11 18:13:42 -08:00
Juan Tejada 6ad4644262 Fix issues in AccountSidebarStore and MailboxPerpective#isEqual 2016-01-11 17:54:40 -08:00
Ben Gotow 963d86cfd3 fix(composer): 30px area would focus wrap instead of contenteditable. Fixes #935 2016-01-11 17:44:55 -08:00
Ben Gotow 0aa4b88e1e fix(composer): Focus last element, not just text node 2016-01-11 17:44:17 -08:00
Ben Gotow 51319b5c8d fix(spellcheck): Redo node creation each time, optimize findSimilarNodes
findSimilarNodes was taking 20% of total execution time because my test email was a jenkins error report with thousands of text nodes.
2016-01-11 17:31:03 -08:00
Juan Tejada a0e83f1935 Fix SuggestioStore -- update to use NylasStore 2016-01-11 16:32:25 -08:00
Ben Gotow 149d86cb56 Fix search suggestions using old-style store 2016-01-11 16:26:41 -08:00
Ben Gotow 391504b07d Fix flattening of categories not working since they're maps 2016-01-11 16:24:12 -08:00
Ben Gotow dbc3b85659 Bump submodule reference 2016-01-11 16:21:05 -08:00
Ben Gotow d81927d953 Remove query formatting that used to match ElasticSearch 2016-01-11 16:16:35 -08:00
Juan Tejada 7f2c8481ff Fix more specs:
- SearchBar
- EventRSVPTask
- ContactStore
2016-01-11 16:14:21 -08:00
Ben Gotow 10cb195226 Search bar fixes 2016-01-11 15:58:10 -08:00
Drew Regitsky 2849cce077 fix(templates): fix two bugs breaking templates plugin rename and search 2016-01-11 15:28:31 -08:00
Ben Gotow a8c563f09d Updated QuerySubscription specs 2016-01-11 15:24:46 -08:00
Juan Tejada 9f5e07f9c5 Fix tests for AccountSidebarStore
- Switches to using CategoryStore to reduce complexity
- Update CategoryStore.categories to retun all categories when account
  is null
- Inits AccountSidebarStore._account based on the currently focused
  MailboxPerspective
2016-01-11 15:16:50 -08:00
Ben Gotow 04c6be4dfe AccountStore no longer tracks index, Actions.selectAccount gone 2016-01-11 14:11:48 -08:00
Juan Tejada 53d26b38a8 Fix Contact and Thread specs 2016-01-11 13:58:22 -08:00
Ben Gotow e62ddf5d63 Fix ModelViewSelection specs 2016-01-11 13:47:39 -08:00
Juan Tejada e803b66a1a Wrap FileDownloadStore in describe block 2016-01-11 13:44:54 -08:00
Ben Gotow a4d33be4f2 More spec fixes 2016-01-11 13:40:42 -08:00
Juan Tejada 5c74f23072 Remove fdescribe 2016-01-11 13:39:25 -08:00
Juan Tejada 3138843748 Fix AccountSwitcher specs 2016-01-11 13:38:44 -08:00
Juan Tejada 2c7626a355 Fix ThreadListParticipants spec 2016-01-11 13:31:35 -08:00
Juan Tejada 9847e58b7f Fix CategoryPicker specs
- Add NylasUtils.mockObservable helper
2016-01-11 13:23:59 -08:00
Ben Gotow 2c74b38323 fixes for draft store specs, contact.isMe now returns true if it matches any account 2016-01-11 13:23:35 -08:00
Juan Tejada d98eca2cca Add rx-lite-testing 2016-01-11 12:26:27 -08:00
Ben Gotow 6a735da033 fix(rsvp): Check that you are a participant, support aliases. Fixes #962 2016-01-11 12:20:26 -08:00
Ben Gotow f3464c7db3 fix(downloads): Replace path.sep when saving files - Sentry 8749 2016-01-11 11:49:05 -08:00
Evan Morikawa 1de3a47077 feat(composer): can outdent blockquotes allowing you to reply inline
Summary:
You can now break up blockquotes (as in quoted text areas) by pressing
"delete" at the start of a line. This allows you to reply inline.

Test Plan: new tests

Reviewers: bengotow, juan

Reviewed By: bengotow, juan

Differential Revision: https://phab.nylas.com/D2421
2016-01-11 14:46:20 -05:00
Juan Tejada f6579ceaa4 Fix misc errors that made the app crash 2016-01-11 11:39:14 -08:00
Ben Gotow 55f1c537e2 fix(quoted-text): Fix + test case for Sentry 8323, body el is quoted text 2016-01-11 11:14:34 -08:00
Ben Gotow a3d1287ce8 fix(notifications): Fix notification removal [Sentry 8957] 2016-01-11 10:56:17 -08:00
Ben Gotow f7420152df fix(readme): Fix broken links to examples #943 2016-01-11 10:29:57 -08:00
Ben Gotow a4b1e1b147 bump(version): 0.3.39 2016-01-11 09:59:05 -08:00
Juan Tejada 5158ab1e38 fix(injected-component): Correctly call methods to the injected instance
- Adds check to `_runInnerDOMMethod` to check if inner is an UnsafeComponent and
relay the call appropriately
- Removes duplicated logic from `_setRequiredMethods`
2016-01-10 16:25:31 -08:00
Ben Gotow bb9f9d4b84 fix(composer): Temporary patch for broken focus
Long term, we need to refactor this so that it's either entirely controlled or uncontrolled. Potentially use focusin?
2016-01-08 18:45:26 -08:00
Juan Tejada d265bf1248 fix(category-store): Fix issue with observables in CategoryStore
- Removes use of observables from category store and keeps a big cache
  of categories per account
- Upates Category Observables with new helper observables
- Updates CategoryPicker and AccountSidebarStore to use observables
- Misc fixes
2016-01-08 18:03:18 -08:00
Ben Gotow 373d224f0c fix(scroll-region): top:0 or height:0 are valid for scrollToRect [sentry] 2016-01-08 17:47:49 -08:00
Evan Morikawa 99f6749488 fix(composer): undo/redo now properly restores selection on new msg 2016-01-08 16:43:09 -08:00
Ben Gotow 2beeccdecd PreferencesStore pull current account from FocusedPerspective 2016-01-08 15:26:35 -08:00