Ben Gotow
71f1a3e315
fix(Atom): Wait to send window:loaded until new loading process has finished (broken because of animation blocks)
2015-09-02 16:49:13 -07:00
Ben Gotow
9c0eccd387
fix(notifications): Switch account when necessary to display notification, avoid using CategoryStore which may not be ready
...
Fixes T2318 and fixes T3448
2015-09-02 16:31:50 -07:00
Ben Gotow
32edaa3ac5
fix(metadata): publicid => publicId
2015-09-02 14:36:33 -07:00
Ben Gotow
502bb7c0b8
feat(spellcheck): Custom spellcheck powered by our DraftStore extensions API
...
Summary: New draft store extension that highlights misspelled words.
Test Plan: No test coverage yet
Reviewers: evan, dillon
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1972
2015-09-02 13:20:01 -07:00
Ben Gotow
62fbd61ede
fix(db): Run pragmas on all connections, not just worker one (which runs setup queries)
2015-09-02 12:31:38 -07:00
Evan Morikawa
442bcd99d1
test(api): add specs for nylas api
...
Summary: Specs for nylas api
Test Plan: edgehill --test
Reviewers: dillon, bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D1973
2015-09-02 12:22:20 -07:00
Ben Gotow
0ea3dfca62
fix(T3474): After authentication when main window already visible, close onboarding window
...
Summary: Fixes T3474
Test Plan: Run tests
Reviewers: dillon, evan
Reviewed By: dillon, evan
Maniphest Tasks: T3474
Differential Revision: https://phab.nylas.com/D1967
2015-09-02 11:02:18 -07:00
dillon
d7c2ce6319
fix(composer): hide participant email and show only name. fixes T3404.
...
Test Plan: manually tested. all tests remain green.
Reviewers: evan, bengotow
Reviewed By: bengotow
Maniphest Tasks: T3404
Differential Revision: https://phab.nylas.com/D1968
2015-09-01 16:44:07 -07:00
Ben Gotow
7826ed99f8
fix(iframe-resize): Subscribe to iframe window resize, adjust container height
...
Summary: Fixes T2095, iFrames resize when images load, when container is resized, etc.
Test Plan: Run tests
Reviewers: dillon, evan
Reviewed By: dillon, evan
Maniphest Tasks: T2095
Differential Revision: https://phab.nylas.com/D1964
2015-09-01 16:23:29 -07:00
Ben Gotow
7014a450ce
fix(db): Add index for draft count query, use sqlite timing profiler and log queries >100msec
2015-09-01 15:35:06 -07:00
Ben Gotow
434c5822a2
fix(specs): Lazily require CategoryStore to fix broken tests
2015-09-01 15:32:36 -07:00
Evan Morikawa
3773083908
fix(iframe): give each message a proper doctype
2015-09-01 14:57:58 -07:00
dillon
629ed5f7b2
fix(thread): thread.sortLabels() now ignores 'Sent Mail' and other unnecessary labels. fixes T3454.
...
Summary: NOTE: this ticket and this diff do not address turning the 'Important' label into a more user-friendly chevron. I created T3477 for that.
Test Plan: added more tests. however, seems like somebody merged some tests which are failing.
Reviewers: bengotow, evan
Reviewed By: evan
Maniphest Tasks: T3454
Differential Revision: https://phab.nylas.com/D1963
2015-09-01 14:47:22 -07:00
Ben Gotow
a366f13d9a
fix(db): Use recommended page-size, cache size. Allow 80MB in RAM cache
2015-09-01 13:35:30 -07:00
dillon
b44ac1e2db
fix(sidebar-contact): wrap long email. fixes T3359.
...
Summary: add a snippet of css
Test Plan: tested manually
Reviewers: bengotow
Maniphest Tasks: T3359
Differential Revision: https://phab.nylas.com/D1966
2015-09-01 12:40:53 -07:00
dillon
b66e2a22b6
fix(draft-list-sidebar-item): draft count renders correctly. fixes T3480.
...
Summary: I think I might've broken this when I fixed T3402, but I didn't realize it because I had zero drafts at the time, so this component didn't render for me.
Test Plan: tested manually
Reviewers: bengotow
Maniphest Tasks: T3402, T3480
Differential Revision: https://phab.nylas.com/D1965
2015-09-01 12:32:39 -07:00
Ben Gotow
ac96110f1f
fix(windows): Fix old references to windowManager
2015-09-01 12:14:15 -07:00
Evan Morikawa
e4a57aaf12
feat(github): add GitHub plugin
...
Summary:
Adding a simple GitHub plugin that shows a button on the thread view.
If we detect the "open in github" links, then we'll show the button on the
thread.
Test Plan: manual
Reviewers: dillon, bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D1959
2015-09-01 11:57:06 -07:00
Evan Morikawa
31714407f9
feat(composer): sanitizes and inlines CSS styles for replies and fwd
2015-09-01 11:53:38 -07:00
Ben Gotow
be697e42c7
fix(message-list): Roll back min width hiding reply buttons, etc. Just allow individual body iframes to scroll horizontally when necessary
2015-09-01 10:51:24 -07:00
Ben Gotow
b04f496a02
fix(loading): Initial bounce was missing from loading animation
2015-09-01 10:27:44 -07:00
Evan Morikawa
7ffaf6c17f
fix(sidebar): fix case when category comes back as null
2015-09-01 06:18:11 -07:00
Evan Morikawa
3ec33b938a
fix(mailto): fix incorrect calling of draft popout from mailto
2015-09-01 06:05:52 -07:00
Evan Morikawa
65f776e902
fix(specs): fix file upload specs
2015-08-31 18:37:45 -07:00
Evan Morikawa
13629f57dc
fix(preferences): add window title to preferences
...
Fixes T3458 Preferences panel shows up as "Electron" in Window menu
2015-08-31 17:25:33 -07:00
Evan Morikawa
550a7e0a8c
refactor(packages): move internal sidebar to own repo
...
Fixes T3425 Remove Nylas internal admin sidebar from default edgehill
2015-08-31 17:13:52 -07:00
Evan Morikawa
16c4376812
feat(composer): improve tab useage in composer
...
A `*` as well as a `-` will start a list.
If you tab anywhere in plain text, it will insert a tab character.
If your shift-tab anywhere in plain text, and the character just before
the cursor is a "tab" character, it will delete that last tab character.
Fix a bug whereby shift-tab and tab will indent/outdent from anywhere
inside of a list.
Fixes T3409
2015-08-31 16:55:01 -07:00
Evan Morikawa
cb72438270
fix(regex): allow "=" in valid email address
...
Fixes T3440 Email formatting validation bug
2015-08-31 15:48:39 -07:00
Evan Morikawa
760311f1fc
feat(work-window): give work window a standard toolbar
...
Fixes T3457 "Activity" window needs a close affordance
2015-08-31 15:43:47 -07:00
Evan Morikawa
93209c9f71
fix(sidebar): remove "Plugins" and consolidate sections
...
Fixes T3461
2015-08-31 15:38:08 -07:00
Evan Morikawa
d56d8daaf2
fix(drafts): fix illegal ID set
...
Fixes T3468
2015-08-31 15:21:41 -07:00
Evan Morikawa
6ac2a6b1be
fix(attachments): set attachment min-width
...
Fixes T3459
2015-08-31 15:03:17 -07:00
dillon
c059b51fe3
fix(account-sidebar): make folder and label names wrap elegantly. fixes T3402.
...
Summary:
WIP: changing the rest of items to make them look correct
fix last draft item in sidebar
add more padding
Test Plan: tested manually. all tests remain green.
Reviewers: evan, bengotow
Reviewed By: bengotow
Maniphest Tasks: T3402
Differential Revision: https://phab.nylas.com/D1943
2015-08-31 10:47:25 -07:00
dillon
b6bc5e1a01
fix(scroll-region): add min-width to scrollable message area. fixes T3442.
...
Summary: I wasn't sure how much the min-width should be. I cross-checked with Gmail and found that they set a pretty generous min-width. I felt 700px seemed comfortable.
Test Plan: Manually tested. All other tests remain green.
Reviewers: bengotow
Maniphest Tasks: T3442
Differential Revision: https://phab.nylas.com/D1954
2015-08-31 10:46:37 -07:00
Ben Gotow
a0aaadd91f
fix(file-uploads): Critical fix to bad method call to session.draft instead of session.draft()
2015-08-30 20:18:05 -07:00
Ben Gotow
873c9379f4
fix(file-uploads): Do not store the draft session and draft during upload
2015-08-30 20:17:16 -07:00
Evan Morikawa
a0307d4d88
fix(uploads): no more from picker & uploads use correct accountId
...
Test Plan: edgehill --test
Reviewers: dillon, bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D1955
2015-08-28 20:35:43 -04:00
Evan Morikawa
e639afae1e
fix(undo): properly scope composer keymappings for undo/redo
...
Summary: Properly scopes undo & redo key bindings to the composer
Test Plan: manual
Reviewers: dillon, bengotow
Reviewed By: bengotow
Maniphest Tasks: T3446
Differential Revision: https://phab.nylas.com/D1951
2015-08-28 18:59:00 -04:00
Ben Gotow
d0dcfb8359
fix(keyboard-cursor): Recent optimization broke keyboard cursor advancing fast
2015-08-28 14:34:56 -07:00
Ben Gotow
11dab9095a
fix(loading): Add nice text to our new loader
2015-08-28 14:24:17 -07:00
Evan Morikawa
7ad227cd9a
fix(spec): Stub correct method
2015-08-28 16:37:09 -04:00
Evan Morikawa
3908ba402d
feat(sync): Resume sync worker action from sidebar
2015-08-28 16:24:39 -04:00
Ben Gotow
944d6a8e1e
fix(send-draft): Update the draft rather so it's clientId is maintained, even if the ID has changed on send
2015-08-28 13:19:09 -07:00
Ben Gotow
3626beb294
fix(nylas-api): When receiving models, ignore changes that would make non-drafts into drafts
2015-08-28 13:04:40 -07:00
Ben Gotow
9247a41292
fix(specs): Future specs should stub DatabaseStore.run, not find/findBy
2015-08-28 12:41:56 -07:00
Ben Gotow
5e0ef3946c
fix(atom): Put displayWindow back - it's used in other places
2015-08-28 12:25:48 -07:00
Ben Gotow
08da848c34
fix(message-list): Use clientIds within the message-list for scrolling, etc. since IDs may change
2015-08-28 12:25:48 -07:00
Ben Gotow
912075a6f9
fix(model-observation): Watch for changes to objects with matching clientIds, since server id may be assigned
2015-08-28 12:25:48 -07:00
Ben Gotow
82f0ffd13c
fix(sending): Since we have a unique index on clientId, no need to delete draft after sending
2015-08-28 12:25:48 -07:00
Evan Morikawa
a0e64bf580
refactor(packages): Remove Edgeforce
2015-08-28 15:16:32 -04:00