Commit graph

2362 commits

Author SHA1 Message Date
Juan Tejada
4900df4768 fix(lint): Fix linter error in specs 2016-03-03 13:45:28 -08:00
Juan Tejada
f46502ad3e test(plugins): Add snooze and send later specs
Summary:
- Also refactors the code a bit for testability and maintainability
- Fixes #1515

Test Plan: - Unit tests

Reviewers: evan, drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2651
2016-03-03 12:38:42 -08:00
Ben Gotow
9b54d9cf31 fix(MessageContainer): Fix state, prevent from getting different messages. #1175
Summary:
This fixes a serious issue where drafts could appear to be sending if
they were located in the same index of the message list as a draft which was
previously sending.

Under the hood this was due to two bad programming choices:

1) State based on props in MessageContainer requires correct implementation of
   componentWillReceiveProps. This is definitely an anti-pattern.

2) Using item index rather than clientId as the key for items in the MessageList
   caused containers to be given a different message prop when one was inserted,
   rather than just shifting the existing ones down and inserting a new one.

Test Plan: Not sure how to test this really...

Reviewers: drew, juan

Differential Revision: https://phab.nylas.com/D2673
2016-03-03 12:10:03 -08:00
Ben Gotow
68ab8e22c9 fix(drafts): Lock drafts when they're deleted so they can't be revived by deltas
Summary:
When we delete drafts, they can sometimes come back because we receive deltas about them,
find that they're not in the cache, and re-save them.

This diff fixes that by permanently incrementing the optimistic change count, which was also do
to prevent deltas from changing threads while we're in the middle of a request that will change
them further. (This may not actually be necessary anymore, because we'd ignore the delta anyway
due to it's out-of-date version?)

Test Plan: Run a couple new tests

Reviewers: drew, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2665
2016-03-03 12:09:16 -08:00
Jackie Luo
83fa692bb5 Bump version for node-emoji 2016-03-02 18:58:07 -08:00
mbilker
b32dc0d7fc fix(startup): remove beta references 2016-03-02 17:47:47 -08:00
mbilker
887db8d8ea fix(launch): convert Atom's launch script for N1
Addresses #411

The `N1.sh` launch script fails to account for running from
`/usr/{local/}bin/nylas` where it would throw an error saying
it couldn't find the electron binary.

The Atom launch script works just fine and takes that into account.
The installed launch script here is a reflactored Atom launch script
that properly accounts for running the `nylas` executable and locates
the actual binary accordingly.
2016-03-02 17:47:47 -08:00
Evan Morikawa
50ca8136b7 fix(lint): fix linter error in search-match 2016-03-02 16:24:37 -08:00
Evan Morikawa
572498aa68 fix(composer): fix minor spacing issue on popout composer 2016-03-02 16:06:40 -08:00
Evan Morikawa
b727fe374d fix(find-in-thread): minor rename fixes 2016-03-02 15:00:01 -08:00
Evan Morikawa
10e0fcc965 feat(find-in-thread): add the ability to find in a thread
Summary: Find in thread

Test Plan: todo

Reviewers: bengotow, juan

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2660
2016-03-02 14:46:27 -08:00
Ben Gotow
a53e72f542 fix(hidden-messages): Address diff feedback from @jstejada 2016-03-02 10:28:32 -08:00
Ben Gotow
f5ee557e2e feat(hidden-messages): Filter trash/spam messages. Fixes #1135
Summary:
By default, the messages in a thread are now filtered to exclude
ones moved to trash or spam. You can choose to view those messages by clicking
the new bar in the message list.

When you view your spam or trash, we only show the messages on those threads
that have been marked as spam/trash.

Test Plan: Run a couple new tests

Reviewers: juan, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2662
2016-03-02 10:05:17 -08:00
Ben Gotow
338ef0d56e rename(specs): A few more task renames 2016-03-01 17:34:36 -08:00
Ben Gotow
58647542d3 rename(tasks): Add the -task suffix to all tasks 2016-03-01 17:29:23 -08:00
Ben Gotow
0caa46bdab test(send): Improved coverage of metadata logic, file uploads
Summary: Just new specs. Tested by manually breaking lots of things in SendDraft

Test Plan: Run new tests

Reviewers: juan, drew, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2649
2016-03-01 17:24:37 -08:00
Evan Morikawa
66d1fe67e8 fix(account): re-add token if a new one comes in
Summary: fix(account): allow users to reconnect accounts if auth has failed

Test Plan: manual

Reviewers: bengotow, juan

Differential Revision: https://phab.nylas.com/D2663
2016-03-01 16:02:20 -08:00
Evan Morikawa
358b2743e1 fix(account): re-add token if a new one comes in 2016-03-01 15:33:02 -08:00
Ben Gotow
c5a80d807d Merge pull request #1469 from e2corporation/readme-custom-envs
README Update
2016-03-01 14:50:35 -08:00
Ben Gotow
c4c18fc051 Merge pull request #1520 from mbilker/lint
Correct eslint errors from Travis
2016-03-01 14:50:10 -08:00
mbilker
a1b9775b6d lint(*): correct eslint errors, warnings still exist
There are warnings in `spellcheck-composer-extension.es6` for the `while (true)`
loops.
2016-03-01 10:58:29 -05:00
Jackie Luo
876aea0ad9 fix(composer-emojis): Insert emoji on tab, fixes #1511 2016-02-29 20:46:30 -08:00
Ben Gotow
94badcda15 es6(*): convert 20+ source files used in example packages to ES2016
There could be a few lurking bugs. Please test!
2016-02-29 18:47:22 -08:00
sdewith
c5a46e5e3f Add Mail.app keybinds
Added jumping, search focus, select, star and archive keybinds to Apple
Mail keymap
2016-02-29 12:17:14 -08:00
Ben Gotow
7110fc33bb Revert "bump(electron): 0.36.9. Fixes #911"
This reverts commit 57577b5afa.
2016-02-29 10:57:09 -08:00
Juan Tejada
77138c7aef fix(specs): Update spy on persistModel to reflect actual behavior 2016-02-29 10:37:48 -08:00
Ben Gotow
57577b5afa bump(electron): 0.36.9. Fixes #911 2016-02-29 10:36:30 -08:00
Julien Chinapen
0039c1fc62 Example Update
Update code snippet to show `env: custom`

Signed-off-by: Julien Chinapen <j.c@shogun.io>
2016-02-27 11:40:39 -05:00
Julien Chinapen
03baa579d6 README Update
Updating Contributing guidelines to make note of the `env: custom` option so that a Sync Engine in a local environment may be accessed on an alternate IP.

Also APIRoot must contain quotes around the URL otherwise a config validation will be thrown.

Signed-off-by: Julien Chinapen <j.c@shogun.io>
2016-02-27 08:50:04 -05:00
Ben Gotow
9c81b153f8 fix(aliases): Work window should reload when an alias is added 2016-02-26 18:06:40 -08:00
Ben Gotow
3072246d8e temp(onboarding): Remove checkbox for option not yet on prod 2016-02-26 16:49:46 -08:00
Ben Gotow
91b45fd2ae bump(version): 0.4.10 and changelog 2016-02-26 16:45:21 -08:00
Ben Gotow
68d89504f7 fix(plugin-auth): Once plguin auth succeeds, don't do it again 2016-02-26 16:39:45 -08:00
Juan Tejada
28b995e19c fix(templates): Open manage templates from composer window
- Fixes #1433
- Make Action.openPreferences global
2016-02-26 15:26:26 -08:00
Drew Regitsky
3327fc4cff fix(message-controls): add accountId to debug values copied to clipboard 2016-02-26 15:13:33 -08:00
Ben Gotow
b92e4fa07b fix(threads): Right-align the timestamps in the thread list 2016-02-26 15:00:56 -08:00
Ben Gotow
04f93bd055 💄(print): Fix #1425 2016-02-26 14:40:16 -08:00
Ben Gotow
18677e51a6 fix(config): Store cursors with sync state, avoid constant config.cson writes
Summary:
Previously we were storing sync cursors in config.cson. They were by
far the most frequently updated piece of data in config. To make things worse,
all the writing was happening in the worker window - the main window was just
seeing the changes on disk and reloading.

I believe there's an edge case which causes the main window to read the config
file when it's mid-write and empty. This causes the accounts array to become
empty in the AccountStore and lots of downstream issues. It's also then possible
for the main window to write a config change of it's own and empty the file
permanently.

Test Plan: A few new tests to make sure this is backwards compatible.

Reviewers: juan, evan

Reviewed By: juan, evan

Differential Revision: https://phab.nylas.com/D2642
2016-02-26 13:52:19 -08:00
Ben Gotow
114a7b2740 bump(submodule): theme and plugin installation reporting fixes 2016-02-26 13:28:42 -08:00
Drew Regitsky
d3d4978dbd fix(message-controls): update email address for reporting 2016-02-26 12:29:11 -08:00
Drew Regitsky
0e522ec789 feat(message-controls): Option to copy message IDs/metadata to clipboard 2016-02-26 12:26:20 -08:00
Ben Gotow
26b8f22a31 fix(402s): Handling of Message Rejected, error messages with more detail 2016-02-26 11:40:59 -08:00
Juan Tejada
0b5afaad71 fix(lint) 2016-02-26 11:24:00 -08:00
Juan Tejada
8e382f8c26 fix(aliases): Fix regression to properly create/update/remove aliases
- This fixes #1428
- Add specs
2016-02-26 11:01:01 -08:00
Ben Gotow
f766c73430 fix(focus): Focusing quickly enough can throw. Sentry #14942 2016-02-26 10:55:31 -08:00
Evan Morikawa
9ac23a22fe fix(tray): windows tray opens window on click 2016-02-26 09:28:45 -08:00
Evan Morikawa
b11c5b62b7 Merge pull request #1441 from mbilker/fix-tray-icon
Rename tray icon files for Windows and Linux
2016-02-26 09:20:08 -08:00
Michael Grinich
6ee7bfb024 Merge pull request #1405 from P0WW0W/master
Less is More Theme
2016-02-26 08:45:58 -08:00
mbilker
1a5766114e lint(system-tray): code style consistent with rest of file 2016-02-26 11:37:20 -05:00
mbilker
38dce709e2 fix(system-tray): rename icon files for Windows and Linux 2016-02-26 11:23:53 -05:00