Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2024-11-12 04:25:31 +08:00
Code Issues Projects Releases Packages Wiki Activity
2650 commits 31 branches 65 tags 142 MiB
Commit graph

110 commits

Author SHA1 Message Date
Evan Morikawa
2859baa134 fix(contact): fix bug where malformed contacts threw an error 
Summary:
Also added tests to catch the case
Fixes T4290

Test Plan: new tests

Reviewers: bengotow

Reviewed By: bengotow

Maniphest Tasks: T4290

Differential Revision: https://phab.nylas.com/D2153
 2015-10-12 14:03:39 -04:00
Evan Morikawa
abc4a6116e fix(specs): Fix intermittent async error and max event listener leak 
An absolute ContactStore spec was causing the listener leak by
re-initializing the store and not cleaning it up.

Intermittent theme manager failing spec might be caused due to timing of
the theme activation
 2015-10-09 15:42:37 -07:00
Ben Gotow
7ad57680ca fix(contacts): Emails only valid if the entire string is the email. (Sentry 2991) 2015-10-09 14:30:08 -07:00
Ben Gotow
9107bc325e fix(specs): ContactStore spec fixes for new contact ranking support 2015-10-09 13:42:24 -07:00
Evan Morikawa
dfab406484 Fix contact ranking and add tests 
Summary:
Contact ranking is now tested.

There was a bug whereby the RankingsJSONCache would only update in the
workerwindow. This regressed when Contact ranking moved exclusively into
the main window and separate composer windws requested rankings via ipc

Test Plan: New tests

Reviewers: drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2134
 2015-10-09 09:31:52 -07:00
Ben Gotow
ebdf06b183 fix(attachments): When downloads fail, don't resolve to chained actions 
Summary: Fixes Sentry 3319 and 3303

Test Plan: Run three new tests

Reviewers: dillon, evan

Reviewed By: dillon, evan

Differential Revision: https://phab.nylas.com/D2118
 2015-10-05 17:57:24 -07:00
Ben Gotow
a8228238d3 fix(specs): Clean up spec failures due to hot fixes prior to launch 2015-10-05 16:45:30 -07:00
Evan Morikawa
2a7496642c fix(specs): specs run clean 2015-10-02 18:44:12 -07:00
Evan Morikawa
4651fe5350 fix(sounds): make sounds listen to config options 
Summary: Fixes T3887

Test Plan: new specs

Reviewers: bengotow

Reviewed By: bengotow

Projects: #edgehill

Maniphest Tasks: T3887

Differential Revision: https://phab.nylas.com/D2104
 2015-10-02 17:04:15 -07:00
Evan Morikawa
57fef805cd refactor(spec) move spec-nylas to spec 2015-10-01 21:39:44 -07:00