- Upgrade node-sqlite3 from patched 3.0.2 to mainline 3.1.0
- Upgrade Electron to 0.30.8: NOTE: This is the latest in the 0.30 line.
The 0.31+ line did a Chrome upgrade that we want to save for a later
day. We've had a history of serious instabilities with these upgrades
and are doing them conservatively
- Upgrade coffee-script from 1.9.0 to 1.10.0
- Package updates in /build folder
+ Starred view
+ All new spellcheck!
+ Loading screen
+ Lots of bug fixes!
Fixes:
- Forwarding messages with files
- Mode toggle now opens/closes sidebar
- Min-width is more appropriate
- Mixpanel analytics fixes
- Better draft sending errors, timeout errors
- Improvements to quoted text display, more edge cases handled
- Mailto: links that launch the app work properly
- Fix for database busy errors
- Message items resize when their container is resized
- Message items now populate HTML doctype, fixing some rendering issues
- We now sanitize HTML in replies and forwards to avoid potential issues
- Valid email addresses can now contain `=`
- Folder and label names in the sidebar wrap nicely
- Undo/redo in the composer no longer triggers task undo/redo
- EdgeForce is now in it's own repository
- Worker process moves expensive syncing out of hte main window
- 404s from the server correctly purge items from the database
- Lots more minor changes!
Summary: Mixpanel API misuse makes me sad.
Test Plan: No tests, but easy to check with Mixpanel.com
Reviewers: dillon, evan
Reviewed By: dillon, evan
Differential Revision: https://phab.nylas.com/D1978
- Multiple account support!
+ Known issue: Unread badge shows only currnetly selected account
+ Known issue: Canceling add account flow quits the app
- You can now create bullets and lists in the composer
- Fix for mail sent yesterday appearing to be sent "now"
- Third-party plugins can now define tasks and database models
Summary:
This diff replaces the Namespace object with the Account object, and changes all references to namespace_id => account_id, etc. The endpoints are now `/threads` instead of `/n/<id>/threads`.
This diff also adds preliminary support for multiple accounts. When you log in, we now log you in to all the attached accounts on edgehill server. From the preferences panel, you can auth with / unlink additional accounts. Shockingly, this all seems to pretty much work.
When replying to a thread, you cannot switch from addresses. However, when creating a new message in a popout composer, you can change the from address and the SaveDraftTask will delete/re-root the draft on the new account.
Search bar doesn't need to do full refresh on clear if it never committed
Allow drafts to be switched to a different account when not in reply to an existing thread
Fix edge case where ChangeMailTask throws exception if no models are modified during performLocal
Show many dots for many accounts in long polling status bar
add/remove accounts from prefs
Spec fixes!
Test Plan: Run tests, none broken!
Reviewers: evan, dillon
Reviewed By: evan, dillon
Differential Revision: https://phab.nylas.com/D1928
Features:
- Preferences! You can now change all kinds of things from Menu > Preferences, including:
+ Key binding sets (Gmail, Outlook, Mail.app)
+ Theme (light or dark)
+ Mark-as-read delay
+ Attachment downloading policy
+ Sounds and notifications
+ Default reply behavior
- Layout and theme are now remembered when you re-launch Nylas Mail
- You can now star the message under the keyboard cursor by pressing 'S'
Performance:
- Creating drafts is now much faster on long threads
Fixes:
- "Hover and Archive" is now displayed correctly
- Signing in with an email with capitalization ("BEN@Nylas.com") no longer breaks subtle things
- Messages sent yesterday are now shown with relative time (2:31PM, 12 hours ago)
- NylasSyncWorker now backs off when it encounters network failure
- On Windows, the database is deleted properly when you log out
- Archiving now properly sends mail to All Mail in Gmail
- Images inside some emails now render without becoming distorted
- Mailto link handling is now case-insensitive
- Perf:
+ Mail actions like starring and changing folders are significantly faster
+ Messages and drafts load faster in large mailboxes thanks to better indexing and query management
+ Ingesting changes from the Nylas API no longer floods the database with queries
- Features:
+ Emails with forms and other interactive elements are now supported
+ Drafts now have a blue focus ring, which makes it easier to see keyboard focus
+ Contact search now matches email domains
+ Command-option-F now highlights the search bar
- Bug fixes:
+ Downloading large attachments will no longer crash the app
+ Window focus / blur state is now correctly reflected in the toolbar
+ Emails with some specific image tags now render with the correct height
+ Undoing star/unstar changes to a group of threads now restores previous state correctly
+ The 'send' animation in the message list is now glitch-free
+ Thread participant parsing handles more edge cases
+ Loading "dots" no longer cover the thread list in some scenarios
+ Rapidly creating and destroying drafts no longer causes React errors
- Threads sort the same way they do in Gmail, by "last message received"
- We now use native SQLite bindings, and SQLite 3.8.11.1, which is 22% faster
- We now display an affordance for undoing changes to threads
- Scroll handling in the message list is much better
- Contact chips have been overhauled in the composer, and are now editable
- Contact autocompletions are better, and based on frequency of use
- Messages wrap better in many scenarios
- More than 20 bug fixes!
We now have more than 1,000 specs for Nylas Mail.
- Labels and folders!
+ Multicolor labels for Gmail users, folders for everyone else
+ View and remove labels in message view
+ Move mail into labels or folders using the new picker
+ Move mail into labels or folders in the sidebar via drag and drop
+ "Folder" in expanded message headers
- New icons and style tweaks
- Tracking pixel detection
+ We no longer "view" tracking pixels in your sent mail
- React Component hot-loading
- Hide Sidebar button (design is temporary)
- Draft syncback to the Nylas API
- Today view has been sunset for now
- Quoted text stripping has been rebuilt
+ No longer removes quoted text between inline responses
+ Now supports more quoted text formats
- Lots of bug fixes!
Summary:
# Conflicts:
# static/components/tokenizing-text-field.less
Wat no
Test Plan: Tested with ci build
Reviewers: evan
Reviewed By: evan
Maniphest Tasks: T1216
Differential Revision: https://phab.nylas.com/D1804
Summary:
- Remove thread_participants prop, we don't use them anywhere and the underscore-case is ugly.
- Move autolinker into extension, update autolinker to 0.18.1 for phone number support
- document message.coffee, add isFromMe()
- Add tracking pixel extension that removes pixels from mail you *send*. Maybe more features later.
Test Plan: Run 1 new test! (woo...)
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1787
Summary:
There are now two objects, Folders & Labels. These inherit from `Category`
(that's what Eben said they were using on the backend).
There are two separate tasks.
1. MoveToFolderTask
2. ApplyLabelsTask
It turns out that the semantics between the two are quite different.
The reverse operation for moving to a folder is a bit tricky.
As of 7-8-15, the Tasks are pretty much complete. I need to write tests
for them still and do some manual testing in the client.
Test Plan: Writing specs
Reviewers: bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D1724
React-dnd is a nice library but it assumes it's going to be the only thing managing your drag and drop in the entire app. It also hides the underlying dataTransfer object so it's difficult to implement native drag and drop behaviors other than for Files and Urls, which they special-case.
Implementing it manually really isn't hard, and we can do things like attach a text/plain version of contact data to the contact drag.
Fixes T2054
New In This Release:
- Reply/Reply-All keyboard shortcuts now update existing draft rather than creating another new one.
- Extensions can adjust new drafts before they're displayed
- Signatures extension! (signatures still need to be setup manually)
- Pristine drafts are discarded correctly when you leave a thread in two-pane mode
- Fix for "destroy draft" task failing
- Fix for "double sending" issue
- Upgrade to Electron 0.29.2
- New "Show / hide quoted text" control
- Bug fixes
Summary:
Saving only 50 models at a time instead of 100 fixes a reproducible issue with database errors during initial sync on my machine. With 100, it reports "unexpected ; on line 2123..." during the query.
Only the main window should update the unread badge count.
Test Plan: Tests still pass and it seems like everything is still functional.
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D1736
Summary:
WIP. The app launches and works for me. I still need to fix the tests
just the DB ones though :D
I changed the `DatabaseProxy` into a `DatabaseConnection` object. It will
request a fully instantiated databse from the backend Browser.
If we're already setup, it'll connect straight to the existing DB.
If we're not setup, then it'll create a new database and run the inital
schema migration on it. The `_createNewDatabase` promise won't resolve
until the migration has run.
Until we add in a more sophisticated migration system and get rid of the
stupid `modelClassMap` that's shoved in `Utils`, I'm passing in a series
of `_setupQueries()` to get everything started.
The `DatabaseConnection` is also the one responsible for queuing up
queries until the DB is fully populated and ready to go.
We actually get a lot of queries before we're setup because a lot of
Stores will make DB requests on `require` in their `constructor` or `init`
methods. (remember all the times we call `_populateStore` in `init`).
Now those queries are aggregated by the `DatabaseConnection` and then
executed sequentially.
Our methods like `persistModel` now resolve only after both the queries
have completed AND their corresponding `triggerLater` has completed as
well.
Test Plan: in progress
Reviewers: bengotow
Reviewed By: bengotow
Differential Revision: https://phab.nylas.com/D1688
