Commit graph

2463 commits

Author SHA1 Message Date
Ben Gotow c76582194a rm(autolinker): Use our own very simple autolinker
Summary:
Autolinker is a great open source project but it attempts to parse HTML with regexp, is quite slow, and hangs on specific emails https://github.com/nylas/N1/issues/1540

This is super bad, and also super unnecessary. I think this should do the trick.

Note: I changed the urlRegex in our Utils to be much more liberal. It now matches anything that looks like a URL, not just things with the http:// and https:// prefixes. It's used in the LinkEditor and onboarding screen (detecting auth errors with urls) and I think it should be ok?

Test Plan: Need to write some tests

Reviewers: evan, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2725
2016-03-14 12:30:54 -07:00
Juan Tejada 1e765a6b62 fix(acct-menu): Add option to add account from context menu 2016-03-14 11:22:52 -07:00
Juan Tejada 938933fc1e fix(specs) 2016-03-14 11:22:42 -07:00
Juan Tejada 1e567973c4 fix(mail-labels): Don't display sent label
Reference #1671
2016-03-14 11:04:45 -07:00
Ben Gotow 96c70368c4 fix(spellcheck): Enables spellcheck menu for basic inputs (#1600)
Summary: Just moves some code so we can easily attach spelling menus to the basic inputs.

Test Plan: Updated existing tests

Reviewers: juan, drew

Reviewed By: drew

Differential Revision: https://phab.nylas.com/D2721
2016-03-14 10:23:57 -07:00
Ben Gotow 53037b9918 Merge pull request #1648 from Eldorado234/patch-2
Fixed text overflow in phishing detection indicator
2016-03-14 10:09:21 -07:00
Michael Grinich a8fe79cdda use bullets instead of checkboxes 2016-03-13 18:03:36 -07:00
Michael Grinich 8e41a2b3f2 add hiring note 2016-03-13 17:03:33 -07:00
Jackie Luo 6e9384792a 🎨(themes): Fixes Windows button UI issues in #1649 2016-03-12 11:43:49 -08:00
Jackie Luo a91add4523 Merge pull request #1632 from DavidChouinard/extraneous-scrollbar-fix
Fixes scrollbar display when content is not scrollable
2016-03-11 17:31:19 -08:00
Jackie Luo 3068a08de5 fix(themes): Add classes for toolbar elements 2016-03-11 16:55:28 -08:00
Evan Morikawa 9cbe002a8b fix(sidebar): keep trying on 202s
Also fixed a bug where the email could come back with different
capitalization causing a cache miss
2016-03-11 16:27:04 -05:00
Evan Morikawa 5ecc67b42b fix(sidebar): add info@ to blacklist 2016-03-11 16:01:29 -05:00
Jackie Luo 4c3ceba901 update(readme): Streamline plugin lists 2016-03-11 11:43:52 -08:00
Ben Gotow 43a3646cd3 fix(message-extension): Exception in base class 2016-03-11 11:35:49 -08:00
Ben Gotow 797c043802 fix(menus): Nylas => Nylas N1 2016-03-11 11:35:49 -08:00
Simon Seyer 9b14c551e2 Fixed text overflow in phishing detection indicator 2016-03-11 20:33:06 +01:00
Jackie Luo 20b270edba update(readme): Add bundled versus community packages 2016-03-11 11:26:49 -08:00
Jackie Luo f7f39e74ce fix(themes): Add quick fixes for Ubuntu 2016-03-11 11:02:02 -08:00
Jackie Luo ea912f5690 Merge pull request #1629 from ahmedlhanafy/master
Added Ubuntu theme to the internal packages
2016-03-11 10:59:30 -08:00
Ben Gotow 5d539ce75b Merge pull request #1645 from Eldorado234/patch-1
(darkside) Fixed alignment of message headers
2016-03-11 10:24:26 -08:00
Simon Seyer 6d85e1785b Fixed alignment of message headers
like the phishing indicator.

Before this change: http://pasteboard.co/2bUg8PU9.png
After: http://pasteboard.co/2bUj2Bmz.png
2016-03-11 19:07:52 +01:00
Ben Gotow 34fd39962f bump(version): 0.4.14 and changelog 2016-03-10 19:09:00 -08:00
Drew Regitsky 6efaf6220a fix(templates): fix a null check bug in template contentedtable ext 2016-03-10 19:06:15 -08:00
Juan Tejada 70b425e5de fix(mail-rules): Prevent from adding locked categories 2016-03-10 19:01:34 -08:00
Drew Regitsky 071a58e355 fix(regexp-utils): Also update the regex101 link with test cases 2016-03-10 18:43:02 -08:00
Drew Regitsky a41844c38d fix(regexp-utils): Fix urlLinkTagRegex bug
Regex was missing a `?`, so consumed all <a> tags on a single line. Fixed
to be non-greedy.
2016-03-10 18:41:01 -08:00
David Chouinard d0baf878f5 Ensure scroll bar state is updated on content change 2016-03-10 18:37:45 -08:00
David Chouinard 3396f4a46e Don't show scrollbars if content is not scrollable 2016-03-10 17:59:06 -08:00
Ahmed Magdy cad18a0d98 Added Ubuntu theme to the internal packages 2016-03-11 03:50:19 +02:00
Juan Tejada 533ffd683e fix(snooze): Fix getter for inbox category in when moving to snooze 2016-03-10 17:46:23 -08:00
Ben Gotow b14a1a14e4 fix(plugin-auth): POST returns 200, no response body 2016-03-10 17:34:26 -08:00
Juan Tejada f313cc40f6 fix(lint): Fix in MailLabelSet 2016-03-10 17:27:51 -08:00
Ben Gotow 7c2fd2a91b fix(labels): Do not re-use mail labels if they're removable 2016-03-10 17:08:42 -08:00
Jackie Luo d28c79fc75 🎨(theme-picker): Order internal themes and update theme names 2016-03-10 16:37:06 -08:00
Juan Tejada 1218109282 fix(change-labels-task): Update label sets after modelifying 2016-03-10 16:26:25 -08:00
Ben Gotow 038032d68e fix(bodies): Message with empty string body showed loading forever 2016-03-10 16:13:17 -08:00
Ben Gotow c296e2e1d4 fix(sync): Do not paginate /metadata unless pluginsSupported 2016-03-10 16:03:36 -08:00
Evan Morikawa a69d918c0f fix(sidebar): return valid person to prevent cache miss 2016-03-10 18:49:00 -05:00
Juan Tejada c118c99d73 fix(sent): Do not allow sent or drafts to be modified
- Specifically, when dragging from the sent perspective, we should not
  allow the sent label to be removed.
- If moved to trash or spam, `all mail` will be correctly removed from
  the thread, but it will keep sent label
- Show sent MailLabel on the threads
2016-03-10 15:44:53 -08:00
Evan Morikawa ea98cb8388 fix(sidebar): change optional bit in package 2016-03-10 18:40:26 -05:00
Evan Morikawa 69d1b10508 fix(sidebar): don't show nulled profiles 2016-03-10 18:32:37 -05:00
Ben Gotow 04492c06c7 fix(messages): Replace calc with margin to make plugin styling easier 2016-03-10 15:31:05 -08:00
Ben Gotow 3888c0c510 fix(labels): Labels should not show "X" in wide mode 2016-03-10 15:31:05 -08:00
Jackie Luo 688582bf57 🎨(theme-picker): Adjust styles 2016-03-10 15:18:57 -08:00
Evan Morikawa 5dbef230a3 fix(sidebar): explicitly detect 202 and cache null people 2016-03-10 18:16:32 -05:00
Ben Gotow e8e4761e45 fix(github): Correct minor issue during ES6 conversion 2016-03-10 14:31:50 -08:00
Ben Gotow 0fb6d4c401 fix(remove-from-view): Missing invocation for non-Gmail 2016-03-10 14:25:28 -08:00
Jackie Luo 4d7f515090 feat(plugins): Move uninstall from theme picker to plugins tab
Summary: Move uninstall functionality to the plugins tab in preferences.

Test Plan: Tested locally.

Reviewers: bengotow, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2716
2016-03-10 14:16:07 -08:00
Juan Tejada f12896d54f fix(gmail-labels): Constraint so threads always belong to all,spam or trash
Summary:
- In Gmail all threads /must/ belong to either All Mail, Trash and Spam, and
  they are mutually exclusive, so we need to make sure that any add/remove
  label operation still guarantees that constraint
- Update ChangeLabelsTask to modify the set of labels to add and remove
  based on this rule
- Update tasksFor archiving, moving to trash and moving to spam so they
  don't affect any other labels in the thread, as gmail does.
- Removing from view /will/ remove any current labels, but will also
  move between all mail and trash as needed
- Remove Inbox, Trash and Spam from the CategoryPicker, as Gmail does

Test Plan: - Unit tests

Reviewers: drew, evan, bengotow

Reviewed By: drew, evan, bengotow

Differential Revision: https://phab.nylas.com/D2715
2016-03-10 14:13:31 -08:00