Commit graph

1967 commits

Author SHA1 Message Date
Ben Gotow
8f13b71403 fix(notifs): Make sure notifs always have thread references
Summary:
This started as a fix to https://sentry.nylas.com/sentry/edgehill/group/2970/, which was caused by `threads[msg.threadId]?.categoryNamed('inbox') isnt null`, because `undefined isnt null`.

Then I realized that we batch "incoming" messages and threads arbitrarily, and the reason this happened is because the thread and message were split into different delta updates. Previously, notifications would just have been skipped.

Now we call `_onNewMessagesMissingThreads` when threads cannot be found for new messages, and then try to find the threads again in 10 seconds. If we can find them, we simulate a delta call and run them back through the processor. It would have been simpler to call `_onNewMailReceived` again directly, but I want to be 100% sure we never create infinite loops.

Test Plan: Run new tests

Reviewers: evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2188
2015-10-28 16:55:35 -07:00
Evan Morikawa
d0212c3dd9 fix(drafts): only syncback every 30 seconds instead of 5 seconds
This will help prevent API errors from causing multiple drafts to appear
2015-10-28 19:51:46 -04:00
Evan Morikawa
985a8b55fe fix(ui): better unread count box
Smaller box that sits next to item.
Drafts is now no longer a strong color
Fixes T3535
2015-10-28 18:50:04 -04:00
Evan Morikawa
ede7eda3c4 fix(unread): can mark message as unread in split mode
Summary: Fixes T4835

Test Plan: new tests

Reviewers: bengotow

Reviewed By: bengotow

Maniphest Tasks: T4835

Differential Revision: https://phab.nylas.com/D2205
2015-10-28 17:50:07 -04:00
Ben Gotow
f7e646714f changelog: 0.3.20 release notes 2015-10-28 14:38:48 -07:00
Ben Gotow
6bbe9308cf fix(notifications): Buttons always triggered default action 2015-10-28 10:47:44 -07:00
Ben Gotow
339da554b0 fix(cibuild): unlinkSync => rmdirSync 2015-10-27 18:45:59 -07:00
Ben Gotow
a9bf2a39fe fix(cibuild): apm needs dependencies, fix for npm3 2015-10-27 18:29:14 -07:00
Ben Gotow
19363d94dd bump(version): 0.3.20 2015-10-27 18:09:49 -07:00
Ben Gotow
5e2282a2a0 fix(bootstrap): Always use npm3 in ./build to install apm 2015-10-27 17:04:14 -07:00
Ben Gotow
edaf751c3b feat(changelog): Link to changelog before and after updates
Summary: Link to the changelog, and add a new notification which appears after updates are installed

Test Plan: No tests to see here..

Reviewers: evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2201
2015-10-27 16:48:05 -07:00
Ben Gotow
08e2e7581a fix(onboarding): Check code format before hitting API 2015-10-27 16:43:07 -07:00
Ben Gotow
43a61d2471 rm(aws-sdk): Ship logs via request, eliminate aws-sdk 2015-10-27 16:35:38 -07:00
Ben Gotow
848fa10dee ⇧(npm): Move to NPM3 to shorten paths on Win32 2015-10-27 16:23:12 -07:00
Ben Gotow
0ff48ca9a6 rm(composer): Dead code related to Scribe / Bower 2015-10-27 11:38:39 -07:00
Ben Gotow
96bbbb6904 Create CHANGELOG.md 2015-10-27 11:36:40 -07:00
Ben Gotow
43c43a6bf5 fix(search): New X, focus styling for search
Fixes T3485
2015-10-27 11:28:11 -07:00
Ben Gotow
69e4ba32ac fix(files): Not-yet-downloaded files can be opened via double click
Fixes T4840
2015-10-27 11:05:33 -07:00
Ben Gotow
703b9decfa fix(onboarding): Request /status/ to avoid 302 2015-10-27 10:50:18 -07:00
Brett Gerry
1400f3e6e8 Add quotes to account token key in example config.cson 2015-10-26 17:13:05 -07:00
Ben Gotow
c7cf2f1e18 fix(workspace): Remember whether sidebar is hidden #190 2015-10-26 10:51:30 -07:00
Ben Gotow
2ddfb1595a fix(prefs): Fix overflow of account names. #175 2015-10-26 10:47:47 -07:00
Ben Gotow
09ed1ea415 fix(prefs): Guard against null account in preferences window 2015-10-26 10:47:47 -07:00
Michael Grinich
69872ca1a6 note about libgcrypt11 2015-10-24 18:05:20 -07:00
Ben Gotow
1a3b4e7106 fix(fullscreen): On Mac OS X, green window control defaults to fullscreen 2015-10-23 18:30:47 -07:00
Ben Gotow
de7d1bbaa0 fix(atom): Prevent cache collisions with Atom 2015-10-23 17:03:41 -07:00
Ben Gotow
10e6c864cb bump(version): 0.3.19 2015-10-23 16:05:48 -07:00
Ben Gotow
5c5c1e98c1 fix(drafts): Draft selection / deletion fixes 2015-10-23 16:04:27 -07:00
Ben Gotow
528224a184 fix(sidebar): Better disclosure triangle position on multiline labels / folders 2015-10-23 16:04:27 -07:00
Evan Morikawa
7711ec533e fix(onboarding): fix add account button width 2015-10-23 15:21:58 -07:00
Ben Gotow
992b90d969 fix(message-list): Clicking Archive or Trash should pop back to the thread list 2015-10-23 15:21:37 -07:00
Ben Gotow
e9141a44ec fix(plugins): Packages => Plugins in a few more places 2015-10-23 15:14:44 -07:00
Evan Morikawa
cc95662adc fix(win): composer and input styles 2015-10-23 15:04:35 -07:00
Ben Gotow
aeb756cb27 fix(undo-redo): Fix "undo" button clickability, improve animation 2015-10-23 15:03:12 -07:00
Ben Gotow
cb50b3700b fix(list): Additional focused CSS changes 2015-10-23 14:55:07 -07:00
Ben Gotow
e641d78d27 fix(change-folder): Show folder name when moving to folder 2015-10-23 14:50:39 -07:00
Ben Gotow
29fdd3024a fix(threads): Show the archive button in the bulk action bar 2015-10-23 14:50:39 -07:00
Evan Morikawa
45466a18b0 fix(archive): can archive and trash from focused message 2015-10-23 14:49:29 -07:00
Evan Morikawa
2fd95fab28 fix(docs): fix broken link 2015-10-23 13:41:29 -07:00
Evan Morikawa
bbf42531cf feat(windows): updated docs and fix for building on 64-bit 2015-10-23 12:55:44 -07:00
Ben Gotow
096e829f33 fix(list): Incorrect snippet color on unread selected threads in narrow mode 2015-10-23 12:54:02 -07:00
Ben Gotow
a84e1b3db4 fix(keymaps): Reveal keymap.cson rather than opening 2015-10-23 12:49:14 -07:00
Ben Gotow
316d460288 fix(thread-list): Better hover state for quick actions 2015-10-23 12:47:32 -07:00
Evan Morikawa
4b7a3264bd fix(windows): fix apm package loading and onboarding styles 2015-10-23 12:18:00 -07:00
Ben Gotow
5c57817ee6 fix(onboarding): Do not open plugin folders after install 2015-10-23 11:58:33 -07:00
Ben Gotow
7d45b1ec97 fix(onboarding): Replace ❤️ with a heart image for win32 2015-10-23 11:42:55 -07:00
Ben Gotow
256330c3cb fix(onboarding): Fix size animation, resolves #150 2015-10-23 11:35:13 -07:00
Ben Gotow
404d0d2ec3 Merge pull request #121 from madhugb/master
Fixed a pixel cut in floating-toolbar
2015-10-23 09:54:39 -07:00
Ben Gotow
10ca07599b fix(tasks): Additional fixes 2015-10-22 18:07:59 -07:00
Ben Gotow
5415bc7665 fix(tasks): Invalid coffeescript in 531118ac5c 2015-10-22 17:26:14 -07:00