Summary:
Since we pass all of the account info to the type-specific auth routes, having
extra fields in the account info object can cause the auth request to fail its
validation. This diff ensures that switching account types will drop any fields
in the account info object that aren't accepted across all routes.
Fixes T7455
Test Plan: tested locally
Reviewers: evan, juan
Reviewed By: juan
Maniphest Tasks: T7455
Differential Revision: https://phab.nylas.com/D3633
Summary:
Instead of throwing vague undefined errors in the console, recognize that
they category wasn't created and notify the user via a dialog box.
Test Plan: Tested locally
Reviewers: jackie, juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D3632
Summary:
Adds electron's crash reporter. This is currently going to a dumb heroku
app I setup: https://github.com/emorikawa/electron-crash-report-server
It's going there for now since I want to first evaluate if this is useful
before spending the time to build it in N1-Cloud and taking the risk of
getting flooded by crash reports.
The crash reports themselves are very difficult to debug since it requires
compiling tools that can read os-specific memory dumps
Electron seems to be crashing fairly frequently for some unkonwn reason,
and this is really the only diagnostic tool we have to potentially see why
Test Plan: manual
Reviewers: spang, juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D3629
Summary: Retry the build per AppVeyor forum recomendation
Test Plan: run a build
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3628
Summary: The previous settings didn't support all operations. Fixes T7450 and T7451.
Test Plan: tested locally
Reviewers: juan
Reviewed By: juan
Maniphest Tasks: T7450, T7451
Differential Revision: https://phab.nylas.com/D3626
In `fromJSON()`, we were setting `categoriesType` to 'labels' if
the json had a truthy `labels` value. But an emtpy array is truthy,
and K2 always sends an array. This commit changes the conditional
to also ensure the array length is > 0.
Summary:
This commit introduces interruptible sync operations. Now, the `SyncWorker`, `FetchFolderList` operation and `FetchMessagesInFolder` operation can be interrupted at several p
To achieve this, this commit adds an Interruptible abstraction, which is an object that can run functions and interrupt them at points marked by the function. For more info o
This commit also splits up the SyncWorker a little bit to make it smaller, byadding a SyncbackTaskWorker.
Test Plan: manual
Reviewers: evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3613
Summary:
When the error details are too long, the error dialog went off screen and
could not be closed. The native dialog doesn't have any scroll support and
you can only pass it plain text, so this diff moves the error details into
a non-native modal with a scrollable textarea.
Fixes T7388
Test Plan: tested locally
Reviewers: jackie, juan
Reviewed By: juan
Maniphest Tasks: T7388
Differential Revision: https://phab.nylas.com/D3601
Summary:
We used to use a progress-based spinner, but we never get any progress
updates while downloading files, so the spinner was always at 0 and
never visible.
The submodule-commit is D3609, which adds support for inline images
Test Plan: tested locally
Reviewers: evan, spang
Reviewed By: spang
Differential Revision: https://phab.nylas.com/D3610
Summary: So that we know the status of builds
Test Plan: Run the build. See it post to slack
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3607
It looks like the location of the Flux architecture diagrams got moved around on the Flux docs; this change updates the link here to the new location of the diagram.
Summary: More files that don't need linting
Test Plan: ... run the build
Reviewers: evan
Reviewed By: evan
Subscribers: juan, evan
Differential Revision: https://phab.nylas.com/D3599
Summary:
- Make creating/renaming categories non-optimistic (this, along with the
submodule commit D3593, prevents sub-categories with emtpy titles)
- Use SyncbackTaskAPIRequest in DestroyCategoryTask
- Don't get upset that renaming a category doesn't return a server id
Test Plan: local
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3594
Summary: Second attempt at not linting the error logger and tiny lint cleanup
Test Plan: run the build
Reviewers: evan, juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D3591
Summary:
- Handle `categories` if it exists, because clone() will call fromJSON()
on the results of toJSON(), which populates `categories` instead of
`folder` or `labels`
- Remove the else-if for `folder` and `labels`, because both can co-exist.
Also concatenate the results from these two, rathering than overwriting.
Submodule commit is D3581, these two diffs together help make sure the
inflated messages in N1 have the right categories.
Test Plan: tested locally
Reviewers: juan, evan
Reviewed By: evan
Differential Revision: https://phab.nylas.com/D3582
Summary: Skipping linting for the error logger
Test Plan: Run the build
Reviewers: juan
Reviewed By: juan
Differential Revision: https://phab.nylas.com/D3583
