Commit graph

3642 commits

Author SHA1 Message Date
Ben Gotow
a84787859c fix(quoted-html): Fix null reference error, resolves Sentry 3264 2015-10-09 14:12:27 -07:00
Ben Gotow
9107bc325e fix(specs): ContactStore spec fixes for new contact ranking support 2015-10-09 13:42:24 -07:00
Ben Gotow
d1be3ac0f2 rollback(*): Move back SQLite upgrade after crashing in popout drafts 2015-10-09 13:25:39 -07:00
Drew Regitsky
d3d450105e fix(contacts): move contact rank fetching to sync workers, refactor
Summary:
Fixes bug where contact ranking was not being fetched, and refactors the refreshing
of contact ranks. Moves periodic refreshing of the database-stored ranks to the sync
workers so it occurs in the background, once per account. Refactors JSON cache code
accordingly.

Test Plan: manual

Reviewers: evan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2137
2015-10-09 12:40:36 -07:00
Ben Gotow
fd69d1af9c fix(contributing): Expand the instructions for running the stack on your own
Addresses several things brought up internally and in https://github.com/nylas/N1/pull/41
2015-10-09 10:41:05 -07:00
Ben Gotow
a977aacb57 Merge pull request #52 from mbilker/fix-clean-script
Change atom to nylas in clean script
2015-10-09 10:23:28 -07:00
Evan Morikawa
fb39edd531 Merge pull request #53 from mbilker/travis-update
Travis update
2015-10-09 10:20:37 -07:00
Evan Morikawa
913b00232d Add ChaosMonkey to test misbehaving servers
Summary:
`ChaosMonkey.unleashOnAPI()` will by default cause all API requests to 500

`ChaosMonkey.unleashOnAPI(timeoutMonkey: true)` will cause all API requests
to SOCKETTIMEOUT

`ChaosMonkey.unleashOnAPI(numMonkeys: 10)` will cause the next 10 API
requests to 500

`ChaosMonkey.unleashOnAPI(errorCode: 401, numMonkeys: 10)` will cause the
next 10 API requests to 401.

It must be manually invoked from the console on each window you want the
Monkeys wrecking havok.

It is available on the `window` object as well

This was created to manually test our server failure cases.

Test Plan: manual

Reviewers: drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2133
2015-10-09 09:37:56 -07:00
Evan Morikawa
dfab406484 Fix contact ranking and add tests
Summary:
Contact ranking is now tested.

There was a bug whereby the RankingsJSONCache would only update in the
workerwindow. This regressed when Contact ranking moved exclusively into
the main window and separate composer windws requested rankings via ipc

Test Plan: New tests

Reviewers: drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2134
2015-10-09 09:31:52 -07:00
Evan Morikawa
21a4bcb3c4 Fix scrollability in expanded activity sidebar
Summary:
If your screen is narrow or you are syncing a lot of stuff, the expanded
activity sidebar had no scroll affordance

Test Plan: manual

Reviewers: drew, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2135
2015-10-09 09:31:37 -07:00
Ben Gotow
d5e04295b2 fix(initial-sync): When an error is encountered, do not start fetching from zero again
Summary:
Previously, when an error was encountered during initial mailbox sync we just started it
over after a retry delay. Recent API uptime issues mean that this was happening often and lots of
people were seeing sync retry many times. This is bad because the app is less performant while
it's syncing mail, and also generates unnecessary load as the app re-fetches threads it already has.

In this diff, there are new specs and functionality in nylas-sync-worker to start fetching
where we left off. This is typically going to be OK because the default sort ordering of the
threads endpoint is newest->oldest, so if new items have arrived since we started fetching
and page boundaries have changed, we'll get duplicate data rather than missing data. Connceting
to the streaming API as soon as we start the sync also ensures that we roll up any changes to
data we've already paginated over.

Test Plan: Run tests

Reviewers: drew, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D2132
2015-10-08 19:02:54 -07:00
Matt Bilker
2a07df0ebd fix(grunt): disable packaging under travis builds 2015-10-07 22:54:22 -04:00
Matt Bilker
3d69b76823 fix(travis): disable node 4 for now
throws errors everywhere regarding the compiler, nan, and node 4.1.2
2015-10-07 22:52:20 -04:00
Matt Bilker
766959bfab fix(travis): set compiler to clang 2015-10-07 22:36:28 -04:00
Matt Bilker
750539bd9b fix(build): disable codesign in travis builds 2015-10-07 22:35:51 -04:00
Matt Bilker
321a010370 fix(whitespace): coffeelint line 19 ends with whitespace 2015-10-07 22:32:28 -04:00
Matt Bilker
6bdb850ade fix(travis): another new github access token
found out you cannot use personal access tokens
github disables them if they are found in a commit
2015-10-07 22:26:45 -04:00
Matt Bilker
b00bc73dc5 fix(travis): update github access token 2015-10-07 22:15:10 -04:00
Matt Bilker
0ff7dfad9e fix(travis): add github access key 2015-10-07 21:59:25 -04:00
Matt Bilker
bd64cb1218 fix(grunt): change variable name for github access key 2015-10-07 21:57:45 -04:00
Matt Bilker
87b509b905 fix(travis): nvm does not like node 4 on osx 2015-10-07 21:56:03 -04:00
Matt Bilker
d486698463 fix(travis): add required APT packages 2015-10-07 21:52:42 -04:00
Matt Bilker
8b02e4106c fix(travis): switch to matrix build strategy 2015-10-07 21:51:30 -04:00
Matt Bilker
8230148e5e fix(travis): accidentally removed the language selection 2015-10-07 21:46:14 -04:00
Matt Bilker
8eb6868f6c fix(travis): Update travis script to run on multiple oses 2015-10-07 21:42:48 -04:00
Matt Bilker
543e3ba6ee refactor(code): change atom to nylas in clean script 2015-10-07 21:34:07 -04:00
Evan Morikawa
fc8b1bae3d Merge pull request #50 from lukegb/patch-1
fix(docs): correct SMPT->SMTP
2015-10-07 17:48:59 -07:00
Evan Morikawa
900cd69438 fix(developer): visual improvements to developer bar
Summary: Make ETIMEDOUT red

Test Plan: manual

Reviewers: bengotow, dillon

Reviewed By: dillon

Differential Revision: https://phab.nylas.com/D2126
2015-10-07 17:28:45 -07:00
Evan Morikawa
143f301baf Update CONTRIBUTING.md and README.md to remove node requirement
No more warning message about needing Node v0.10. This got fixed :D

Adding more info about our commit guidelines.
2015-10-07 17:18:41 -07:00
Evan Morikawa
bd065b7fb4 Upgrade to Electron 0.30.8. Remove unsused packages. Upgrade deps
- Upgrade node-sqlite3 from patched 3.0.2 to mainline 3.1.0

- Upgrade Electron to 0.30.8: NOTE: This is the latest in the 0.30 line.
  The 0.31+ line did a Chrome upgrade that we want to save for a later
  day. We've had a history of serious instabilities with these upgrades
  and are doing them conservatively

- Upgrade coffee-script from 1.9.0 to 1.10.0

- Package updates in /build folder
2015-10-07 16:52:49 -07:00
Drew Regitsky
7f0fca9c25 feature(feedback): move feedback to a package, indicator for new msgs
Summary: Move all Intercom feedback code to a package. Change the appearance of the lower right question mark icon when a new intercom message is received (red, with repeating CSS bounce animation). New messages are detected by keeping the intercom window open (after the first time it's opened by the user), and listening for DOM mutations of particular classes.

Test Plan: manual

Reviewers: bengotow

Reviewed By: bengotow

Subscribers: evan

Differential Revision: https://phab.nylas.com/D2125
2015-10-07 13:55:54 -07:00
Luke GB
c6742b2804 fix(docs): correct SMPT->SMTP 2015-10-07 21:54:02 +01:00
dillon
d634c75420 fix(docs): add CLA to CONTRIBUTING.md
Test Plan: manual

Reviewers: evan, bengotow

Maniphest Tasks: T4193

Differential Revision: https://phab.nylas.com/D2128
2015-10-07 11:51:33 -07:00
Ben Gotow
bb3b5bb875 fix(send-availability): Make the package load into popout composers 2015-10-07 11:45:46 -07:00
Evan Morikawa
e9310b80c2 Merge pull request #49 from mbilker/node-v4
Compile on Node 4.x and 0.12
2015-10-07 10:55:51 -07:00
Evan Morikawa
af559cb8e0 Merge pull request #16 from sbstnmsch/feature-travis-ci
Add basic travis-ci integration
2015-10-07 10:55:23 -07:00
Dillon Forrest
7604873956 Merge pull request #30 from gardner/master
Adding node version information to build/README.md
2015-10-07 10:40:23 -07:00
Dillon Forrest
5760f61fd6 Merge pull request #31 from malonehedges/patch-1
Fix little typo
2015-10-07 10:38:57 -07:00
Dillon Forrest
bd7c6441ad Merge pull request #43 from boffbowsh/patch-1
Fix a couple of typos and a syntax error
2015-10-07 10:36:03 -07:00
Ben Gotow
ed7af21c1b bump(version): 0.3.15 2015-10-07 10:19:16 -07:00
Matt Bilker
03e2f180b7 Use npm's packaged node-gyp and combine configure and rebuild gyp steps 2015-10-06 23:41:19 -04:00
Matt Bilker
cab1c9e4ca Target node version used by APM 1.1.1 and Electron 0.30.7
node-gyp header layout change in node v4, causes package builds to fail.

This change forces node-gyp to download the correct version of node so
native extensions can be built.
2015-10-06 23:40:35 -04:00
Matt Bilker
96bc0c9f97 Update build packages to allow building with node v4.1.2
coffee-lint-cjsx added to account for ignored peer dependencies in
npm 3+
2015-10-06 23:36:39 -04:00
Matt Bilker
438f71b576 Update APM to 1.1.1
This is the latest version of APM at this time and is already in use
by the Atom editor.
2015-10-06 23:35:03 -04:00
Matt Bilker
f722ffcf43 Change Electron version to 0.30.7 2015-10-06 23:34:02 -04:00
Brett Gerry
9a893dff1b add more info on running against local sync engine
Test Plan: doc only change

Reviewers: evan, bengotow

Reviewed By: bengotow

Differential Revision: https://phab.nylas.com/D2119
2015-10-06 19:05:02 -07:00
Ben Gotow
2cedc4cfea fix(auth): Resize the auth window after an update to the token status 2015-10-06 17:58:07 -07:00
Ben Gotow
7d6280a864 fix(atom): Never allow the window to be set to fractional sizes 2015-10-06 15:32:48 -07:00
Ben Gotow
311c85b32d fix(docs): Include a note about script/build in CONTRIBUTING.md 2015-10-06 14:31:00 -07:00
Ben Gotow
caffa027d9 fix(docs): Add a note about our public Trello board 2015-10-06 14:28:16 -07:00