Mailspring

2346 commits 31 branches 65 tags 142 MiB

Author	SHA1	Message	Date
Ben Gotow	68ab8e22c9	fix(drafts): Lock drafts when they're deleted so they can't be revived by deltas Summary: When we delete drafts, they can sometimes come back because we receive deltas about them, find that they're not in the cache, and re-save them. This diff fixes that by permanently incrementing the optimistic change count, which was also do to prevent deltas from changing threads while we're in the middle of a request that will change them further. (This may not actually be necessary anymore, because we'd ignore the delta anyway due to it's out-of-date version?) Test Plan: Run a couple new tests Reviewers: drew, juan Reviewed By: juan Differential Revision: https://phab.nylas.com/D2665	2016-03-03 12:09:16 -08:00
Ben Gotow	338ef0d56e	rename(specs): A few more task renames	2016-03-01 17:34:36 -08:00

Author

SHA1

Message

Date

Ben Gotow

68ab8e22c9

fix(drafts): Lock drafts when they're deleted so they can't be revived by deltas

Summary:
When we delete drafts, they can sometimes come back because we receive deltas about them,
find that they're not in the cache, and re-save them.

This diff fixes that by permanently incrementing the optimistic change count, which was also do
to prevent deltas from changing threads while we're in the middle of a request that will change
them further. (This may not actually be necessary anymore, because we'd ignore the delta anyway
due to it's out-of-date version?)

Test Plan: Run a couple new tests

Reviewers: drew, juan

Reviewed By: juan

Differential Revision: https://phab.nylas.com/D2665

2016-03-03 12:09:16 -08:00

Ben Gotow

338ef0d56e

rename(specs): A few more task renames

2016-03-01 17:34:36 -08:00

Renamed from spec/tasks/send-draft-spec.coffee (Browse further)

2 commits