mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-11 18:32:20 +08:00
e303705b45
Summary: Features: - ThreadListParticipants ignores drafts when computing participants, renders "Draft" label, pending design - Put the WorkspaceStore in every window—means they all get toolbars and custom gumdrop icons on Mac OS X Bug Fixes: - Never display notifications for email the user just sent - Fix obscure issue with DatabaseView trying to update metadata on items it froze. This resolves issue with names remaining bold after marking as read, drafts not appearing in message list immediately. - When you pop out a draft, save it first and *wait* for the commit() promise to succeed. - If you scroll very fast, you node.contentWindow can be null in eventedIframe Other: Make it OK to re-register the same component Make it possible to unregister a hot window Break the Sheet Toolbar out into it's own file to make things manageable Replace `package.windowPropsReceived` with a store-style model where anyone can listen for changes to `windowProps` When I put the WorkspaceStore in every window, I ran into a problem because the package was no longer rendering an instance of the Composer, it was declaring a root sheet with a composer in it. This meant that it was actually a React component that needed to listen to window props, not the package itself. `atom` is already an event emitter, so I added a `onWindowPropsReceived` hook so that components can listen to window props as if they were listening to a store. I think this might be more flexible than only broadcasting the props change event to packages. Test Plan: Run tests Reviewers: evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D1592
101 lines
4.3 KiB
CoffeeScript
101 lines
4.3 KiB
CoffeeScript
React = require 'react'
|
|
ComponentRegistry = require '../src/component-registry'
|
|
|
|
class TestComponent extends React.Component
|
|
@displayName: 'TestComponent'
|
|
constructor: ->
|
|
|
|
class TestComponentNotSameIdentity extends React.Component
|
|
@displayName: 'TestComponent'
|
|
constructor: ->
|
|
|
|
class TestComponentNoDisplayName extends React.Component
|
|
constructor: ->
|
|
|
|
class AComponent extends React.Component
|
|
@displayName: 'A'
|
|
|
|
class BComponent extends React.Component
|
|
@displayName: 'B'
|
|
|
|
class CComponent extends React.Component
|
|
@displayName: 'C'
|
|
|
|
class DComponent extends React.Component
|
|
@displayName: 'D'
|
|
|
|
class EComponent extends React.Component
|
|
@displayName: 'E'
|
|
|
|
class FComponent extends React.Component
|
|
@displayName: 'F'
|
|
|
|
describe 'ComponentRegistry', ->
|
|
beforeEach ->
|
|
ComponentRegistry._clear()
|
|
|
|
describe 'register', ->
|
|
it 'throws an exception if passed a non-component', ->
|
|
expect(-> ComponentRegistry.register(null)).toThrow()
|
|
expect(-> ComponentRegistry.register("cheese")).toThrow()
|
|
|
|
it 'returns itself', ->
|
|
expect(ComponentRegistry.register(TestComponent, {role: "bla"})).toBe(ComponentRegistry)
|
|
|
|
it 'does allow the exact same component to be redefined with different role/locations', ->
|
|
ComponentRegistry.register(TestComponent, {role: "bla"})
|
|
expect(-> ComponentRegistry.register(TestComponent, {role: "other-role"})).not.toThrow()
|
|
|
|
it 'does not allow components to be overridden by other components with the same displayName', ->
|
|
ComponentRegistry.register(TestComponent, {role: "bla"})
|
|
expect(-> ComponentRegistry.register(TestComponentNotSameIdentity, {role: "bla"})).toThrow()
|
|
|
|
it 'does not allow components to be registered without a displayName', ->
|
|
expect(-> ComponentRegistry.register(TestComponentNoDisplayName, {role: "bla"})).toThrow()
|
|
|
|
describe 'findComponentByName', ->
|
|
it 'should return a component', ->
|
|
ComponentRegistry.register(TestComponent, {role: "bla"})
|
|
expect(ComponentRegistry.findComponentByName('TestComponent')).toEqual(TestComponent)
|
|
|
|
it 'should return undefined if there is no component', ->
|
|
expect(ComponentRegistry.findComponentByName("not actually a name")).toBeUndefined()
|
|
|
|
describe 'findComponentsMatching', ->
|
|
it 'should throw if a descriptor is not provided', ->
|
|
expect( -> ComponentRegistry.findComponentsMatching()).toThrow()
|
|
|
|
it 'should return the correct results in a wide range of test cases', ->
|
|
StubLocation1 =
|
|
id: 'StubLocation1'
|
|
StubLocation2 =
|
|
id: 'StubLocation2'
|
|
ComponentRegistry.register(AComponent, { role: 'ThreadAction' })
|
|
ComponentRegistry.register(BComponent, { role: 'ThreadAction', modes: ['list'] })
|
|
ComponentRegistry.register(CComponent, { location: StubLocation1, modes: ['split'] })
|
|
ComponentRegistry.register(DComponent, { locations: [StubLocation1, StubLocation2] })
|
|
ComponentRegistry.register(EComponent, { roles: ['ThreadAction', 'MessageAction'] })
|
|
ComponentRegistry.register(FComponent, { roles: ['MessageAction'], mode: 'list' })
|
|
|
|
scenarios = [
|
|
{descriptor: {role: 'ThreadAction'}, results: [AComponent, BComponent, EComponent]}
|
|
{descriptor: {role: 'ThreadAction', mode: 'list'}, results: [AComponent, BComponent, EComponent]}
|
|
{descriptor: {role: 'ThreadAction', mode: 'split'}, results: [AComponent, EComponent]}
|
|
{descriptor: {location: StubLocation1}, results: [CComponent, DComponent]}
|
|
{descriptor: {location: StubLocation1, mode: 'list'}, results: [DComponent]}
|
|
{descriptor: {locations: [StubLocation1, StubLocation2]}, results: [CComponent, DComponent]}
|
|
{descriptor: {roles: ['ThreadAction', 'MessageAction']}, results: [AComponent, BComponent, EComponent, FComponent]}
|
|
]
|
|
|
|
scenarios.forEach ({descriptor, results}) ->
|
|
expect(ComponentRegistry.findComponentsMatching(descriptor)).toEqual(results)
|
|
|
|
|
|
describe 'unregister', ->
|
|
it 'unregisters the component if it exists', ->
|
|
ComponentRegistry.register(TestComponent, { role: 'bla' })
|
|
ComponentRegistry.unregister(TestComponent)
|
|
expect(ComponentRegistry.findComponentByName('TestComponent')).toBeUndefined()
|
|
|
|
it 'throws if a string is passed instead of a component', ->
|
|
expect( -> ComponentRegistry.unregister('TestComponent')).toThrow()
|