mirror of
https://github.com/Foundry376/Mailspring.git
synced 2025-01-08 01:04:39 +08:00
74e21bce16
Summary: 1. **Generic CUD Tasks**: There is now a generic `CreateModelTask`, `UpdateModelTask`, and `DestroyModelTask`. These can either be used as-is or trivially overridden to easily update simple objects. Hopefully all of the boilerplate rollback, error handling, and undo logic won't have to be re-duplicated on every task. There are also tests for these tasks. We use them to perform mutating actions on `Metadata` objects. 1. **Failing on Promise Rejects**: Turns out that if a Promise rejected due to an error or `Promise.reject` we were ignoring it and letting tests pass. Now, tests will Fail if any unhandled promise rejects. This uncovered a variety of errors throughout the test suite that had to be fixed. The most significant one was during the `theme-manager` tests when all packages (and their stores with async DB requests) was loaded. Long after the `theme-manager` specs finished, those DB requests were (somtimes) silently failing. 1. **Globally stub `DatabaseStore._query`**: All tests shouldn't actually make queries on the database. Furthremore, the `inTransaction` block doesn't resolve at all unless `_query` is stubbed. Instead of manually remembering to do this in every test that touches the DB, it's now mocked in `spec_helper`. This broke a handful of tests that needed to be manually fixed. 1. **ESLint Fixes**: Some minor fixes to the linter config to prevent yelling about minor ES6 things and ensuring we have the correct parser. Test Plan: new tests Reviewers: bengotow, juan, drew Differential Revision: https://phab.nylas.com/D2419 Remove cloudState and N1-Send-Later
25 lines
490 B
JSON
25 lines
490 B
JSON
{
|
|
"extends": "airbnb",
|
|
"globals": {
|
|
"NylasEnv": false,
|
|
"$n": false
|
|
},
|
|
"env": {
|
|
"browser": true,
|
|
"node": true,
|
|
"jasmine": true
|
|
},
|
|
"rules": {
|
|
"react/prop-types": [2, {"ignore": ["children"]}],
|
|
"eqeqeq": [2, "smart"],
|
|
"id-length": [0],
|
|
"object-curly-spacing": [0],
|
|
"no-console": [0],
|
|
"no-loop-func": [0],
|
|
"new-cap": [2, {"capIsNew": false}],
|
|
"no-shadow": [1],
|
|
"quotes": [0],
|
|
"semi": [0]
|
|
},
|
|
"parser": "babel-eslint"
|
|
}
|