mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-12 04:25:31 +08:00
9b54d9cf31
Summary: This fixes a serious issue where drafts could appear to be sending if they were located in the same index of the message list as a draft which was previously sending. Under the hood this was due to two bad programming choices: 1) State based on props in MessageContainer requires correct implementation of componentWillReceiveProps. This is definitely an anti-pattern. 2) Using item index rather than clientId as the key for items in the MessageList caused containers to be given a different message prop when one was inserted, rather than just shifting the existing ones down and inserting a new one. Test Plan: Not sure how to test this really... Reviewers: drew, juan Differential Revision: https://phab.nylas.com/D2673 |
||
---|---|---|
.. | ||
lib | ||
spec | ||
stylesheets | ||
.gitignore | ||
package.json |