mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-13 13:19:34 +08:00
1a3cca8d0a
* Remove the composer contenteditable, replace with basic <textarea> * Beginning broader cleanup of draft session * DraftJS composer with color, style support * Serialization/unserialization of basic styles, toolbar working * WIP * Switch to draft-js-plugins approach, need to revisit HTML * Move HTML conversion functionality into plugins * Add spellcheck context menu to editor * Initial work on quoted text * Further work on quoted text * BLOCK approach * Entity approach - better, does not bump out to top level * Hiding and showing quoted text via CSS * Get rid of ability to inject another subject line component * Clean up specs, DraftFactory to ES6 * Remove old initial focus hack * Fix focusing, initial text selection * Remove participant “collapsing” support, it can be confusing * Correctly terminate links on carriage returns * Initial signature support, allow removal of uneditable blocks * Sync body string with body editorstate * Simplify draft editor session, finish signatures * Templates * Minor fixes * Simplify link/open tracking, ensure it works * Reorg composer, rework template editor * Omg the slowness is all the stupid emoji button * Polish and small fixes * Performance improvements, new templates UI * Don’t assume nodes are elements * Fix for sending drafts twice due to back-to-back saves * Fix order of operations on app quit to save drafts reliably * Improve DraftJS-Convert whitespace handling * Use contentID throughout attachment lifecycle * Try to fix images * Switch to Slate instead of DraftJS… much better * Fix newline handling * Bug fixes * Cleanup * Finish templates plugin * Clean up text editing / support for Gmail email styles * Support for color + size on the same node, clean trailing whitespace * Restore emoji typeahead / emoji picker * Fix scrolling in template editor * Fix specs * Fix newlines * Re-implement spellcheck to be faster * Make spellcheck decorator changes invisible to the undo/redo stack * Remove comment * Polish themplates panel * Fix #521
209 lines
6.6 KiB
JavaScript
209 lines
6.6 KiB
JavaScript
import { Message, SendActionsStore, ExtensionRegistry } from 'mailspring-exports';
|
|
|
|
const SendAction1 = {
|
|
title: 'Send Action 1',
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const SendAction2 = {
|
|
title: 'Send Action 2',
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const SendAction3 = {
|
|
title: 'Send Action 3',
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const NoTitleAction = {
|
|
isAvailableForDraft: () => true,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const NoPerformAction = {
|
|
title: 'No Perform',
|
|
isAvailableForDraft: () => true,
|
|
};
|
|
|
|
const NotAvailableAction = {
|
|
title: 'Not Available',
|
|
isAvailableForDraft: () => false,
|
|
performSendAction: () => {},
|
|
};
|
|
|
|
const GoodExtension = {
|
|
name: 'GoodExtension',
|
|
sendActions() {
|
|
return [SendAction1];
|
|
},
|
|
};
|
|
|
|
const BadExtension = {
|
|
name: 'BadExtension',
|
|
sendActions() {
|
|
return [null];
|
|
},
|
|
};
|
|
|
|
const NoTitleExtension = {
|
|
name: 'NoTitleExtension',
|
|
sendActions() {
|
|
return [NoTitleAction];
|
|
},
|
|
};
|
|
|
|
const NoPerformExtension = {
|
|
name: 'NoPerformExtension',
|
|
sendActions() {
|
|
return [NoPerformAction];
|
|
},
|
|
};
|
|
|
|
const NotAvailableExtension = {
|
|
name: 'NotAvailableExtension',
|
|
sendActions() {
|
|
return [NotAvailableAction];
|
|
},
|
|
};
|
|
|
|
const NullExtension = {
|
|
name: 'NullExtension',
|
|
sendActions() {
|
|
return null;
|
|
},
|
|
};
|
|
|
|
const OtherExtension = {
|
|
name: 'OtherExtension',
|
|
sendActions() {
|
|
return [SendAction2, SendAction3];
|
|
},
|
|
};
|
|
|
|
const { DefaultSendActionKey } = SendActionsStore;
|
|
|
|
function sendActionKeys() {
|
|
return SendActionsStore.collectSendActions().map(({ configKey }) => configKey);
|
|
}
|
|
|
|
describe('SendActionsStore', function describeBlock() {
|
|
beforeEach(() => {
|
|
this.id = 'client-23';
|
|
this.draft = new Message({ id: this.id, draft: true });
|
|
spyOn(AppEnv, 'reportError');
|
|
});
|
|
|
|
describe('sendActions', () => {
|
|
it('returns default action when no extensions registered', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey]);
|
|
});
|
|
|
|
it('returns correct send actions', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, OtherExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([
|
|
DefaultSendActionKey,
|
|
'send-action-1',
|
|
'send-action-2',
|
|
'send-action-3',
|
|
]);
|
|
});
|
|
|
|
it('handles extensions that return null for `sendActions`', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, NullExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
});
|
|
|
|
it('handles extensions that return null actions', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, BadExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
});
|
|
|
|
it('omits and reports when action is missing a title', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, NoTitleExtension]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
expect(AppEnv.reportError).toHaveBeenCalled();
|
|
});
|
|
|
|
it('omits reports when action is missing performSendAction', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
NoPerformExtension,
|
|
]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1']);
|
|
expect(AppEnv.reportError).toHaveBeenCalled();
|
|
});
|
|
|
|
it('includes not available actions', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
NotAvailableExtension,
|
|
]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
expect(sendActionKeys()).toEqual([DefaultSendActionKey, 'send-action-1', 'not-available']);
|
|
});
|
|
});
|
|
|
|
describe('orderedSendActionsForDraft', () => {
|
|
it('returns default action when no extensions registered', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([]);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred, ...rest] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
expect(rest).toEqual([]);
|
|
});
|
|
|
|
it('returns actions in correct grouping', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
OtherExtension,
|
|
NotAvailableExtension,
|
|
]);
|
|
spyOn(AppEnv.config, 'get').andReturn('send-action-1');
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred, ...rest] = SendActionsStore.orderedSendActionsForDraft();
|
|
const restKeys = rest.map(({ configKey }) => configKey);
|
|
expect(preferred.configKey).toBe('send-action-1');
|
|
expect(restKeys).toEqual([DefaultSendActionKey, 'send-action-2', 'send-action-3']);
|
|
});
|
|
|
|
it('falls back to a default if value in config not present', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, OtherExtension]);
|
|
spyOn(AppEnv.config, 'get').andReturn(null);
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
});
|
|
|
|
it("falls back to a default if the primary item can't be found", () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([GoodExtension, OtherExtension]);
|
|
spyOn(AppEnv.config, 'get').andReturn('does-not-exist');
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
});
|
|
|
|
it('falls back to a default if the primary item is not available for draft', () => {
|
|
spyOn(ExtensionRegistry.Composer, 'extensions').andReturn([
|
|
GoodExtension,
|
|
NotAvailableExtension,
|
|
]);
|
|
spyOn(AppEnv.config, 'get').andReturn('not-available');
|
|
SendActionsStore._onComposerExtensionsChanged();
|
|
const [preferred] = SendActionsStore.orderedSendActionsForDraft();
|
|
expect(preferred.configKey).toBe(DefaultSendActionKey);
|
|
});
|
|
});
|
|
|
|
// TODO Should go Task spec
|
|
it('catches any errors in an extension performSendAction method', () => {});
|
|
});
|