Foundry376/Mailspring
1
1
Fork 0
mirror of https://github.com/Foundry376/Mailspring.git synced 2025-03-01 10:33:14 +08:00
Code Issues Projects Releases Packages Wiki Activity
Mailspring/packages/isomorphic-core
History
Halla Moore 1e0ae4fb03 [cloud-core, cloud-workers, isomorphic-core] Fix sending from cloud-workers 
Summary:
The SendmailClient is in isomorphic-core, but wasn't working properly when
called from cloud-workers. This diff includes a variety of fixes to get it
working:

  - Add smtp config to connection settings in cloud-core
  - Don't use `PromiseUtils.promisify` for a function that needs `this` to
    be bound properly
  - Don't reference `NylasEnv` (That error gets caught and reported
    elsewhere anyway, we don't need to report it here)
  - Default `message.uploads` to `[]` to keep iterator happy
  - Add Gmail environment variables to cloud-worker app

Test Plan: manual

Reviewers: juan, khamidou, evan

Reviewed By: evan

Differential Revision: https://phab.nylas.com/D3954
2017-02-17 19:05:36 -08:00
..
spec
src [cloud-core, cloud-workers, isomorphic-core] Fix sending from cloud-workers 2017-02-17 19:05:36 -08:00
index.js [iso-core] Add BackoffScheduler to exports 2017-02-17 11:03:26 -08:00
package.json [isomorphic-core] Allow use of atob() in cloud environments 2017-02-17 14:46:07 -08:00
README.md [*] update and add READMEs to each package 2017-02-17 17:28:09 -08:00

README.md

Isomorphic Core

Isomorphic refers to javascript that can be run on both the client and the server.

This is shared code for mail and utilities that is designed to run both on deployed cloud servers and from within the Nylas Mail client.

Use through a regular import: import iso-core from 'isomorphic-core'

It is required as a dependency in the package.json of other modules.

This library isn't on the npm registry, but works as a dependency thanks to lerna bootstrap

See index.js for what gets explicitly exported by this library.

Important Usage Notes:

Since this code runs in both the client and the server, you must be careful with what libraries you use. Some common gotchas:

  • You can't use NylasEnv or NylasExports. These are injected only in the client.
  • If you require a 3rd party library, it must be added to the "dependencies" of isomorphic-core's package.json
  • You may use modern javascript syntax. Both the client and server get compiled with the same .babelrc setting