Mailspring/internal_packages/composer/spec
Evan Morikawa 1e146f6781 fix(composer): warn when empty body
Summary:
Fixes T2276
Since the new `QuotedHTMLParser` uses full HTML parsing, when you ask it
for the version of the document without the quoted nodes, it returns a
full html document. Unfortunately I forgot about the 2 <br> tags we
manually generate when creating a reply to a message with quoted text.

This is a pretty brittle solution, but considerably easier then checking
if the contents really are "blank". We could check innerText, but would
have to worry about img tags and other text-invisible-but-still-valid
elements. Since we control the generation of the reply in the
`DraftStore`, I think this is acceptable for now

Test Plan: edgehill --test

Reviewers: bengotow

Reviewed By: bengotow

Maniphest Tasks: T2276

Differential Revision: https://phab.nylas.com/D1730
2015-07-13 10:12:52 -04:00
..
composer-view-spec.cjsx fix(composer): warn when empty body 2015-07-13 10:12:52 -04:00
contenteditable-component-spec.cjsx feat(paste): Add files by pasting them into the composer 2015-06-08 12:41:31 -07:00
contenteditable-quoted-text-spec.cjsx feat(quoted-text): New quoted text engine 2015-07-08 09:51:33 -07:00
participants-text-field-spec.cjsx refactor(utils): switch to regular underscore 2015-05-19 16:06:59 -07:00