mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-21 15:56:10 +08:00
1e6e857f28
Summary: Consolidate the smarts from ChangeFolderTask into a generic ChangeMailTask ChangeMailTask: - only makes requests for threads / messages that actually changed - handles incrementing / decrementing locks - writes changes to the database in a single pass, and only writes modified models - encapsulates the undo state that was built into ChangeFolderTask This change means that ChangeLabelsTask enjoys the same "smarts" as ChangeFolderTask. Label changes resulting in no-ops do not create web requests, you can undo label changes and they go back to the correct previous state. Replace "UpdateThreadsTask" and "UpdateNylasObjectsTask" with subclasses based on the same code used for folder/labels This means that the naming and parameter sets are consistent for all thread/message changing tasks. It also means that starring/marking as use the same (tested) business logic and starring 999 already-starred threads doesn't create 999 requests. Go away DraftCountStore - nobody wants you in secondary windows Add "Debug query plans" option which prints out the steps the database is taking. Look for "SCAN" to now you're having a bad time. Make "version" field queryable, when we receive deltas/API response, find all versions of existing models in a single query without loading or parsing the objects Contact: Add index for lookup by email Label: add index for lookup by name Message: Add index for message body join table Test Plan: Run tests Reviewers: evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D1840 |
||
|---|---|---|
| .. | ||
| components | ||
| fixtures | ||
| models | ||
| stores | ||
| tasks | ||
| action-bridge-spec.coffee | ||
| auto-update-manager-spec.coffee | ||
| buffered-process-spec.coffee | ||
| clipboard-spec.coffee | ||
| component-registry-spec.coffee | ||
| database-view-spec.coffee | ||
| dom-utils-spec.coffee | ||
| menu-manager-spec.coffee | ||
| model-view-selection-spec.coffee | ||
| model-view-spec.coffee | ||
| module-cache-spec.coffee | ||
| nylas-protocol-handler-spec.coffee | ||
| nylas-sync-worker-spec.coffee | ||
| package-manager-spec.coffee | ||
| package-spec.coffee | ||
| quoted-html-parser-spec.coffee | ||
| quoted-plain-text-parser-spec.coffee | ||
| style-manager-spec.coffee | ||
| styles-element-spec.coffee | ||
| task-spec.coffee | ||
| test_utils.coffee | ||
| theme-manager-spec.coffee | ||
| undo-manager-spec.coffee | ||
| utils-spec.coffee | ||