1e8fd46342
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
|
||
|---|---|---|
| apm | ||
| arclib | ||
| build | ||
| docs | ||
| dot-atom | ||
| dot-inbox | ||
| exports | ||
| internal_packages | ||
| keymaps | ||
| menus | ||
| resources | ||
| script | ||
| spec | ||
| spec-inbox | ||
| src | ||
| static | ||
| vendor | ||
| .arcconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .node-version | ||
| .npmrc | ||
| .pairs | ||
| .python-version | ||
| atom.sh | ||
| coffeelint.json | ||
| CONTRIBUTING.md | ||
| Dockerfile | ||
| LICENSE.md | ||
| package.json | ||
| README.md | ||
Atom is a hackable text editor for the 21st century, built on atom-shell, and based on everything we love about our favorite editors. We designed it to be deeply customizable, but still approachable using the default configuration.
Visit atom.io to learn more or visit the Atom forum.
Visit issue #3684 to learn more about the Atom 1.0 roadmap.
Installing
OS X
Download the latest Atom release.
Atom will automatically update when a new release is available.
Windows
Download the latest AtomSetup.exe installer.
Atom will automatically update when a new release is available.
You can also download an atom-windows.zip file from the releases page.
The .zip version will not automatically update.
Uninstalling Chocolatey Version
The recommended installation of Atom on Windows used to be using Chocolatey. This is no longer recommended now that the Atom Windows installer & auto-updater exists.
To switch from Chocolatey to the new installer:
- Upgrade to Atom 0.155 or above by running
cup Atom - Run
cuninst Atomto uninstall the Chocolatey version of Atom- This will not delete any of your installed packages or Atom config files.
- Download the latest AtomSetup.exe installer.
- Double-click the downloaded file to install Atom
Debian Linux (Ubuntu)
Currently only a 64-bit version is available.
- Download
atom-amd64.debfrom the Atom releases page. - Run
sudo dpkg --install atom-amd64.debon the downloaded package. - Launch Atom using the installed
atomcommand.
The Linux version does not currently automatically update so you will need to repeat these steps to upgrade to future releases.
Red Hat Linux (Fedora, CentOS, Red Hat)
Currently only a 64-bit version is available.
- Download
atom.x86_64.rpmfrom the Atom releases page. - Run
sudo yum localinstall atom.x86_64.rpmon the downloaded package. - Launch Atom using the installed
atomcommand.
The Linux version does not currently automatically update so you will need to repeat these steps to upgrade to future releases.
Building
Developing
Check out the guides and the API reference.