mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-09-23 08:46:07 +08:00
585dab7cdf
Summary: Up until now, we've been requiring that every plugin control in the composer take the draftClientId, retreive the session, listen to it, build state from the draft, etc. This is a huge pain and is hard to explain to newcomers becaus it frankly makes no sense. In 0.3.45 we made it so that the ComposerView always has a non-null draft and session. (It isn't rendered until they're available). In this diff, I just pass those through to all the plugins and remove all the session retrieval cruft. Almost none of the buttons have state of their own, which I think is appropriate. They do render on every keystroke, but they were already running code (to recompute their state) on each keystroke and profiling suggests this has no impact. Prepare for immutable In preparation for Immutable models, make the draft store proxy returns a !== draft if any changes have been made. This means you can safely know that a draft has changed if `props.draft !== nextProps.draft` Test Plan: Run tests Reviewers: juan, evan Reviewed By: juan, evan Differential Revision: https://phab.nylas.com/D2902
70 lines
2.3 KiB
JavaScript
70 lines
2.3 KiB
JavaScript
import React from 'react';
|
|
import ReactDOM from 'react-dom';
|
|
import {findRenderedDOMComponentWithClass} from 'react-addons-test-utils';
|
|
|
|
import {DateUtils} from 'nylas-exports'
|
|
import SendLaterButton from '../lib/send-later-button';
|
|
import SendLaterActions from '../lib/send-later-actions';
|
|
|
|
const node = document.createElement('div');
|
|
|
|
const makeButton = (initialState, metadataValue)=> {
|
|
const message = {
|
|
metadataForPluginId: ()=> metadataValue,
|
|
}
|
|
const button = ReactDOM.render(<SendLaterButton draft={message} />, node);
|
|
if (initialState) {
|
|
button.setState(initialState)
|
|
}
|
|
return button
|
|
};
|
|
|
|
describe('SendLaterButton', ()=> {
|
|
beforeEach(()=> {
|
|
spyOn(DateUtils, 'format').andReturn('formatted')
|
|
spyOn(SendLaterActions, 'sendLater')
|
|
});
|
|
|
|
describe('componentWillReceiveProps', ()=> {
|
|
it('closes window if window is composer window and saving has finished', ()=> {
|
|
makeButton({saving: true}, null)
|
|
spyOn(NylasEnv, 'close')
|
|
spyOn(NylasEnv, 'isComposerWindow').andReturn(true)
|
|
makeButton(null, {sendLaterDate: 'date'})
|
|
expect(NylasEnv.close).toHaveBeenCalled()
|
|
});
|
|
});
|
|
|
|
describe('onSendLater', ()=> {
|
|
it('sets scheduled date to "saving" and dispatches action', ()=> {
|
|
const button = makeButton(null, {sendLaterDate: 'date'})
|
|
spyOn(button, 'setState')
|
|
button.onSendLater({utc: ()=> 'utc'})
|
|
|
|
expect(SendLaterActions.sendLater).toHaveBeenCalled()
|
|
expect(button.setState).toHaveBeenCalledWith({saving: true})
|
|
});
|
|
});
|
|
|
|
describe('render', ()=> {
|
|
it('renders spinner if saving', ()=> {
|
|
const button = ReactDOM.findDOMNode(makeButton({saving: true}, null))
|
|
expect(button.title).toEqual('Saving send date...')
|
|
});
|
|
|
|
it('renders date if message is scheduled', ()=> {
|
|
spyOn(DateUtils, 'futureDateFromString').andReturn({fromNow: ()=> '5 minutes'})
|
|
const button = makeButton(null, {sendLaterDate: 'date'})
|
|
const span = ReactDOM.findDOMNode(findRenderedDOMComponentWithClass(button, 'at'))
|
|
expect(span.textContent).toEqual('Sending in 5 minutes')
|
|
});
|
|
|
|
it('does not render date if message is not scheduled', ()=> {
|
|
const button = makeButton(null, null)
|
|
expect(()=> {
|
|
findRenderedDOMComponentWithClass(button, 'at')
|
|
}).toThrow()
|
|
});
|
|
});
|
|
});
|