mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-14 13:44:41 +08:00
b4434f6617
Summary:
- Removes controlled focus in the composer!
- No React components ever perfom focus in lifecycle methods. Never again.
- A new `Utils.schedule({action, after, timeout})` helper makes it easy to say "setState or load draft, etc. and then focus"
- The DraftStore issues a focusDraft action after creating a draft, which causes the MessageList to focus and scroll to the desired composer, which itself decides which field to focus.
- The MessageList never focuses anything automatically.
- Refactors ComposerView apart — ComposerHeader handles all top fields, DraftSessionContainer handles draft session initialization and exposes props to ComposerView
- ComposerHeader now uses a KeyCommandRegion (with focusIn and focusOut) to do the expanding and collapsing of the participants fields. May rename that container very soon.
- Removes all CommandRegistry handling of tab and shift-tab. Unless you preventDefault, the browser does it's thing.
- Removes all tabIndexes greater than 1. This is an anti-pattern—assigning everything a tabIndex of 0 tells the browser to move between them based on their order in the DOM, and is almost always what you want.
- Adds "TabGroupRegion" which allows you to create a tab/shift-tabbing group, (so tabbing does not leave the active composer). Can't believe this isn't a browser feature.
Todos:
- Occasionally, clicking out of the composer contenteditable requires two clicks. This is because atomicEdit is restoring selection within the contenteditable and breaking blur.
- Because the ComposerView does not render until it has a draft, we're back to it being white in popout composers for a brief moment. We will fix this another way - all the "return unless draft" statements were untenable.
- Clicking a row in the thread list no longer shifts focus to the message list and focuses the last draft. This will be restored soon.
Test Plan: Broken
Reviewers: juan, evan
Reviewed By: juan, evan
Differential Revision: https://phab.nylas.com/D2814
77 lines
2.1 KiB
CoffeeScript
77 lines
2.1 KiB
CoffeeScript
_ = require 'underscore'
|
|
React = require 'react'
|
|
ReactDOM = require 'react-dom'
|
|
|
|
{Actions,
|
|
AccountStore,
|
|
WorkspaceStore} = require 'nylas-exports'
|
|
|
|
{RetinaImg,
|
|
KeyCommandsRegion} = require 'nylas-component-kit'
|
|
|
|
CategoryPickerPopover = require './category-picker-popover'
|
|
|
|
|
|
# This changes the category on one or more threads.
|
|
class CategoryPicker extends React.Component
|
|
@displayName: "CategoryPicker"
|
|
|
|
@containerRequired: false
|
|
|
|
@propTypes:
|
|
items: React.PropTypes.array
|
|
|
|
@contextTypes:
|
|
sheetDepth: React.PropTypes.number
|
|
|
|
constructor: (@props) ->
|
|
@_account = AccountStore.accountForItems(@props.items)
|
|
|
|
# If the threads we're picking categories for change, (like when they
|
|
# get their categories updated), we expect our parents to pass us new
|
|
# props. We don't listen to the DatabaseStore ourselves.
|
|
componentWillReceiveProps: (nextProps) ->
|
|
@_account = AccountStore.accountForItems(nextProps.items)
|
|
|
|
_keymapHandlers: ->
|
|
"application:change-category": @_onOpenCategoryPopover
|
|
|
|
_onOpenCategoryPopover: =>
|
|
return unless @props.items.length > 0
|
|
return unless @context.sheetDepth is WorkspaceStore.sheetStack().length - 1
|
|
buttonRect = ReactDOM.findDOMNode(@refs.button).getBoundingClientRect()
|
|
Actions.openPopover(
|
|
<CategoryPickerPopover
|
|
threads={@props.items}
|
|
account={@_account} />,
|
|
{originRect: buttonRect, direction: 'down'}
|
|
)
|
|
return
|
|
|
|
render: =>
|
|
return <span /> unless @_account
|
|
btnClasses = "btn btn-toolbar btn-category-picker"
|
|
img = ""
|
|
tooltip = ""
|
|
if @_account.usesLabels()
|
|
img = "toolbar-tag.png"
|
|
tooltip = "Apply Labels"
|
|
else
|
|
img = "toolbar-movetofolder.png"
|
|
tooltip = "Move to Folder"
|
|
|
|
return (
|
|
<KeyCommandsRegion style={order: -103} globalHandlers={@_keymapHandlers()}>
|
|
<button
|
|
tabIndex={-1}
|
|
ref="button"
|
|
title={tooltip}
|
|
onClick={@_onOpenCategoryPopover}
|
|
className={btnClasses} >
|
|
<RetinaImg name={img} mode={RetinaImg.Mode.ContentIsMask}/>
|
|
</button>
|
|
</KeyCommandsRegion>
|
|
)
|
|
|
|
|
|
module.exports = CategoryPicker
|