mirror of
https://github.com/Foundry376/Mailspring.git
synced 2024-11-15 14:20:38 +08:00
1e8fd46342
Summary:
This diff contains a few major changes:
1. Scribe is no longer used for the text editor. It's just a plain contenteditable region. The toolbar items (bold, italic, underline) still work. Scribe was causing React inconcistency issues in the following scenario:
- View thread with draft, edit draft
- Move to another thread
- Move back to thread with draft
- Move to another thread. Notice that one or more messages from thread with draft are still there.
There may be a way to fix this, but I tried for hours and there are Github Issues open on it's repository asking for React compatibility, so it may be fixed soon. For now contenteditable is working great.
2. Action.saveDraft() is no longer debounced in the DraftStore. Instead, firing that action causes the save to happen immediately, and the DraftStoreProxy has a new "DraftChangeSet" class which is responsbile for batching saves as the user interacts with the ComposerView. There are a couple big wins here:
- In the future, we may want to be able to call Action.saveDraft() in other situations and it should behave like a normal action. We may also want to expose the DraftStoreProxy as an easy way of backing interactive draft UI.
- Previously, when you added a contact to To/CC/BCC, this happened:
<input> -> Action.saveDraft -> (delay!!) -> Database -> DraftStore -> DraftStoreProxy -> View Updates
Increasing the delay to something reasonable like 200msec meant there was 200msec of lag before you saw the new view state.
To fix this, I created a new class called DraftChangeSet which is responsible for accumulating changes as they're made and firing Action.saveDraft. "Adding" a change to the change set also causes the Draft provided by the DraftStoreProxy to change immediately (the changes are a temporary layer on top of the database object). This means no delay while changes are being applied. There's a better explanation in the source!
This diff includes a few minor fixes as well:
1. Draft.state is gone—use Message.object = draft instead
2. String model attributes should never be null
3. Pre-send checks that can cancel draft send
4. Put the entire curl history and task queue into feedback reports
5. Cache localIds for extra speed
6. Move us up to latest React
Test Plan: No new tests - once we lock down this new design I'll write tests for the DraftChangeSet
Reviewers: evan
Reviewed By: evan
Differential Revision: https://review.inboxapp.com/D1125
84 lines
3.3 KiB
CoffeeScript
84 lines
3.3 KiB
CoffeeScript
module.exports =
|
|
'aws-sign@0.3.0':
|
|
repository: 'https://github.com/mikeal/aws-sign'
|
|
license: 'MIT'
|
|
source: 'index.js'
|
|
sourceText: """
|
|
/*!
|
|
* knox - auth
|
|
* Copyright(c) 2010 LearnBoost <dev@learnboost.com>
|
|
* MIT Licensed
|
|
*/
|
|
<content omitted>
|
|
"""
|
|
'bufferjs@2.0.0':
|
|
repository: 'https://github.com/coolaj86/node-bufferjs'
|
|
license: 'MIT'
|
|
source: 'LICENSE.MIT'
|
|
sourceText: """
|
|
Copyright (c) 2010 AJ ONeal (and Contributors)
|
|
|
|
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
|
|
|
|
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
"""
|
|
'buffers@0.1.1':
|
|
repository: "http://github.com/substack/node-buffers"
|
|
license: 'MIT'
|
|
source: 'README.markdown'
|
|
sourceText: """
|
|
<content omitted>
|
|
license
|
|
=======
|
|
|
|
MIT/X11
|
|
"""
|
|
'cheerio@0.15.0':
|
|
repository: "https://github.com/cheeriojs/cheerio"
|
|
license: 'MIT'
|
|
source: 'https://github.com/cheeriojs/cheerio/blob/master/package.json'
|
|
'specificity@0.1.3':
|
|
repository: 'https://github.com/keeganstreet/specificity'
|
|
license: 'MIT'
|
|
source: 'package.json in repository'
|
|
|
|
'promzard@0.2.0':
|
|
license: 'ISC'
|
|
source: 'LICENSE in the repository'
|
|
sourceText: """
|
|
The ISC License
|
|
|
|
Copyright (c) Isaac Z. Schlueter
|
|
|
|
Permission to use, copy, modify, and/or distribute this software for any
|
|
purpose with or without fee is hereby granted, provided that the above
|
|
copyright notice and this permission notice appear in all copies.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
|
|
IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
"""
|
|
|
|
'jschardet@1.1.0':
|
|
license: 'LGPL'
|
|
source: 'README.md in the repository'
|
|
sourceText: """
|
|
JsChardet
|
|
=========
|
|
|
|
Port of python's chardet (http://chardet.feedparser.org/).
|
|
|
|
License
|
|
-------
|
|
|
|
LGPL
|
|
"""
|
|
'core-js@0.4.10':
|
|
license: 'MIT'
|
|
source: 'http://rock.mit-license.org linked in source files and bower.json says MIT'
|